Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Reduce required Windows CMake version to 3.14#89390

Merged
cbracken merged 1 commit intoflutter:masterfrom
cbracken:cmake-314
Sep 4, 2021
Merged

Reduce required Windows CMake version to 3.14#89390
cbracken merged 1 commit intoflutter:masterfrom
cbracken:cmake-314

Conversation

@cbracken
Copy link
Member

@cbrackencbracken commentedSep 2, 2021•
edited
Loading

When we landed the CMake minimum requirement constraint for Visual
Studio 2019, we landed it with minimum version 3.15, since that's what
was shipping with the current version of VS 2019 at the time. Looking at
the release notes of earlier versions, it's clear that earlier versions
of Visual Studio 2019 shipped with version 3.14. See:
https://devblogs.microsoft.com/cppblog/visual-studio-cmake-support-clang-llvm-cmake-3-14-vcpkg-and-performance-improvements/

Looking at release notes for CMake 3.15, there are no features/fixes
introduced in that version that we are dependent on.
https://cmake.org/cmake/help/latest/release/3.15.html

Issue:#88589

Pre-launch Checklist

  • I read theContributor Guide and followed the process outlined there for submitting PRs.
  • I read theTree Hygiene wiki page, which explains my responsibilities.
  • I read and followed theFlutter Style Guide, includingFeatures we expect every widget to implement.
  • I signed theCLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel onDiscord.

@flutter-dashboardflutter-dashboardbot added d: examplesSample code and demos c: contributor-productivityTeam-specific productivity, code health, technical debt. toolAffects the "flutter" command-line tool. See also t: labels. labelsSep 2, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel inChat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read theTree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@stuartmorgan-gstuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I thought I found when I ported the CMake work to Linux I found that I did use 3.15, but looking back it was actually something from 3.12 that bit me. LGTM.

@cbracken
Copy link
MemberAuthor

Yep, looking at the 3.15 list, it looks like the new features introduced there (CMAKE_GENERATOR and a few others) aren't used in our CMake files, nor were the new options likeJOB_POOL, or properties likeVS_PACKAGE_REFERENCES, etc. Seems pretty safe.

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • This commit has empty status or empty checks. Please check the Google CLA status is present and Flutter Dashboard application has multiple checks.

Copy link
Contributor

@gspencergooggspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

When we landed the CMake minimum requirement constraint for VisualStudio 2019, we landed it with minimum version 3.15, since that's whatwas shipping with the current version of VS 2019 at the time. Looking atthe release notes of earlier versions, it's clear that earlier versionsof Visual Studio 2019 shipped with version 3.14. See:https://devblogs.microsoft.com/cppblog/visual-studio-cmake-support-clang-llvm-cmake-3-14-vcpkg-and-performance-improvements/Looking at release notes for CMake 3.15, there are no features/fixesintroduced in that version that we are dependent on.https://cmake.org/cmake/help/latest/release/3.15.htmlIssue:flutter#88589
@stuartmorgan-g
Copy link
Contributor

@thiagocarvalho0877 Please readhttps://github.com/flutter/flutter/wiki/Tree-hygiene#getting-a-code-review

approvals in the GitHub UI should be reserved for those with contributor access

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes

@gspencergooggspencergooggspencergoog approved these changes

+1 more reviewer

@thiagocarvalhodevthiagocarvalhodevthiagocarvalhodev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivityTeam-specific productivity, code health, technical debt.d: examplesSample code and demostoolAffects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cbracken@fluttergithubbot@stuartmorgan-g@gspencergoog@thiagocarvalhodev

Comments

[8]ページ先頭
©2009-2026 Movatter.jp