Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Revert "Refactor iOS integration_test API to support Swift, dynamically add native tests"#88377

Merged
jmagman merged 1 commit intomasterfrom
revert-88013-flat-integration-test-api
Aug 17, 2021
Merged

Revert "Refactor iOS integration_test API to support Swift, dynamically add native tests"#88377
jmagman merged 1 commit intomasterfrom
revert-88013-flat-integration-test-api

Conversation

@zanderso
Copy link
Member

Reverts#88013

Failures on CI

@zandersozanderso requested a review fromjmagmanAugust 17, 2021 21:24
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel inChat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read theTree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@zanderso
Copy link
MemberAuthor

https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20complex_layout_scroll_perf_ios__timeline_summary/1920/overview

Maybe this?

ld: '/opt/flutter/xcode/12c33/XCode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/Library/Frameworks/XCTest.framework/XCTest' does not contain bitcode. You must rebuild it with bitcode enabled (Xcode setting ENABLE_BITCODE), obtain an updated library from the vendor, or disable bitcode for this target. file '/opt/flutter/xcode/12c33/XCode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/Library/Frameworks/XCTest.framework/XCTest' for architecture arm64

@jmagman
Copy link
Member

LGTM, thanks@zanderso

@jmagman
Copy link
Member

Merging to green the build.

@jmagmanjmagman merged commit463f973 intomasterAug 17, 2021
@jmagmanjmagman deleted the revert-88013-flat-integration-test-api branchAugust 17, 2021 21:54
blasten pushed a commit to blasten/flutter that referenced this pull requestAug 19, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jmagmanjmagmanjmagman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zanderso@jmagman

Comments


[8]ページ先頭

©2009-2026 Movatter.jp