- Notifications
You must be signed in to change notification settings - Fork30k
FlutterDriver: deprecate enableAccessibility; redirect it to setSemantics; add setSemantics tests#82939
Merged
yjbanov merged 3 commits intoflutter:masterfromMay 20, 2021
Conversation
ditman approved these changesMay 19, 2021
Member
ditman left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Does this fix#65192 ?
ContributorAuthor
yjbanov commentedMay 19, 2021
Yep. Thanks for the heads up. Updated the PR description. |
Member
ditman commentedMay 19, 2021
|
ContributorAuthor
yjbanov commentedMay 19, 2021
Done. |
8 tasks
Uh oh!
There was an error while loading.Please reload this page.
dnfield approved these changesMay 19, 2021
Contributor
dnfield left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Contributor
fluttergithubbot commentedMay 19, 2021
This pull request is not suitable for automatic merging in its current state.
|
ContributorAuthor
yjbanov commentedMay 20, 2021
Google testing is broken due to unrelated PR. All failing tests are mobile tests. Shouldn't be affected by this PR. Landing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
a: tests"flutter test", flutter_test, or one of our tests c: contributor-productivityTeam-specific productivity, code health, technical debt. d: examplesSample code and demos frameworkflutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
On mobile
FlutterDriver.enableAccessibilitynever worked. On the web it has the same effect assetSemantics, except that it used to rely on an implementation detail that's not cross-platform (it would look for a specific DOM element and dispatch an artificial tap on it, which is brittle and doesn't work on all browsers).Fixes#65192
Pre-launch Checklist
///).