Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

FlutterDriver: deprecate enableAccessibility; redirect it to setSemantics; add setSemantics tests#82939

Merged
yjbanov merged 3 commits intoflutter:masterfrom
yjbanov:deprecate-enableAccessibility
May 20, 2021
Merged

FlutterDriver: deprecate enableAccessibility; redirect it to setSemantics; add setSemantics tests#82939
yjbanov merged 3 commits intoflutter:masterfrom
yjbanov:deprecate-enableAccessibility

Conversation

@yjbanov
Copy link
Contributor

@yjbanovyjbanov commentedMay 19, 2021
edited
Loading

On mobileFlutterDriver.enableAccessibility never worked. On the web it has the same effect assetSemantics, except that it used to rely on an implementation detail that's not cross-platform (it would look for a specific DOM element and dispatch an artificial tap on it, which is brittle and doesn't work on all browsers).

Fixes#65192

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

@yjbanovyjbanov requested review fromditman anddnfieldMay 19, 2021 20:33
@flutter-dashboardflutter-dashboardbot added a: tests"flutter test", flutter_test, or one of our tests d: examplesSample code and demos frameworkflutter/packages/flutter repository. See also f: labels. c: contributor-productivityTeam-specific productivity, code health, technical debt. labelsMay 19, 2021
Copy link
Member

@ditmanditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Does this fix#65192 ?

@yjbanov
Copy link
ContributorAuthor

Does this fix#65192 ?

Yep. Thanks for the heads up. Updated the PR description.

ditman reacted with thumbs up emoji

@ditman
Copy link
Member

/tmp/flutter sdk/packages/flutter_driver/lib/src/driver/driver.dart:177: Deprecation notice does not match required pattern.See: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes

@yjbanov
Copy link
ContributorAuthor

/tmp/flutter sdk/packages/flutter_driver/lib/src/driver/driver.dart:177: Deprecation notice does not match required pattern.See: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes

Done.

ditman reacted with thumbs up emoji

Copy link
Contributor

@dnfielddnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@yjbanov
Copy link
ContributorAuthor

Google testing is broken due to unrelated PR. All failing tests are mobile tests. Shouldn't be affected by this PR. Landing.

ditman reacted with thumbs up emoji

@yjbanovyjbanov merged commit2f3f5f0 intoflutter:masterMay 20, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ditmanditmanditman approved these changes

+1 more reviewer

@dnfielddnfielddnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.d: examplesSample code and demosframeworkflutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FlutterDriver: Support enabling accessibility on Mobile web (iOS-Safari)

4 participants

@yjbanov@ditman@fluttergithubbot@dnfield

Comments


[8]ページ先頭

©2009-2026 Movatter.jp