- Notifications
You must be signed in to change notification settings - Fork30k
ImplementsClipRSuperellipse on backdrop filter on platform view#182643
ImplementsClipRSuperellipse on backdrop filter on platform view#182643Hari-07 wants to merge 4 commits intoflutter:masterfrom
ClipRSuperellipse on backdrop filter on platform view#182643Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code Review
The pull request correctly implements support forClipRSuperellipse on backdrop filters for platform views on iOS by utilizing thecornerCurve property ofCALayer. This is a valuable addition for achieving high-fidelity UI effects. However, there are two important issues to address: thecornerCurve property is only available on iOS 13.0 and later, so an availability check is required to prevent crashes on older supported iOS versions (like iOS 12). Additionally, becauseUIVisualEffectView instances are reused withinChildClippingView, thecornerCurve property must be explicitly reset tokCACornerCurveCircular when the clip is not a superellipse to avoid leaking the continuous curve state from previous frames. The review follows the Flutter Style Guide, focusing on correctness and platform compatibility.
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformViewsController.mm OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
ClipRSuperellipseon backdrop filter on platform viewList which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
Fixes#179125
If you had to change anything in theflutter/tests repo, include a link to the migration guide as per thebreaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel onDiscord.
Note: The Flutter team is currently trialing the use ofGemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.