Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ImplementsClipRSuperellipse on backdrop filter on platform view#182643

Open
Hari-07 wants to merge 4 commits intoflutter:masterfrom
Hari-07:backdrop-clip-rse
Open

ImplementsClipRSuperellipse on backdrop filter on platform view#182643
Hari-07 wants to merge 4 commits intoflutter:masterfrom
Hari-07:backdrop-clip-rse

Conversation

@Hari-07
Copy link
Contributor

  • ImplementsClipRSuperellipse on backdrop filter on platform view

List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
Fixes#179125

If you had to change anything in theflutter/tests repo, include a link to the migration guide as per thebreaking change policy.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel onDiscord.

Note: The Flutter team is currently trialing the use ofGemini Code Assist for GitHub. Comments from thegemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@Hari-07Hari-07 requested a review froma team as acode ownerFebruary 19, 2026 21:56
@github-actionsgithub-actionsbot added platform-iosiOS applications specifically engineflutter/engine related. See also e: labels. team-iosOwned by iOS platform team labelsFeb 19, 2026
Copy link
Contributor

@gemini-code-assistgemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code Review

The pull request correctly implements support forClipRSuperellipse on backdrop filters for platform views on iOS by utilizing thecornerCurve property ofCALayer. This is a valuable addition for achieving high-fidelity UI effects. However, there are two important issues to address: thecornerCurve property is only available on iOS 13.0 and later, so an availability check is required to prevent crashes on older supported iOS versions (like iOS 12). Additionally, becauseUIVisualEffectView instances are reused withinChildClippingView, thecornerCurve property must be explicitly reset tokCACornerCurveCircular when the clip is not a superellipse to avoid leaking the continuous curve state from previous frames. The review follows the Flutter Style Guide, focusing on correctness and platform compatibility.

@hellohuanlinhellohuanlin self-requested a reviewFebruary 19, 2026 22:46
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@hellohuanlinhellohuanlinAwaiting requested review from hellohuanlin

1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

engineflutter/engine related. See also e: labels.platform-iosiOS applications specificallyteam-iosOwned by iOS platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ImplementClipRSuperellipse on backdrop filter

1 participant

@Hari-07

Comments


[8]ページ先頭

©2009-2026 Movatter.jp