Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

RemoveExtendSelectionByPageIntent#182642

Open
Renzo-Olivares wants to merge 1 commit intoflutter:masterfrom
Renzo-Olivares:remove-extendselectionbypage
Open

RemoveExtendSelectionByPageIntent#182642
Renzo-Olivares wants to merge 1 commit intoflutter:masterfrom
Renzo-Olivares:remove-extendselectionbypage

Conversation

@Renzo-Olivares
Copy link
Contributor

This API was added in#105497 but never used.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actionsgithub-actionsbot added a: text inputEntering text in a text field or keyboard related problems frameworkflutter/packages/flutter repository. See also f: labels. labelsFeb 19, 2026
Copy link
Contributor

@gemini-code-assistgemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code Review

This pull request removes theExtendSelectionByPageIntent class and its associated handler_extendSelectionByPage fromEditableTextState. The removal is based on the observation that this API has remained unused within the framework since its introduction. While removing unused code is generally good for maintainability,ExtendSelectionByPageIntent is a public class, and its removal constitutes a breaking change. Following the Flutter breaking change policy, public APIs should typically be deprecated before removal.

I am having trouble creating individual review comments. Click here to see my feedback.

packages/flutter/lib/src/widgets/text_editing_intents.dart (270-275)

medium

Removing the public classExtendSelectionByPageIntent is a breaking change. Even if it is not used within the Flutter framework, it may be used by developers in their own applications. According to the Flutter breaking change policy, public APIs should be deprecated before removal. Please consider deprecating this class instead of removing it entirely, unless it was never part of a stable release.

References
  1. Code should follow the guidance and principles described in the Flutter contribution guide, which includes the breaking change policy.(link)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

a: text inputEntering text in a text field or keyboard related problemsframeworkflutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Renzo-Olivares

Comments

[8]ページ先頭
©2009-2026 Movatter.jp