- Notifications
You must be signed in to change notification settings - Fork30k
Comments
Reland Standardize on Test* widgets in *_tester.dart files#182632
Reland Standardize on Test* widgets in *_tester.dart files#182632justinmc wants to merge 3 commits intoflutter:masterfrom
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code Review
This pull request standardizes test widget files by movingTestButton tobutton_tester.dart andTestTextField toeditable_text_tester.dart, and renaminglist_tile_test_utils.dart tolist_tile_tester.dart. The changes primarily consist of updating import paths across multiple test files to reflect this refactoring. I have identified one file where the import path was not correctly updated, which will cause a compilation error.
Uh oh!
There was an error while loading.Please reload this page.
navaronbracke commentedFeb 19, 2026
#182416 Relanded that change 2 days ago, so this should be fine to retry as well. |
navaronbracke left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, with a doc nit (same remark as on the original PR :p )
| key: editableTextKey, | ||
| autofillHints: widget.autofillHints, | ||
| autofocus: widget.autofocus, | ||
| backgroundCursorColor: _red, // Colors.red, required by editable text. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Here and below it as well
| backgroundCursorColor: _red,//Colors.red,required by editable text. | |
| backgroundCursorColor: _red,// required by editable text. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah my fault, maybe in the old PR I fixed one and didn't realize there were more. Got them now!
Relands#182395, which was reverted in#182406.According to@gaaclarke, the revert might have been due to#181634 and not this PR.