I read theContributor Guide and followed the process outlined there for submitting PRs.
I read theTree Hygiene wiki page, which explains my responsibilities.
I read and followed theFlutter Style Guide, includingFeatures we expect every widget to implement.
I signed theCLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with///).
I added new tests to check the change I am making, or this PR istest-exempt.
I followed thebreaking change policy and addedData Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel onDiscord.

Note: The Flutter team is currently trialing the use ofGemini Code Assist for GitHub. Comments from thegemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

iOS can set application locale before view controller is set

53a0345

chunhtai requested a review fromvashworth

October 6, 2025 17:20

github-actionsbot added platform-ios

iOS applications specifically

engineflutter/engine related. See also e: labels. labels

Oct 6, 2025

gemini-code-assistbot reviewed

Oct 6, 2025

View reviewed changes

Copy link

Contributor

gemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code Review

This pull request modifiesPlatformViewIOS to allow setting the application locale even before aFlutterViewController is attached. It achieves this by caching the locale in a newapplication_locale_ member variable and applying it when the view controller is set. The change also includes a new unit test to verify this behavior. My review provides suggestions to improve code maintainability by refactoring duplicated logic and to fix a potential syntax error in the new test.