Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix DropdownButtonFormField does not inherit local InputDecorationTheme#176564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
bleroux wants to merge1 commit intoflutter:master
base:master
Choose a base branch
Loading
frombleroux:fix_DropdownButtonFormField_does_not_inherit_local_InputDecorationTheme

Conversation

bleroux
Copy link
Contributor

Description

This PR replaces globalThemeData.inputDecorationTheme usage inDropdownButtonFormField withInputDecorationTheme.of which returns the ambientInputDecorationTheme.
It is a follow up to#168981 which introducesInputDecorationTheme.of.

Related Issue

FixesDropdownButtonFormField does not inherit local InputDecorationTheme

Tests

  • Adds 1 test

@github-actionsgithub-actionsbot added frameworkflutter/packages/flutter repository. See also f: labels. f: material designflutter/packages/flutter/material repository. labelsOct 6, 2025
Copy link
Contributor

@gemini-code-assistgemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code Review

This pull request correctly addresses an issue whereDropdownButtonFormField was not inheriting from a localInputDecorationTheme. The changes replace the globalTheme.of(context).inputDecorationTheme withInputDecorationTheme.of(context), which is the correct approach to respect ambient themes. A new test case has been added to specifically verify this fix, ensuring that local theme overrides are applied as expected. The changes are clean, focused, and improve the theming capabilities of the widget.

@blerouxbleroux requested a review fromjustinmcOctober 6, 2025 14:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@justinmcjustinmcAwaiting requested review from justinmc

1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
f: material designflutter/packages/flutter/material repository.frameworkflutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DropdownButtonFormField does not inherit local InputDecorationTheme
1 participant
@bleroux
[8]ページ先頭
©2009-2025 Movatter.jp