- Notifications
You must be signed in to change notification settings - Fork29.3k
Make sure that a SubmenuButton doesn't crash in 0x0 environment#176535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code Review
This pull request adds a regression test to ensure thatSubmenuButton does not crash when placed in a zero-sized environment. The test case is well-structured and minimal, effectively reproducing the scenario described in the associated issue. My only suggestion is to add a comment referencing the issue number to improve code maintainability.
| expect(tester.getRect(findMenuPanels()).width,800.0- reservedPadding.horizontal); | ||
| }); | ||
| testWidgets('SubmenuButton does not crash at zero area', (WidgetTester tester)async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
To improve long-term maintainability and provide context for this test, it would be beneficial to add a comment referencing the GitHub issue it addresses. This is a common practice in the Flutter repository.1
| testWidgets('SubmenuButton does not crash at zero area', (WidgetTester tester)async { | |
| // Regression test for https://github.com/flutter/flutter/issues/6537 | |
| testWidgets('SubmenuButton does not crash at zero area', (WidgetTester tester)async { |
Style Guide References
Footnotes
Documentation should be useful and explain the 'why' and the 'how'. While this applies to public APIs, the principle of documenting the 'why' is also valuable for tests, especially regression tests.↩
This is my attempt to handle#6537 for the SubmenuButton widget.