NotificationsYou must be signed in to change notification settings
Fork29.3k
Star173k

Make sure that a RadioMenuButton doesn't crash in 0x0 environment#176516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

ahmedsameha1 wants to merge1 commit intoflutter:master

base:master

Choose a base branch

fromahmedsameha1:handle#6537-RadioMenuButton

Open

Make sure that a RadioMenuButton doesn't crash in 0x0 environment#176516

ahmedsameha1 wants to merge1 commit intoflutter:masterfromahmedsameha1:handle#6537-RadioMenuButton

+35 −0

Conversation

Copy link

Contributor

ahmedsameha1 commentedOct 4, 2025

This is my attempt to handle#6537 for the RadioMenuButton widget.

Make sure that a RadioMenuButton doesn't crash in 0x0 environment

d7271ea

github-actionsbot added framework

flutter/packages/flutter repository. See also f: labels.

f: material designflutter/packages/flutter/material repository. labels

Oct 4, 2025

gemini-code-assistbot reviewed

Oct 4, 2025

View reviewed changes

Copy link

Contributor

gemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code Review

This pull request adds regression tests to ensure thatRadioMenuButton andCheckboxMenuButton do not crash when placed in a zero-sized environment. The added tests are clear, concise, and correctly reproduce the scenario described in the associated issue, improving test coverage for these edge cases. The changes look good.