- Notifications
You must be signed in to change notification settings - Fork28.9k
removex86 unused codepaths#170191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
removex86 unused codepaths#170191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, but I'll leave final approval to@reidbaker.
Please hold merging until@jtmcdole or someone from the engine team approves. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think there is more x86 code to clean up so we might need to change the pr description from "fixes ..." to "partial work on ..."
Code pointers for future contributors.
| gcc_toolchain("x86") { |
| ifabi=='x86': |
| #elif defined(FML_ARCH_CPU_X86) |
| android_toolchains_helper("x86") { |
flutter/engine/src/flutter/tools/engine_tool/lib/src/flutter_tool_interop/target_platform.dart
Line 29 ine9e989b
| /// Android x86. |
| ' sdkmanager "system-images;android-27;google_apis_playstore;x86"', |
| # gen_snapshot), the host_cpu is set to x86. However, the correct prebuilt |
| TargetPlatform.androidX86=>'android_${mode}_x86', |
This is just a warning.
| constString androidX86DeprecationWarning= |
ci configs
| "--android-cpu=x86", |
| "name":"ci/android_debug_x86", |
| if (target_cpu!="x86") { |
Impeller documenation
| | x86||| android-x86|| |
Uh oh!
There was an error while loading.Please reload this page.
Updated with tip of tree and re-executed presubmits. Thank you for your contribution. |
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself,is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read theTree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel inDiscord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, soall reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
AbdeMohlbi commentedJun 9, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
description Updated. |
Waiting on one more approver from the engine team then we can merge. |
Can you address the lint failure? run_release_tests looks like a real failure as well. |
AbdeMohlbi commentedJun 9, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
the ktlint failure is fixed , but i dunno about the run_release_tests it seems unrelated |
Remvoe x86 from the ABI set when compiling Android integration tests, as x86 is no longer supported for Flutter builds.Seeflutter/flutter#170191
based on [thiscomment](#170191 (review))Towards#170142## Pre-launch Checklist- [x] I read the [Contributor Guide] and followed the process outlinedthere for submitting PRs.- [x] I read the [Tree Hygiene] wiki page, which explains myresponsibilities.- [x] I read and followed the [Flutter Style Guide], including [Featureswe expect every widget to implement].- [x] I signed the [CLA].- [x] I listed at least one issue that this PR fixes in the descriptionabove.- [x] All existing and new tests are passing.- [ ] I updated/added relevant documentation (doc comments with `///`).- [ ] I added new tests to check the change I am making, or this PR is[test-exempt].- [ ] I followed the [breaking change policy] and added [Data DrivenFixes] where supported.If you need help, consider asking for advice on the #hackers-new channelon [Discord].<!-- Links -->[Contributor Guide]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview[Tree Hygiene]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md[test-exempt]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests[Flutter Style Guide]:https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md[Features we expect every widget to implement]:https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement[CLA]:https://cla.developers.google.com/[flutter/tests]:https://github.com/flutter/tests[breaking change policy]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes[Discord]:https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md[Data Driven Fixes]:https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
based on [thiscomment](#170191 (review))Towards#170142## Pre-launch Checklist- [x] I read the [Contributor Guide] and followed the process outlinedthere for submitting PRs.- [x] I read the [Tree Hygiene] wiki page, which explains myresponsibilities.- [x] I read and followed the [Flutter Style Guide], including [Featureswe expect every widget to implement].- [x] I signed the [CLA].- [x] I listed at least one issue that this PR fixes in the descriptionabove.- [x] All existing and new tests are passing.- [ ] I updated/added relevant documentation (doc comments with `///`).- [ ] I added new tests to check the change I am making, or this PR is[test-exempt].- [ ] I followed the [breaking change policy] and added [Data DrivenFixes] where supported.If you need help, consider asking for advice on the #hackers-new channelon [Discord].<!-- Links -->[Contributor Guide]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview[Tree Hygiene]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md[test-exempt]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests[Flutter Style Guide]:https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md[Features we expect every widget to implement]:https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement[CLA]:https://cla.developers.google.com/[flutter/tests]:https://github.com/flutter/tests[breaking change policy]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes[Discord]:https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md[Data Driven Fixes]:https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Uh oh!
There was an error while loading.Please reload this page.
Towards#170142
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel onDiscord.