Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Reland #163662 [web][a11y]Delete _childContainerElement#165434

Merged
auto-submit[bot] merged 10 commits intoflutter:masterfrom
hannah-hyj:deletewebcontainer2
Mar 22, 2025
Merged

Reland #163662 [web][a11y]Delete _childContainerElement#165434
auto-submit[bot] merged 10 commits intoflutter:masterfrom
hannah-hyj:deletewebcontainer2

Conversation

@hannah-hyj
Copy link
Member

@hannah-hyjhannah-hyj commentedMar 18, 2025•
edited
Loading

Reland#163662 with some changes

  1. when a node's role changes and reparenting it, append children to it
  2. Merge optimization fromOptimize recomputePositionAndSize #165352

fix:#45205

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel onDiscord.

@github-actionsgithub-actionsbot added a: text inputEntering text in a text field or keyboard related problems engineflutter/engine related. See also e: labels. a: accessibilityAccessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: scrollingViewports, list views, slivers, etc. platform-webWeb applications specifically labelsMar 18, 2025
Copy link
Contributor

@yjbanovyjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm

@hannah-hyj
Copy link
MemberAuthor

cc@chunhtai as this is also a blocker for list semantics behavior

@hannah-hyjhannah-hyj added the autosubmitMerge PR when tree becomes green via auto submit App labelMar 21, 2025
@auto-submitauto-submitbot removed the autosubmitMerge PR when tree becomes green via auto submit App labelMar 22, 2025
@auto-submit
Copy link
Contributor

autosubmit label was removed for flutter/flutter/165434, because - The status or check suiteGoogle testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@hannah-hyjhannah-hyj added the autosubmitMerge PR when tree becomes green via auto submit App labelMar 22, 2025
@auto-submitauto-submitbot added this pull request to themerge queueMar 22, 2025
Merged via the queue intoflutter:master with commitefa81a7Mar 22, 2025
171 checks passed
@flutter-dashboardflutter-dashboardbot removed the autosubmitMerge PR when tree becomes green via auto submit App labelMar 22, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestApr 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestApr 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestApr 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestApr 1, 2025
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull requestJun 9, 2025
…er#165434)Relandflutter#163662  with some changes 1. when a node's role changes and reparenting it, append children to it 2. Merge optimization fromflutter/pull/165352fix:flutter#45205 ## Pre-launch Checklist- [ ] I read the [Contributor Guide] and followed the process outlinedthere for submitting PRs.- [ ] I read the [Tree Hygiene] wiki page, which explains myresponsibilities.- [ ] I read and followed the [Flutter Style Guide], including [Featureswe expect every widget to implement].- [ ] I signed the [CLA].- [ ] I listed at least one issue that this PR fixes in the descriptionabove.- [ ] I updated/added relevant documentation (doc comments with `///`).- [ ] I added new tests to check the change I am making, or this PR is[test-exempt].- [ ] I followed the [breaking change policy] and added [Data DrivenFixes] where supported.- [ ] All existing and new tests are passing.If you need help, consider asking for advice on the #hackers-new channelon [Discord].<!-- Links -->[Contributor Guide]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview[Tree Hygiene]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md[test-exempt]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests[Flutter Style Guide]:https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md[Features we expect every widget to implement]:https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement[CLA]:https://cla.developers.google.com/[flutter/tests]:https://github.com/flutter/tests[breaking change policy]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes[Discord]:https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md[Data Driven Fixes]:https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull requestAug 14, 2025
…er#165434)Relandflutter#163662  with some changes 1. when a node's role changes and reparenting it, append children to it 2. Merge optimization fromflutter/pull/165352fix:flutter#45205 ## Pre-launch Checklist- [ ] I read the [Contributor Guide] and followed the process outlinedthere for submitting PRs.- [ ] I read the [Tree Hygiene] wiki page, which explains myresponsibilities.- [ ] I read and followed the [Flutter Style Guide], including [Featureswe expect every widget to implement].- [ ] I signed the [CLA].- [ ] I listed at least one issue that this PR fixes in the descriptionabove.- [ ] I updated/added relevant documentation (doc comments with `///`).- [ ] I added new tests to check the change I am making, or this PR is[test-exempt].- [ ] I followed the [breaking change policy] and added [Data DrivenFixes] where supported.- [ ] All existing and new tests are passing.If you need help, consider asking for advice on the #hackers-new channelon [Discord].<!-- Links -->[Contributor Guide]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview[Tree Hygiene]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md[test-exempt]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests[Flutter Style Guide]:https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md[Features we expect every widget to implement]:https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement[CLA]:https://cla.developers.google.com/[flutter/tests]:https://github.com/flutter/tests[breaking change policy]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes[Discord]:https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md[Data Driven Fixes]:https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@yjbanovyjbanovyjbanov approved these changes

Assignees

No one assigned

Labels

a: accessibilityAccessibility, e.g. VoiceOver or TalkBack. (aka a11y)a: text inputEntering text in a text field or keyboard related problemsengineflutter/engine related. See also e: labels.f: scrollingViewports, list views, slivers, etc.platform-webWeb applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[web] a11y support for tables

2 participants

@hannah-hyj@yjbanov

Comments

[8]ページ先頭
©2009-2026 Movatter.jp