Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

[Impeller] disable depth-stencil and MSAA for gaussian and downsample.#165137

Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom
jonahwilliams:blur-msaa-ds
Mar 13, 2025
Merged

[Impeller] disable depth-stencil and MSAA for gaussian and downsample.#165137
auto-submit[bot] merged 2 commits intoflutter:masterfrom
jonahwilliams:blur-msaa-ds

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliamsjonahwilliams commentedMar 13, 2025
edited
Loading

Using MSAA w/ depth stencil requires extra work on the GPU to track multiple samples and clear the depth/stencil textures.

See also:https://docs.qualcomm.com/bundle/publicresource/topics/80-78185-2/best_practices.html

Its unclearhow much this matters, but adreno recommends minimizing bin count and as such minimizing msaa samples. Well, we can fully minimize it by not enabling it. Removing depth stencil was also considered in the past, this should be removed as it requires us to clear, which isn't free.

Its likely this won't have a huge performance impact, but seems like a good best practice.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself,is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read theTree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel inDiscord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, soall reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actionsgithub-actionsbot added engineflutter/engine related. See also e: labels. e: impellerImpeller rendering backend issues and features requests labelsMar 13, 2025
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Clickhere to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visitWriting a golden file test forpackage:flutter.

Reviewers: Read theTree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request#165137 at sha90f59dc

@flutter-dashboardflutter-dashboardbot added the will affect goldensChanges to golden files labelMar 13, 2025
@jonahwilliams
Copy link
ContributorAuthor

Arguably this is a semantically equivalent change as we weren't using depth/stencil nor do we benefit from the extra MSAA samples (as MSAA only anti aliases geometry and the only geometry here is a fullscreen rect).

Copy link
Member

@gaaclarkegaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm

@jonahwilliamsjonahwilliams added autosubmitMerge PR when tree becomes green via auto submit App and removed autosubmitMerge PR when tree becomes green via auto submit App labelsMar 13, 2025
@auto-submitauto-submitbot removed the autosubmitMerge PR when tree becomes green via auto submit App labelMar 13, 2025
@auto-submit
Copy link
Contributor

autosubmit label was removed for flutter/flutter/165137, because - The status or check suiteGoogle testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@jonahwilliamsjonahwilliams added the autosubmitMerge PR when tree becomes green via auto submit App labelMar 13, 2025
@auto-submitauto-submitbot added this pull request to themerge queueMar 13, 2025
Merged via the queue intoflutter:master with commit91b7617Mar 13, 2025
174 checks passed
@flutter-dashboardflutter-dashboardbot removed the autosubmitMerge PR when tree becomes green via auto submit App labelMar 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 16, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 16, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 25, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 25, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 26, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 26, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 26, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 26, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 26, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 26, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 26, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 26, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 27, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 27, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 27, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 27, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 27, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 27, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 27, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 27, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 28, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 21, 2025
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull requestAug 14, 2025
flutter#165137)Using MSAA w/ depth stencil requires extra work on the GPU to trackmultiple samples and clear the depth/stencil textures.See also:https://docs.qualcomm.com/bundle/publicresource/topics/80-78185-2/best_practices.htmlIts unclear _how_ much this matters, but adreno recommends minimizingbin count and as such minimizing msaa samples. Well, we can fullyminimize it by not enabling it. Removing depth stencil was alsoconsidered in the past, this should be removed as it requires us toclear, which isn't free.Its likely this won't have a huge performance impact, but seems like agood best practice.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gaaclarkegaaclarkegaaclarke approved these changes

Assignees

No one assigned

Labels

e: impellerImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.will affect goldensChanges to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonahwilliams@gaaclarke

[8]ページ先頭

©2009-2026 Movatter.jp