- Notifications
You must be signed in to change notification settings - Fork30k
Comments
[Impeller] disable depth-stencil and MSAA for gaussian and downsample.#165137
[Impeller] disable depth-stencil and MSAA for gaussian and downsample.#165137auto-submit[bot] merged 2 commits intoflutter:masterfrom
Conversation
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself,is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read theTree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel inDiscord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, soall reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
Golden file changes have been found for this pull request. Clickhere to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visitWriting a golden file test for Reviewers: Read theTree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jonahwilliams commentedMar 13, 2025
Arguably this is a semantically equivalent change as we weren't using depth/stencil nor do we benefit from the extra MSAA samples (as MSAA only anti aliases geometry and the only geometry here is a fullscreen rect). |
gaaclarke left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm
autosubmit label was removed for flutter/flutter/165137, because - The status or check suiteGoogle testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
91b7617Uh oh!
There was an error while loading.Please reload this page.
flutter#165137)Using MSAA w/ depth stencil requires extra work on the GPU to trackmultiple samples and clear the depth/stencil textures.See also:https://docs.qualcomm.com/bundle/publicresource/topics/80-78185-2/best_practices.htmlIts unclear _how_ much this matters, but adreno recommends minimizingbin count and as such minimizing msaa samples. Well, we can fullyminimize it by not enabling it. Removing depth stencil was alsoconsidered in the past, this should be removed as it requires us toclear, which isn't free.Its likely this won't have a huge performance impact, but seems like agood best practice.
Uh oh!
There was an error while loading.Please reload this page.
Using MSAA w/ depth stencil requires extra work on the GPU to track multiple samples and clear the depth/stencil textures.
See also:https://docs.qualcomm.com/bundle/publicresource/topics/80-78185-2/best_practices.html
Its unclearhow much this matters, but adreno recommends minimizing bin count and as such minimizing msaa samples. Well, we can fully minimize it by not enabling it. Removing depth stencil was also considered in the past, this should be removed as it requires us to clear, which isn't free.
Its likely this won't have a huge performance impact, but seems like a good best practice.