Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

android_host_app_v2_embedding update dependencies and documentation#164195

Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom
reidbaker:i149836-api-35-update-part-9
Feb 27, 2025
Merged

android_host_app_v2_embedding update dependencies and documentation#164195
auto-submit[bot] merged 2 commits intoflutter:masterfrom
reidbaker:i149836-api-35-update-part-9

Conversation

@reidbaker
Copy link
Contributor

@reidbakerreidbaker commentedFeb 26, 2025
edited
Loading

Related to#149836

Last of the non api 35 references in flutter/flutter for targetSdk and compileSdk.
find . -type f -name "build.gradle" | xargs grep -e "targetSdk" | tr -d '=' | tr -s ' ' | grep -v flutter\.targetSdkVersion | grep -v engine/src/flutter/third_party/ | grep -v "targetSdk 35"
find . -type f -name "build.gradle" | xargs grep -e "compileSdk" | tr -d '=' | tr -s ' ' | grep -v flutter\.compileSdkVersion | grep -v engine/src/flutter/third_party/ | grep -v "compileSdk 35"

rewrite of#163622 after this test was updated to run against a newer version of gradle and agp inhttps://github.com/flutter/flutter/pull/163849/files#diff-83b6ad7c016bffbb682664eb65c576a7ebf9c312fc60727c0e0e20f5641cbc2aR462

Android-API-And-Related-Versions.md was updated to reflect that after further investigation that android is using "=" in their documentation and that the space syntax is discouraged. Equals is setting a property and space is the equivalent to a function call likecompileSdk(35) and assignment is prefered.

The use of equals for proprty assignment also aligns withhttps://docs.gradle.org/current/userguide/migrating_from_groovy_to_kotlin_dsl.html#prepare_your_groovy_scripts

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

…ation for what device lab test uses this code and android version best practices
@reidbakerreidbaker requested a review froma teamFebruary 26, 2025 15:51
@github-actionsgithub-actionsbot added c: contributor-productivityTeam-specific productivity, code health, technical debt. frameworkflutter/packages/flutter repository. See also f: labels. d: docs/flutter/flutter/docs, for contributors labelsFeb 26, 2025
Copy link
Contributor

@camsim99camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM :)

@reidbakerreidbaker added the autosubmitMerge PR when tree becomes green via auto submit App labelFeb 27, 2025
@auto-submitauto-submitbot added this pull request to themerge queueFeb 27, 2025
Merged via the queue intoflutter:master with commit72c2447Feb 27, 2025
148 checks passed
@flutter-dashboardflutter-dashboardbot removed the autosubmitMerge PR when tree becomes green via auto submit App labelFeb 27, 2025
github-merge-queuebot pushed a commit that referenced this pull requestFeb 27, 2025
…atibility across repo and update android version documentation (#164198)Related to#149836- Remove last usages of minSdkVersion/compileSdkVersion/targetSdkVersionin favor of minSdk/compileSdk/targetSdk. That do not also use`flutter.minSdkVersion` etc. (that will happen in another pass)- Update the files that used "SdkVersion" to use equals for setting newvalues. [Not yet landed documentationchange](https://github.com/flutter/flutter/pull/164195/files#diff-ee6ec18be8d752e2696c8ccc8bec2f202dfc29a43b3b4f9d8041aa6bc3e852a1)- align sourceCompatibility and targetCompatibility across repo to useJavaVersion.* and update android version documentation.This pr updates `kotlinOptions jvmTarget` documentation but does not fixall existing usages.This pr is expected to cause no behavioral changes. This pr makes logical sense after#164195 but can be landed in anyorder.## Pre-launch Checklist- [x] I read the [Contributor Guide] and followed the process outlinedthere for submitting PRs.- [x] I read the [Tree Hygiene] wiki page, which explains myresponsibilities.- [x] I read and followed the [Flutter Style Guide], including [Featureswe expect every widget to implement].- [x] I signed the [CLA].- [x] I listed at least one issue that this PR fixes in the descriptionabove.- [x] I updated/added relevant documentation (doc comments with `///`).- [ ] I added new tests to check the change I am making, or this PR is[test-exempt].- [x] I followed the [breaking change policy] and added [Data DrivenFixes] where supported.- [x] All existing and new tests are passing.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 28, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 28, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 28, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 28, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 28, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 2, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 2, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 2, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@camsim99camsim99camsim99 approved these changes

@matanlureymatanlureyAwaiting requested review from matanlurey

Assignees

No one assigned

Labels

c: contributor-productivityTeam-specific productivity, code health, technical debt.d: docs/flutter/flutter/docs, for contributorsframeworkflutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reidbaker@camsim99

Comments


[8]ページ先頭

©2009-2026 Movatter.jp