Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

Suppress stderr during Xcode command line installation check#163785

Merged
auto-submit[bot] merged 3 commits intoflutter:masterfrom
jmagman:xcode-stderr
Feb 21, 2025
Merged

Suppress stderr during Xcode command line installation check#163785
auto-submit[bot] merged 3 commits intoflutter:masterfrom
jmagman:xcode-stderr

Conversation

@jmagman
Copy link
Member

@jmagmanjmagman commentedFeb 20, 2025
edited
Loading

Xcode is in some kind of half-installed state (missing a cert? unknown) on some devicelab Macs#161655. As of#163685 Xcode cipd installation isn't requested as part of the builder configuration, so it seems like Xcode is just hanging out on that devicelab bot quasi-installed, unrelated to the recipe.

In any case, the tool is actually doing the right thing and detecting that Xcode isn't in a good state and continuing as if it isn't installed, but is logging a wall of error text about it to stderr, which that Android test doesn't like. Instead of updating the test to allow stderr, instead swap the Xcode installation path toexitsHappySync to only check the exit code (or exception), which is the original intention behind the Xcode command line checks.

try {
return _processManager.runSync(cli, environment: environment).exitCode==0;
}onExceptioncatch (error) {
_logger.printTrace('$cli failed with $error');
returnfalse;
}

Fixes#161655

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel onDiscord.

@github-actionsgithub-actionsbot added toolAffects the "flutter" command-line tool. See also t: labels. a: desktopRunning on desktop team-iosOwned by iOS platform team labelsFeb 20, 2025
Copy link
Contributor

@vashworthvashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@jmagmanjmagman added the autosubmitMerge PR when tree becomes green via auto submit App labelFeb 21, 2025
@auto-submitauto-submitbot added this pull request to themerge queueFeb 21, 2025
Merged via the queue intoflutter:master with commitbb306c5Feb 21, 2025
139 checks passed
@flutter-dashboardflutter-dashboardbot removed the autosubmitMerge PR when tree becomes green via auto submit App labelFeb 21, 2025
github-merge-queuebot pushed a commit that referenced this pull requestFeb 25, 2025
#163895)After#163785 there was still anunexpected `xcrun simctl` output on a machine with Xcode only halfinstalled#161655.Check `simctl` is installed before trying to list booted simulatordevices or runtimes.Should address#161655.## Pre-launch Checklist- [x] I read the [Contributor Guide] and followed the process outlinedthere for submitting PRs.- [x] I read the [Tree Hygiene] wiki page, which explains myresponsibilities.- [x] I read and followed the [Flutter Style Guide], including [Featureswe expect every widget to implement].- [x] I signed the [CLA].- [x] I listed at least one issue that this PR fixes in the descriptionabove.- [x] I updated/added relevant documentation (doc comments with `///`).- [x] I added new tests to check the change I am making, or this PR is[test-exempt].- [x] I followed the [breaking change policy] and added [Data DrivenFixes] where supported.- [x] All existing and new tests are passing.If you need help, consider asking for advice on the #hackers-new channelon [Discord].<!-- Links -->[Contributor Guide]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview[Tree Hygiene]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md[test-exempt]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests[Flutter Style Guide]:https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md[Features we expect every widget to implement]:https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement[CLA]:https://cla.developers.google.com/[flutter/tests]:https://github.com/flutter/tests[breaking change policy]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes[Discord]:https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md[Data Driven Fixes]:https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vashworthvashworthvashworth approved these changes

Assignees

No one assigned

Labels

a: desktopRunning on desktopteam-iosOwned by iOS platform teamtoolAffects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mac_mokey run_debug_test_android is 10.42% flaky

2 participants

@jmagman@vashworth

[8]ページ先頭

©2009-2026 Movatter.jp