Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Show 'started' messages, explain how to debug hangs in the Android JUnit tests#163242

Merged
auto-submit[bot] merged 3 commits intoflutter:masterfrom
matanlurey:improve-messaging-and-readme-junit-tests
Feb 13, 2025
Merged

Show 'started' messages, explain how to debug hangs in the Android JUnit tests#163242
auto-submit[bot] merged 3 commits intoflutter:masterfrom
matanlurey:improve-messaging-and-readme-junit-tests

Conversation

@matanlurey
Copy link
Contributor

There is more work to do, i.e.#163239, to make this a better experience, but better than nothing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel inDiscord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself,is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read theTree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, soall reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actionsgithub-actionsbot added platform-androidAndroid applications specifically engineflutter/engine related. See also e: labels. labelsFeb 13, 2025
Copy link
Member

@gmackallgmackall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM outside of comment

@matanlureymatanlurey added the autosubmitMerge PR when tree becomes green via auto submit App labelFeb 13, 2025
@auto-submitauto-submitbot removed the autosubmitMerge PR when tree becomes green via auto submit App labelFeb 13, 2025
@auto-submit
Copy link
Contributor

autosubmit label was removed for flutter/flutter/163242, because - The status or check suiteCI Caught Failure has failed. Please fix the issues identified (or deflake) before re-applying this label.

@matanlureymatanlurey added the autosubmitMerge PR when tree becomes green via auto submit App labelFeb 13, 2025
@auto-submitauto-submitbot removed the autosubmitMerge PR when tree becomes green via auto submit App labelFeb 13, 2025
@auto-submit
Copy link
Contributor

autosubmit label was removed for flutter/flutter/163242, because - The status or check suiteMac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@matanlureymatanlurey added the autosubmitMerge PR when tree becomes green via auto submit App labelFeb 13, 2025
@auto-submitauto-submitbot added this pull request to themerge queueFeb 13, 2025
Merged via the queue intoflutter:master with commit9ffdd3aFeb 13, 2025
175 checks passed
@flutter-dashboardflutter-dashboardbot removed the autosubmitMerge PR when tree becomes green via auto submit App labelFeb 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 16, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 16, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 19, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 19, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 19, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gmackallgmackallgmackall approved these changes

Assignees

No one assigned

Labels

engineflutter/engine related. See also e: labels.platform-androidAndroid applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matanlurey@gmackall

Comments


[8]ページ先頭

©2009-2026 Movatter.jp