- Notifications
You must be signed in to change notification settings - Fork30k
Show 'started' messages, explain how to debug hangs in the Android JUnit tests#163242
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel inDiscord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself,is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read theTree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, soall reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
Uh oh!
There was an error while loading.Please reload this page.
gmackall left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM outside of comment
autosubmit label was removed for flutter/flutter/163242, because - The status or check suiteCI Caught Failure has failed. Please fix the issues identified (or deflake) before re-applying this label. |
autosubmit label was removed for flutter/flutter/163242, because - The status or check suiteMac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
9ffdd3aUh oh!
There was an error while loading.Please reload this page.
There is more work to do, i.e.#163239, to make this a better experience, but better than nothing.