- Notifications
You must be signed in to change notification settings - Fork30k
[canvaskit] UsetransferToImageBitmap instead ofcreateImageBitmap#163175
Merged
auto-submit[bot] merged 5 commits intoflutter:masterfromFeb 14, 2025
Merged
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel inDiscord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself,is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read theTree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, soall reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
| bitmap = _offscreenCanvas!.transferToImageBitmap(); | ||
| } else { | ||
| bitmapSource = _canvasElement! as JSObject; | ||
| bitmap = await createImageBitmap(bitmapSource, ( |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Won't this pay the cost ofcreateImageBitmap even if we're rendering using WebGL?
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This branch is for the case where (1) we are rendering with one WebGL canvas but (2) we don't have support forOffscreenCanvas. In this case we create a single element with a WebGL context and use that like anOffscreenCanvas; the canvas is never added to the DOM, it is only used for creating bitmaps for thebitmaprenderer canvases.
yjbanov approved these changesFeb 13, 2025
Contributor
yjbanov left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Contributor
autosubmit label was removed for flutter/flutter/163175, because - The status or check suiteCI Caught Failure has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Merged via the queue intoflutter:master with commitFeb 14, 2025
934af97 173 checks passed
Uh oh!
There was an error while loading.Please reload this page.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 19, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 19, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 19, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 20, 2025
auto-submitbot pushed a commit to flutter/packages that referenced this pull requestFeb 20, 2025
Roll Flutter frome8f34a9 to39b4951 (95 revisions)flutter/flutter@e8f34a9...39b49512025-02-18 fluttergithubbot@gmail.com Marks Windows_arm64 plugin_test_windows to be flaky (flutter/flutter#163123)2025-02-18 jonahwilliams@google.com [android] use macro definition to shrink repetitive JNI code size. (flutter/flutter#163395)2025-02-18 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#163474)2025-02-18 mdebbar@google.com [web] Cleanup everything HTML from the engine (outside html/ folder) (flutter/flutter#162840)2025-02-18 flar@google.com [Impeller] add support for rational bezier conics to Path (flutter/flutter#163282)2025-02-18 36861262+QuncCccccc@users.noreply.github.com Change `cardTheme`, `dialogTheme`, and `tabBarTheme` type to `xxxThemeData` (flutter/flutter#157292)2025-02-18 jason-simmons@users.noreply.github.com Update integration test and benchmark Android .gitignore files to match the current app template (flutter/flutter#163276)2025-02-18 chinmaygarde@google.com [Impeller] Don't create a redundant typography context. (flutter/flutter#163513)2025-02-18 engine-flutter-autoroll@skia.org Roll Dart SDK from fcef25f18e4d to 023ac80cef14 (1 revision) (flutter/flutter#163110)2025-02-18 reidbaker@google.com update module_host_with_custom_build_v2_embedding to target android 35 and to use the latest gradle and agp versions (flutter/flutter#163542)2025-02-18 jonahwilliams@google.com [Impeller] when binding to READ_FRAMEBUFFER, treat multisampled textures as single sampled. (flutter/flutter#163345)2025-02-18 sokolovskyi.konstantin@gmail.com Add missing properties to _ArcPaintPredicate. (flutter/flutter#162572)2025-02-18 engine-flutter-autoroll@skia.org Roll Packages from8542af3 tocb4fb13 (4 revisions) (flutter/flutter#163544)2025-02-18 reidbaker@google.com Remove bringup for android_display_cutout (flutter/flutter#163312)2025-02-18 reidbaker@google.com Create VersionUtils class and unit tests and extract logic out of flutter.groovy (flutter/flutter#163166)2025-02-18 matanlurey@users.noreply.github.com Invalidate `pod install` output if `.flutter-plugins-dependencies` content changes. (flutter/flutter#163275)2025-02-18 robert.ancell@canonical.com Replace hard coded numbers with mouse button defines (flutter/flutter#163503)2025-02-18 engine-flutter-autoroll@skia.org Roll Skia from 9147a9654043 to 6da10829d017 (1 revision) (flutter/flutter#163531)2025-02-18 engine-flutter-autoroll@skia.org Roll Skia from 92aaa4e20ea7 to 9147a9654043 (2 revisions) (flutter/flutter#163512)2025-02-17 engine-flutter-autoroll@skia.org Roll Skia from 71a160edc9d9 to 92aaa4e20ea7 (1 revision) (flutter/flutter#163488)2025-02-17 engine-flutter-autoroll@skia.org Roll Packages from625023a to8542af3 (21 revisions) (flutter/flutter#163484)2025-02-17 engine-flutter-autoroll@skia.org Roll Skia from 7e3129d5db11 to 71a160edc9d9 (1 revision) (flutter/flutter#163459)2025-02-17 engine-flutter-autoroll@skia.org Roll Skia from 40ce5ef20d22 to 7e3129d5db11 (1 revision) (flutter/flutter#163451)2025-02-16 engine-flutter-autoroll@skia.org Roll Skia from bb166c85957b to 40ce5ef20d22 (1 revision) (flutter/flutter#163403)2025-02-15 engine-flutter-autoroll@skia.org Roll Skia from ff94581f1f8a to bb166c85957b (1 revision) (flutter/flutter#163381)2025-02-15 58529443+srujzs@users.noreply.github.com Move DWDS initialization into the onLoadEndCallback for the DDC library bundle format (flutter/flutter#163338)2025-02-14 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Handle MakeGrContext returning null (flutter/flutter#163332)2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 13a3b6f34ee8 to ff94581f1f8a (1 revision) (flutter/flutter#163347)2025-02-14 bkonyi@google.com Fix failing chrome_dev_mode tests (flutter/flutter#163346)2025-02-14 47866232+chunhtai@users.noreply.github.com Adds all semantics roles (flutter/flutter#163075)2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 20924303cc25 to 13a3b6f34ee8 (1 revision) (flutter/flutter#163336)2025-02-14 bkonyi@google.com [ Widget Preview ] Add experimental support for web-based widget preview environment (flutter/flutter#163154)2025-02-14 jonahwilliams@google.com [Impeller] don't use glFramebufferBlit for onscreen restore. (flutter/flutter#163327)2025-02-14 58529443+srujzs@users.noreply.github.com Align web terminal messages with the VM (flutter/flutter#163268)2025-02-14 victoreronmosele@gmail.com Manually roll customer_testing to enable rfw tests (flutter/flutter#163030)2025-02-14 ybz975218925@gmail.com Refactor SliverMainAxisGroup for reverse mode. (flutter/flutter#161849)2025-02-14 30870216+gaaclarke@users.noreply.github.com Tweaked TextContents math to avoid floating point errors (flutter/flutter#162480)2025-02-14 kevinjchisholm@google.com [release] Update cherry-pick CHANGELOG requirements (flutter/flutter#163318)2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 85722a1db585 to 20924303cc25 (2 revisions) (flutter/flutter#163293)2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 5a38d23ee247 to 85722a1db585 (1 revision) (flutter/flutter#163286)2025-02-14 matanlurey@users.noreply.github.com Add `.flutter-plugins-dependencies` to `FlutterBuildSystem`; update logic, add tests. (flutter/flutter#163278)2025-02-14 jhy03261997@gmail.com Add table related semantics role (flutter/flutter#162339)2025-02-14 jason-simmons@users.noreply.github.com [Impeller] Call glDebugMessageControlKHR only if the KHR_debug extension is available (flutter/flutter#163273)2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 748415976ad1 to 5a38d23ee247 (3 revisions) (flutter/flutter#163271)2025-02-14 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Use `transferToImageBitmap` instead of `createImageBitmap` (flutter/flutter#163175)2025-02-14 jacksongardner@google.com [skwasm] Use `transferToImageBitmap` instead of `createImageBitmap` (flutter/flutter#163251)...
harryterkelsen added a commit to harryterkelsen/flutter that referenced this pull requestFeb 28, 2025
flutter#163175)Use `transferToImageBitmap` instead of `createImageBitmap` if we have an`OffscreenCanvas`.Now that we are sizing the `OffscreenCanvas` exactly to the frame size,we can use `transferToImageBitmap`, which should be zero-copy andtherefore faster than `createImageBitmap`. In testing, this speedsthings up a little bit but we still drop frames compared tomulti-Surface rasterization.Helps withflutter#162618## Pre-launch Checklist- [x] I read the [Contributor Guide] and followed the process outlinedthere for submitting PRs.- [x] I read the [Tree Hygiene] wiki page, which explains myresponsibilities.- [x] I read and followed the [Flutter Style Guide], including [Featureswe expect every widget to implement].- [x] I signed the [CLA].- [x] I listed at least one issue that this PR fixes in the descriptionabove.- [x] I updated/added relevant documentation (doc comments with `///`).- [ ] I added new tests to check the change I am making, or this PR is[test-exempt].- [x] I followed the [breaking change policy] and added [Data DrivenFixes] where supported.- [x] All existing and new tests are passing.If you need help, consider asking for advice on the #hackers-new channelon [Discord].<!-- Links -->[Contributor Guide]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview[Tree Hygiene]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md[test-exempt]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests[Flutter Style Guide]:https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md[Features we expect every widget to implement]:https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement[CLA]:https://cla.developers.google.com/[flutter/tests]:https://github.com/flutter/tests[breaking change policy]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes[Discord]:https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md[Data Driven Fixes]:https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 21, 2025
androidseb pushed a commit to androidseb/packages that referenced this pull requestJun 8, 2025
Roll Flutter frome8f34a9 to39b4951 (95 revisions)flutter/flutter@e8f34a9...39b49512025-02-18 fluttergithubbot@gmail.com Marks Windows_arm64 plugin_test_windows to be flaky (flutter/flutter#163123)2025-02-18 jonahwilliams@google.com [android] use macro definition to shrink repetitive JNI code size. (flutter/flutter#163395)2025-02-18 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#163474)2025-02-18 mdebbar@google.com [web] Cleanup everything HTML from the engine (outside html/ folder) (flutter/flutter#162840)2025-02-18 flar@google.com [Impeller] add support for rational bezier conics to Path (flutter/flutter#163282)2025-02-18 36861262+QuncCccccc@users.noreply.github.com Change `cardTheme`, `dialogTheme`, and `tabBarTheme` type to `xxxThemeData` (flutter/flutter#157292)2025-02-18 jason-simmons@users.noreply.github.com Update integration test and benchmark Android .gitignore files to match the current app template (flutter/flutter#163276)2025-02-18 chinmaygarde@google.com [Impeller] Don't create a redundant typography context. (flutter/flutter#163513)2025-02-18 engine-flutter-autoroll@skia.org Roll Dart SDK from fcef25f18e4d to 023ac80cef14 (1 revision) (flutter/flutter#163110)2025-02-18 reidbaker@google.com update module_host_with_custom_build_v2_embedding to target android 35 and to use the latest gradle and agp versions (flutter/flutter#163542)2025-02-18 jonahwilliams@google.com [Impeller] when binding to READ_FRAMEBUFFER, treat multisampled textures as single sampled. (flutter/flutter#163345)2025-02-18 sokolovskyi.konstantin@gmail.com Add missing properties to _ArcPaintPredicate. (flutter/flutter#162572)2025-02-18 engine-flutter-autoroll@skia.org Roll Packages from8542af3 tocb4fb13 (4 revisions) (flutter/flutter#163544)2025-02-18 reidbaker@google.com Remove bringup for android_display_cutout (flutter/flutter#163312)2025-02-18 reidbaker@google.com Create VersionUtils class and unit tests and extract logic out of flutter.groovy (flutter/flutter#163166)2025-02-18 matanlurey@users.noreply.github.com Invalidate `pod install` output if `.flutter-plugins-dependencies` content changes. (flutter/flutter#163275)2025-02-18 robert.ancell@canonical.com Replace hard coded numbers with mouse button defines (flutter/flutter#163503)2025-02-18 engine-flutter-autoroll@skia.org Roll Skia from 9147a9654043 to 6da10829d017 (1 revision) (flutter/flutter#163531)2025-02-18 engine-flutter-autoroll@skia.org Roll Skia from 92aaa4e20ea7 to 9147a9654043 (2 revisions) (flutter/flutter#163512)2025-02-17 engine-flutter-autoroll@skia.org Roll Skia from 71a160edc9d9 to 92aaa4e20ea7 (1 revision) (flutter/flutter#163488)2025-02-17 engine-flutter-autoroll@skia.org Roll Packages from625023a to8542af3 (21 revisions) (flutter/flutter#163484)2025-02-17 engine-flutter-autoroll@skia.org Roll Skia from 7e3129d5db11 to 71a160edc9d9 (1 revision) (flutter/flutter#163459)2025-02-17 engine-flutter-autoroll@skia.org Roll Skia from 40ce5ef20d22 to 7e3129d5db11 (1 revision) (flutter/flutter#163451)2025-02-16 engine-flutter-autoroll@skia.org Roll Skia from bb166c85957b to 40ce5ef20d22 (1 revision) (flutter/flutter#163403)2025-02-15 engine-flutter-autoroll@skia.org Roll Skia from ff94581f1f8a to bb166c85957b (1 revision) (flutter/flutter#163381)2025-02-15 58529443+srujzs@users.noreply.github.com Move DWDS initialization into the onLoadEndCallback for the DDC library bundle format (flutter/flutter#163338)2025-02-14 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Handle MakeGrContext returning null (flutter/flutter#163332)2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 13a3b6f34ee8 to ff94581f1f8a (1 revision) (flutter/flutter#163347)2025-02-14 bkonyi@google.com Fix failing chrome_dev_mode tests (flutter/flutter#163346)2025-02-14 47866232+chunhtai@users.noreply.github.com Adds all semantics roles (flutter/flutter#163075)2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 20924303cc25 to 13a3b6f34ee8 (1 revision) (flutter/flutter#163336)2025-02-14 bkonyi@google.com [ Widget Preview ] Add experimental support for web-based widget preview environment (flutter/flutter#163154)2025-02-14 jonahwilliams@google.com [Impeller] don't use glFramebufferBlit for onscreen restore. (flutter/flutter#163327)2025-02-14 58529443+srujzs@users.noreply.github.com Align web terminal messages with the VM (flutter/flutter#163268)2025-02-14 victoreronmosele@gmail.com Manually roll customer_testing to enable rfw tests (flutter/flutter#163030)2025-02-14 ybz975218925@gmail.com Refactor SliverMainAxisGroup for reverse mode. (flutter/flutter#161849)2025-02-14 30870216+gaaclarke@users.noreply.github.com Tweaked TextContents math to avoid floating point errors (flutter/flutter#162480)2025-02-14 kevinjchisholm@google.com [release] Update cherry-pick CHANGELOG requirements (flutter/flutter#163318)2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 85722a1db585 to 20924303cc25 (2 revisions) (flutter/flutter#163293)2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 5a38d23ee247 to 85722a1db585 (1 revision) (flutter/flutter#163286)2025-02-14 matanlurey@users.noreply.github.com Add `.flutter-plugins-dependencies` to `FlutterBuildSystem`; update logic, add tests. (flutter/flutter#163278)2025-02-14 jhy03261997@gmail.com Add table related semantics role (flutter/flutter#162339)2025-02-14 jason-simmons@users.noreply.github.com [Impeller] Call glDebugMessageControlKHR only if the KHR_debug extension is available (flutter/flutter#163273)2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 748415976ad1 to 5a38d23ee247 (3 revisions) (flutter/flutter#163271)2025-02-14 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Use `transferToImageBitmap` instead of `createImageBitmap` (flutter/flutter#163175)2025-02-14 jacksongardner@google.com [skwasm] Use `transferToImageBitmap` instead of `createImageBitmap` (flutter/flutter#163251)...
FMorschel pushed a commit to FMorschel/packages that referenced this pull requestJun 9, 2025
Roll Flutter frome8f34a9 to39b4951 (95 revisions)flutter/flutter@e8f34a9...39b49512025-02-18 fluttergithubbot@gmail.com Marks Windows_arm64 plugin_test_windows to be flaky (flutter/flutter#163123)2025-02-18 jonahwilliams@google.com [android] use macro definition to shrink repetitive JNI code size. (flutter/flutter#163395)2025-02-18 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#163474)2025-02-18 mdebbar@google.com [web] Cleanup everything HTML from the engine (outside html/ folder) (flutter/flutter#162840)2025-02-18 flar@google.com [Impeller] add support for rational bezier conics to Path (flutter/flutter#163282)2025-02-18 36861262+QuncCccccc@users.noreply.github.com Change `cardTheme`, `dialogTheme`, and `tabBarTheme` type to `xxxThemeData` (flutter/flutter#157292)2025-02-18 jason-simmons@users.noreply.github.com Update integration test and benchmark Android .gitignore files to match the current app template (flutter/flutter#163276)2025-02-18 chinmaygarde@google.com [Impeller] Don't create a redundant typography context. (flutter/flutter#163513)2025-02-18 engine-flutter-autoroll@skia.org Roll Dart SDK from fcef25f18e4d to 023ac80cef14 (1 revision) (flutter/flutter#163110)2025-02-18 reidbaker@google.com update module_host_with_custom_build_v2_embedding to target android 35 and to use the latest gradle and agp versions (flutter/flutter#163542)2025-02-18 jonahwilliams@google.com [Impeller] when binding to READ_FRAMEBUFFER, treat multisampled textures as single sampled. (flutter/flutter#163345)2025-02-18 sokolovskyi.konstantin@gmail.com Add missing properties to _ArcPaintPredicate. (flutter/flutter#162572)2025-02-18 engine-flutter-autoroll@skia.org Roll Packages from8542af3 tocb4fb13 (4 revisions) (flutter/flutter#163544)2025-02-18 reidbaker@google.com Remove bringup for android_display_cutout (flutter/flutter#163312)2025-02-18 reidbaker@google.com Create VersionUtils class and unit tests and extract logic out of flutter.groovy (flutter/flutter#163166)2025-02-18 matanlurey@users.noreply.github.com Invalidate `pod install` output if `.flutter-plugins-dependencies` content changes. (flutter/flutter#163275)2025-02-18 robert.ancell@canonical.com Replace hard coded numbers with mouse button defines (flutter/flutter#163503)2025-02-18 engine-flutter-autoroll@skia.org Roll Skia from 9147a9654043 to 6da10829d017 (1 revision) (flutter/flutter#163531)2025-02-18 engine-flutter-autoroll@skia.org Roll Skia from 92aaa4e20ea7 to 9147a9654043 (2 revisions) (flutter/flutter#163512)2025-02-17 engine-flutter-autoroll@skia.org Roll Skia from 71a160edc9d9 to 92aaa4e20ea7 (1 revision) (flutter/flutter#163488)2025-02-17 engine-flutter-autoroll@skia.org Roll Packages from625023a to8542af3 (21 revisions) (flutter/flutter#163484)2025-02-17 engine-flutter-autoroll@skia.org Roll Skia from 7e3129d5db11 to 71a160edc9d9 (1 revision) (flutter/flutter#163459)2025-02-17 engine-flutter-autoroll@skia.org Roll Skia from 40ce5ef20d22 to 7e3129d5db11 (1 revision) (flutter/flutter#163451)2025-02-16 engine-flutter-autoroll@skia.org Roll Skia from bb166c85957b to 40ce5ef20d22 (1 revision) (flutter/flutter#163403)2025-02-15 engine-flutter-autoroll@skia.org Roll Skia from ff94581f1f8a to bb166c85957b (1 revision) (flutter/flutter#163381)2025-02-15 58529443+srujzs@users.noreply.github.com Move DWDS initialization into the onLoadEndCallback for the DDC library bundle format (flutter/flutter#163338)2025-02-14 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Handle MakeGrContext returning null (flutter/flutter#163332)2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 13a3b6f34ee8 to ff94581f1f8a (1 revision) (flutter/flutter#163347)2025-02-14 bkonyi@google.com Fix failing chrome_dev_mode tests (flutter/flutter#163346)2025-02-14 47866232+chunhtai@users.noreply.github.com Adds all semantics roles (flutter/flutter#163075)2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 20924303cc25 to 13a3b6f34ee8 (1 revision) (flutter/flutter#163336)2025-02-14 bkonyi@google.com [ Widget Preview ] Add experimental support for web-based widget preview environment (flutter/flutter#163154)2025-02-14 jonahwilliams@google.com [Impeller] don't use glFramebufferBlit for onscreen restore. (flutter/flutter#163327)2025-02-14 58529443+srujzs@users.noreply.github.com Align web terminal messages with the VM (flutter/flutter#163268)2025-02-14 victoreronmosele@gmail.com Manually roll customer_testing to enable rfw tests (flutter/flutter#163030)2025-02-14 ybz975218925@gmail.com Refactor SliverMainAxisGroup for reverse mode. (flutter/flutter#161849)2025-02-14 30870216+gaaclarke@users.noreply.github.com Tweaked TextContents math to avoid floating point errors (flutter/flutter#162480)2025-02-14 kevinjchisholm@google.com [release] Update cherry-pick CHANGELOG requirements (flutter/flutter#163318)2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 85722a1db585 to 20924303cc25 (2 revisions) (flutter/flutter#163293)2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 5a38d23ee247 to 85722a1db585 (1 revision) (flutter/flutter#163286)2025-02-14 matanlurey@users.noreply.github.com Add `.flutter-plugins-dependencies` to `FlutterBuildSystem`; update logic, add tests. (flutter/flutter#163278)2025-02-14 jhy03261997@gmail.com Add table related semantics role (flutter/flutter#162339)2025-02-14 jason-simmons@users.noreply.github.com [Impeller] Call glDebugMessageControlKHR only if the KHR_debug extension is available (flutter/flutter#163273)2025-02-14 engine-flutter-autoroll@skia.org Roll Skia from 748415976ad1 to 5a38d23ee247 (3 revisions) (flutter/flutter#163271)2025-02-14 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Use `transferToImageBitmap` instead of `createImageBitmap` (flutter/flutter#163175)2025-02-14 jacksongardner@google.com [skwasm] Use `transferToImageBitmap` instead of `createImageBitmap` (flutter/flutter#163251)...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Use
transferToImageBitmapinstead ofcreateImageBitmapif we have anOffscreenCanvas.Now that we are sizing the
OffscreenCanvasexactly to the frame size, we can usetransferToImageBitmap, which should be zero-copy and therefore faster thancreateImageBitmap. In testing, this speeds things up a little bit but we still drop frames compared to multi-Surface rasterization.Helps with#162618
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel onDiscord.