- Notifications
You must be signed in to change notification settings - Fork30k
Removeandroid_verified_input, it was never added to CI and does not run locally.#162895
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfromFeb 7, 2025
Conversation
Contributor
reidbaker commentedFeb 7, 2025
@matanlurey does this run locally? if so maybe we should get it running instead of deleting it? |
reidbaker approved these changesFeb 7, 2025
ContributorAuthor
matanlurey commentedFeb 7, 2025
No, it does not run locally |
Contributor
reidbaker commentedFeb 7, 2025
:shamecube: |
Merged via the queue intoflutter:master with commitFeb 7, 2025
2c5c114 147 of 148 checks passed
Uh oh!
There was an error while loading.Please reload this page.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 8, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 8, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 9, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 9, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 10, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 10, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 10, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 10, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 10, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 11, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 11, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 12, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 12, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 12, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 12, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 13, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 13, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 13, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 14, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 14, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 14, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 14, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 14, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 15, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 15, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 16, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 16, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 17, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 17, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 17, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 20, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 20, 2025
… does not run locally. (flutter/flutter#162895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 21, 2025
… does not run locally. (flutter/flutter#162895)
gmackall pushed a commit to gmackall/flutter that referenced this pull requestOct 30, 2025
… does not run locally. (flutter#162895)"This reverts commit2c5c114.
9 tasks
github-merge-queuebot pushed a commit that referenced this pull requestOct 31, 2025
This was originally landed in#140836but the pr did not hook it up to ci. It was then removed in#162895First got the driver test running:`flutter drive -t lib/main.dart --driver test_driver/main_test.dart`from the directory of the test appthen got the devicelab harness working via`../../bin/cache/dart-sdk/bin/dart bin/test_runner.dart test -tandroid_verified_input_test` from the `dev/devicelab` directoryand then finally hooked up to ci with the configuration in the`.ci.yaml`Restoring in a passing state, in advance of landing#177572## Pre-launch Checklist- [x] I read the [Contributor Guide] and followed the process outlinedthere for submitting PRs.- [x] I read the [Tree Hygiene] wiki page, which explains myresponsibilities.- [x] I read and followed the [Flutter Style Guide], including [Featureswe expect every widget to implement].- [x] I signed the [CLA].- [x] I listed at least one issue that this PR fixes in the descriptionabove.- [x] I updated/added relevant documentation (doc comments with `///`).- [x] I added new tests to check the change I am making, or this PR is[test-exempt].- [x] I followed the [breaking change policy] and added [Data DrivenFixes] where supported.- [x] All existing and new tests are passing.If you need help, consider asking for advice on the #hackers-new channelon [Discord].**Note**: The Flutter team is currently trialing the use of [Gemini CodeAssist forGitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).Comments from the `gemini-code-assist` bot should not be taken asauthoritative feedback from the Flutter team. If you find its commentsuseful you can update your code accordingly, but if you are unsure ordisagree with the feedback, please feel free to wait for a Flutter teammember's review for guidance on which automated comments should beaddressed.<!-- Links -->[Contributor Guide]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview[Tree Hygiene]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md[test-exempt]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests[Flutter Style Guide]:https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md[Features we expect every widget to implement]:https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement[CLA]:https://cla.developers.google.com/[flutter/tests]:https://github.com/flutter/tests[breaking change policy]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes[Discord]:https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md[Data Driven Fixes]:https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md---------Co-authored-by: Gray Mackall <mackall@google.com>
reidbaker pushed a commit to AbdeMohlbi/flutter that referenced this pull requestDec 10, 2025
This was originally landed influtter#140836but the pr did not hook it up to ci. It was then removed influtter#162895First got the driver test running:`flutter drive -t lib/main.dart --driver test_driver/main_test.dart`from the directory of the test appthen got the devicelab harness working via`../../bin/cache/dart-sdk/bin/dart bin/test_runner.dart test -tandroid_verified_input_test` from the `dev/devicelab` directoryand then finally hooked up to ci with the configuration in the`.ci.yaml`Restoring in a passing state, in advance of landingflutter#177572## Pre-launch Checklist- [x] I read the [Contributor Guide] and followed the process outlinedthere for submitting PRs.- [x] I read the [Tree Hygiene] wiki page, which explains myresponsibilities.- [x] I read and followed the [Flutter Style Guide], including [Featureswe expect every widget to implement].- [x] I signed the [CLA].- [x] I listed at least one issue that this PR fixes in the descriptionabove.- [x] I updated/added relevant documentation (doc comments with `///`).- [x] I added new tests to check the change I am making, or this PR is[test-exempt].- [x] I followed the [breaking change policy] and added [Data DrivenFixes] where supported.- [x] All existing and new tests are passing.If you need help, consider asking for advice on the #hackers-new channelon [Discord].**Note**: The Flutter team is currently trialing the use of [Gemini CodeAssist forGitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).Comments from the `gemini-code-assist` bot should not be taken asauthoritative feedback from the Flutter team. If you find its commentsuseful you can update your code accordingly, but if you are unsure ordisagree with the feedback, please feel free to wait for a Flutter teammember's review for guidance on which automated comments should beaddressed.<!-- Links -->[Contributor Guide]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview[Tree Hygiene]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md[test-exempt]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests[Flutter Style Guide]:https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md[Features we expect every widget to implement]:https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement[CLA]:https://cla.developers.google.com/[flutter/tests]:https://github.com/flutter/tests[breaking change policy]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes[Discord]:https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md[Data Driven Fixes]:https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md---------Co-authored-by: Gray Mackall <mackall@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Someone could always resurrect it via
git-magic (or GitHub), but let's not maintain (including Gradle lock files, Dart analysis, etc) unused code that hasn't run in 12+ months./cc@johnmccutchan