Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Start removing unsound null safety from the web SDK tools.#162850

Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom
matanlurey:flutter_tools-web-sdk-remove-unsound
Feb 7, 2025
Merged

Start removing unsound null safety from the web SDK tools.#162850
auto-submit[bot] merged 2 commits intoflutter:masterfrom
matanlurey:flutter_tools-web-sdk-remove-unsound

Conversation

@matanlurey
Copy link
Contributor

@matanlureymatanlurey commentedFeb 7, 2025•
edited
Loading

Towards#162846.

On an internal chat, I asked:

Is there a reason I don't understand whyflutter should still support "unsound" null-safety modes?

@jonahwilliams:

I don't believe its possible to have non-null safe flutter code.

There is quite a bit of code and branches, so to keep the PRs understandable/approachable, this first PR removes the ability to have theDevFS implementations for the web SDK choose between sound and unsound null safety, and removes the mapping accordingly.

The enums still exist, but can be cleaned up in a follow-up PR (you'd want to rename to remove "sound" as well, ideally).

srujzs reacted with thumbs up emoji
@github-actionsgithub-actionsbot added the toolAffects the "flutter" command-line tool. See also t: labels. labelFeb 7, 2025
@matanlureymatanlurey added the autosubmitMerge PR when tree becomes green via auto submit App labelFeb 7, 2025
@auto-submitauto-submitbot added this pull request to themerge queueFeb 7, 2025
Merged via the queue intoflutter:master with commit2d30caeFeb 7, 2025
139 checks passed
@flutter-dashboardflutter-dashboardbot removed the autosubmitMerge PR when tree becomes green via auto submit App labelFeb 7, 2025
0x4E,
0x44,
0xAE,
0x89, 0x50, 0x4E, 0x47, 0x0D, 0x0A, 0x1A, 0x0A, //
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@matanlurey I see you here making little things better. 👍 🙏

mdebbar reacted with thumbs up emoji
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kevmookevmookevmoo left review comments

@bkonyibkonyibkonyi approved these changes

@srujzssrujzsAwaiting requested review from srujzs

Assignees

No one assigned

Labels

toolAffects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matanlurey@kevmoo@bkonyi

Comments

[8]ページ先頭
©2009-2026 Movatter.jp