Movatterモバイル変換

Skip to content

flutter/flutterPublic

NotificationsYou must be signed in to change notification settings
Fork30k
Star175k

chore(canvaskit): remove SurfaceFrame from Surface#162825

Merged

auto-submit[bot] merged 8 commits intoflutter:masterfrom

harryterkelsen:canvaskit-surface-remove-surfaceframe

Feb 7, 2025

Merged

chore(canvaskit): remove SurfaceFrame from Surface#162825
auto-submit[bot] merged 8 commits intoflutter:masterfrom
harryterkelsen:canvaskit-surface-remove-surfaceframe

Conversation

@harryterkelsen

Copy link

Contributor

harryterkelsen commentedFeb 6, 2025

SurfaceFrame is no longer used. This is a cleanup in preparation for a larger refactor ofSurface to improve performance.

Pre-launch Checklist

I read theContributor Guide and followed the process outlined there for submitting PRs.
I read theTree Hygiene wiki page, which explains my responsibilities.
I read and followed theFlutter Style Guide, includingFeatures we expect every widget to implement.
I signed theCLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with///).
I added new tests to check the change I am making, or this PR istest-exempt.
I followed thebreaking change policy and addedData Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel onDiscord.

harryterkelsen added6 commits

February 4, 2025 16:22

@harryterkelsen

Resize to exactly the requested dimensions

02c29cf

@harryterkelsen

Merge branch 'master' into canvaskit-resize-performance

b6d8eb7

@harryterkelsen

Merge branch 'master' into canvaskit-resize-performance

01260ee

@harryterkelsen

Always resize exactly

ee220e2

@harryterkelsen

Merge branch 'master' into canvaskit-resize-performance

278e243

@harryterkelsen

chore(canvaskit): remove SurfaceFrame from Surface

b255f08

SurfaceFrame is no longer used.

@github-actions

github-actionsbot added engine

flutter/engine related. See also e: labels.

platform-webWeb applications specifically labels

@harryterkelsen

harryterkelsen requested a review fromyjbanov

February 6, 2025 19:15

yjbanov

yjbanov approved these changes

View reviewed changes

Copy link

Contributor

yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

engine/src/flutter/lib/web_ui/lib/src/engine/canvaskit/surface.dart OutdatedShow resolvedHide resolved

harryterkelsen added2 commits

February 6, 2025 13:32

@harryterkelsen

Merge branch 'master' into canvaskit-surface-remove-surfaceframe

ef85939

@harryterkelsen

Improve docs

2c3dd49

@harryterkelsen

harryterkelsen added the autosubmitMerge PR when tree becomes green via auto submit App label

@auto-submit

auto-submitbot removed the autosubmitMerge PR when tree becomes green via auto submit App label

@auto-submit

Copy link

Contributor

auto-submitbot commentedFeb 6, 2025

autosubmit label was removed for flutter/flutter/162825, because - The status or check suiteMac_arm64 framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.

@harryterkelsen

harryterkelsen added the autosubmitMerge PR when tree becomes green via auto submit App label

@auto-submit

auto-submitbot added this pull request to themerge queue

Merged via the queue intoflutter:master with commitdb7e82b

176 checks passed

@flutter-dashboard

flutter-dashboardbot removed the autosubmitMerge PR when tree becomes green via auto submit App label

@engine-flutter-autoroll

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 8e2a6fc3fd2c to 44203b67f5fd (81 revisions)flutter/packages#8583

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

db7e82bchore(canvaskit): remove SurfaceFrame from Surface (flutter/f…

9f3808e

…lutter#162825)

@engine-flutter-autoroll

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 8e2a6fc3fd2c to 44203b67f5fd (81 revisions)flutter/packages#8584

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

db7e82bchore(canvaskit): remove SurfaceFrame from Surface (flutter/f…

b2ad953

…lutter#162825)

@engine-flutter-autoroll

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 8e2a6fc3fd2c to 892f9c13a2bb (84 revisions)flutter/packages#8585

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

db7e82bchore(canvaskit): remove SurfaceFrame from Surface (flutter/f…

00278a1

…lutter#162825)

@engine-flutter-autoroll

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 8e2a6fc3fd2c to 829fe68e9dff (100 revisions)flutter/packages#8589

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

db7e82bchore(canvaskit): remove SurfaceFrame from Surface (flutter/f…

226ff72

…lutter#162825)

@engine-flutter-autoroll

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 8e2a6fc3fd2c to 829fe68e9dff (100 revisions)flutter/packages#8591

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

db7e82bchore(canvaskit): remove SurfaceFrame from Surface (flutter/f…

06c119a

…lutter#162825)

@engine-flutter-autoroll

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 8e2a6fc3fd2c to 5156de731b45 (102 revisions)flutter/packages#8593

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

db7e82bchore(canvaskit): remove SurfaceFrame from Surface (flutter/f…

4a7a716

…lutter#162825)

@engine-flutter-autoroll

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 8e2a6fc3fd2c to 5156de731b45 (102 revisions)flutter/packages#8594

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

db7e82bchore(canvaskit): remove SurfaceFrame from Surface (flutter/f…

9d1e7aa

…lutter#162825)

@engine-flutter-autoroll

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 8e2a6fc3fd2c to e7cb7a30bb1c (104 revisions)flutter/packages#8597

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

db7e82bchore(canvaskit): remove SurfaceFrame from Surface (flutter/f…

832b927

…lutter#162825)

@engine-flutter-autoroll

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 8e2a6fc3fd2c to c89d563944e3 (105 revisions)flutter/packages#8599

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

db7e82bchore(canvaskit): remove SurfaceFrame from Surface (flutter/f…

691cb8e

…lutter#162825)

@engine-flutter-autoroll

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 8e2a6fc3fd2c to 33a4c95de079 (106 revisions)flutter/packages#8600

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

db7e82bchore(canvaskit): remove SurfaceFrame from Surface (flutter/f…

7fc0b30

…lutter#162825)

@engine-flutter-autoroll

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 8e2a6fc3fd2c to 1d766ed8d93e (107 revisions)flutter/packages#8601

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

db7e82bchore(canvaskit): remove SurfaceFrame from Surface (flutter/f…

56d96f6

…lutter#162825)

@engine-flutter-autoroll

engine-flutter-autoroll mentioned this pull request

Roll Flutter from 8e2a6fc3fd2c to 78e5d7995cdb (108 revisions)flutter/packages#8602

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

db7e82bchore(canvaskit): remove SurfaceFrame from Surface (flutter/f…

4014829

…lutter#162825)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

db7e82bchore(canvaskit): remove SurfaceFrame from Surface (flutter/f…

9818b8a

…lutter#162825)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

db7e82bchore(canvaskit): remove SurfaceFrame from Surface (flutter/f…

e75358d

…lutter#162825)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

db7e82bchore(canvaskit): remove SurfaceFrame from Surface (flutter/f…

e784031

…lutter#162825)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

db7e82bchore(canvaskit): remove SurfaceFrame from Surface (flutter/f…

6b800e6

…lutter#162825)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

db7e82bchore(canvaskit): remove SurfaceFrame from Surface (flutter/f…

9f71ea4

…lutter#162825)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

db7e82bchore(canvaskit): remove SurfaceFrame from Surface (flutter/f…

ea33fc3

…lutter#162825)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

db7e82bchore(canvaskit): remove SurfaceFrame from Surface (flutter/f…

dbf7ab3

…lutter#162825)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

db7e82bchore(canvaskit): remove SurfaceFrame from Surface (flutter/f…

5885b1e

…lutter#162825)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

flutter/engine related. See also e: labels.

Web applications specifically

2 participants

@harryterkelsen

@yjbanov

Comments

[8]ページ先頭

©2009-2026 Movatter.jp