- Notifications
You must be signed in to change notification settings - Fork30k
[Android] wire up Java Transaction to AHB swapchain.#162750
[Android] wire up Java Transaction to AHB swapchain.#162750auto-submit[bot] merged 1 commit intoflutter:masterfrom
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel inDiscord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself,is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read theTree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, soall reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
jonahwilliams commentedFeb 5, 2025
Integration test will be here:#162751 |
| namespace impeller { | ||
| #if FML_OS_ANDROID | ||
| using CreateTransactionCB = std::function<android::SurfaceTransaction()>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I hate that this uses a callback but I had a bad time looking for some common place to put an interface to be shared between the platform and impeller code anywhere.
ideally we'd have something fairly simple like:
class TransactionFactory { android::SurfaceTransaction CreateTransaction(); enum TransactionMode { kNative, kJava, } void SetTransactionMode(/* java or native*/ mode)}But I plan to fix this in a follow up.
17cb12dUh oh!
There was an error while loading.Please reload this page.
One more PR to go to wire up the new message channels and add the integration_test.