- Notifications
You must be signed in to change notification settings - Fork30k
Updategenerate_gradle_lockfiles.dart to handle batch updating kotlin Gradle files#162628
Updategenerate_gradle_lockfiles.dart to handle batch updating kotlin Gradle files#162628auto-submit[bot] merged 13 commits intoflutter:masterfrom
generate_gradle_lockfiles.dart to handle batch updating kotlin Gradle files#162628Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel inDiscord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself,is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read theTree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, soall reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
1 similar comment
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel inDiscord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself,is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read theTree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, soall reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
reidbaker commentedFeb 4, 2025
| include ":app" | ||
| '''; | ||
| const String rootGradleKtsFileContent = r''' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please add a dart doc describing how/when to update this string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I gave some sort of instructions. These files are not exactly copy and paste versions of the templates, but are close. So I put a comment saying to consider updating them to reflect changes to the templates.
| } | ||
| '''; | ||
| const String settingsGradleKtsFileContent = r''' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
same here
| } | ||
| plugins { | ||
| id("dev.flutter.flutter-plugin-loader") version "1.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Non blocking: Should we share versions in these strings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We could, yeah. We should really move all the examples to kotlin, though. I don't think you can even make the templates output a groovy version anymore? Or if you can I don't know how? I only see.kts files here in the app tmpls:
https://github.com/flutter/flutter/tree/master/packages/flutter_tools/templates/app/android-kotlin.tmpl
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
…ing kotlin Gradle files (flutter/flutter#162628)
Uh oh!
There was an error while loading.Please reload this page.
Also removes the only entry from the exclusion script, as this fixes the reason for its exclusion.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel onDiscord.