Movatterモバイル変換

Skip to content

flutter/flutterPublic

NotificationsYou must be signed in to change notification settings
Fork30k
Star175k

[web] Correctly read the repetitionCount for images#162414

Merged

auto-submit[bot] merged 1 commit intoflutter:masterfrom

harryterkelsen:canvaskit-gifs-stop-animating

Jan 30, 2025

Merged

[web] Correctly read the repetitionCount for images#162414
auto-submit[bot] merged 1 commit intoflutter:masterfrom
harryterkelsen:canvaskit-gifs-stop-animating

Conversation

@harryterkelsen

Copy link

Contributor

harryterkelsen commentedJan 29, 2025

There was a bug inResizingCodec where it returnedframeCount instead ofrepetitionCount in therepetitionCount getter, causing animated images to stop animating even if they were set to loop infinitely.

Pre-launch Checklist

I read theContributor Guide and followed the process outlined there for submitting PRs.
I read theTree Hygiene wiki page, which explains my responsibilities.
I read and followed theFlutter Style Guide, includingFeatures we expect every widget to implement.
I signed theCLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with///).
I added new tests to check the change I am making, or this PR istest-exempt.
I followed thebreaking change policy and addedData Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel onDiscord.

@harryterkelsen

[web] Correctly read the repetitionCount for images

7c6c0af

@harryterkelsen

harryterkelsen requested a review fromyjbanov

January 29, 2025 22:21

@github-actions

github-actionsbot added engine

flutter/engine related. See also e: labels.

platform-webWeb applications specifically labels

yjbanov

yjbanov approved these changes

View reviewed changes

Copy link

Contributor

yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@harryterkelsen

harryterkelsen added the autosubmitMerge PR when tree becomes green via auto submit App label

@flutter-dashboard

Copy link

flutter-dashboardbot commentedJan 29, 2025

Golden file changes have been found for this pull request. Clickhere to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visitWriting a golden file test forpackage:flutter.

Reviewers: Read theTree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request#162414 at sha7c6c0af

@flutter-dashboard

flutter-dashboardbot added the will affect goldensChanges to golden files label

@auto-submit

auto-submitbot added this pull request to themerge queue

Merged via the queue intoflutter:master with commit4526f65

176 checks passed

@flutter-dashboard

flutter-dashboardbot removed the autosubmitMerge PR when tree becomes green via auto submit App label

@engine-flutter-autoroll

engine-flutter-autoroll mentioned this pull request

Roll Flutter from b007899d3a7a to 3e3bb9fdd586 (17 revisions)flutter/packages#8535

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

4526f65[web] Correctly read the repetitionCount for images (flutter/…

955f7de

…flutter#162414)

@engine-flutter-autoroll

engine-flutter-autoroll mentioned this pull request

Roll Flutter from b007899d3a7a to 1dd3f5d45bff (18 revisions)flutter/packages#8536

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

4526f65[web] Correctly read the repetitionCount for images (flutter/…

9f6cdfc

…flutter#162414)

@engine-flutter-autoroll

engine-flutter-autoroll mentioned this pull request

Roll Flutter from b007899d3a7a to fffbf663ff34 (19 revisions)flutter/packages#8537

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

4526f65[web] Correctly read the repetitionCount for images (flutter/…

1214d67

…flutter#162414)

@engine-flutter-autoroll

engine-flutter-autoroll mentioned this pull request

Roll Flutter from b007899d3a7a to 1eecbf12568d (20 revisions)flutter/packages#8538

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

4526f65[web] Correctly read the repetitionCount for images (flutter/…

d7d920d

…flutter#162414)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

4526f65[web] Correctly read the repetitionCount for images (flutter/…

bdd0df7

…flutter#162414)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

4526f65[web] Correctly read the repetitionCount for images (flutter/…

89cc52e

…flutter#162414)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

4526f65[web] Correctly read the repetitionCount for images (flutter/…

13aac90

…flutter#162414)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

4526f65[web] Correctly read the repetitionCount for images (flutter/…

8d471a8

…flutter#162414)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

4526f65[web] Correctly read the repetitionCount for images (flutter/…

4f43491

…flutter#162414)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

4526f65[web] Correctly read the repetitionCount for images (flutter/…

4d22f3a

…flutter#162414)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

4526f65[web] Correctly read the repetitionCount for images (flutter/…

50a6339

…flutter#162414)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

4526f65[web] Correctly read the repetitionCount for images (flutter/…

9a94f1f

…flutter#162414)

@Clap2rap

Clap2rap mentioned this pull request

[BUG][Web][Flutter engine] GIFs stop issue still exists (3.29.0)#163710

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

4526f65[web] Correctly read the repetitionCount for images (flutter/…

8db9a60

…flutter#162414)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

4526f65[web] Correctly read the repetitionCount for images (flutter/…

fc5bc58

…flutter#162414)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request

@engine-flutter-autoroll

4526f65[web] Correctly read the repetitionCount for images (flutter/…

ff88dc0

…flutter#162414)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

flutter/engine related. See also e: labels.

Web applications specifically

will affect goldens

Changes to golden files

2 participants

@harryterkelsen

@yjbanov

Comments

[8]ページ先頭

©2009-2026 Movatter.jp