Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add 2 retries for hybrid composition platform views.#162400

Merged
auto-submit[bot] merged 3 commits intoflutter:masterfrom
matanlurey:retry-android-hc-pv
Jan 29, 2025
Merged

Add 2 retries for hybrid composition platform views.#162400
auto-submit[bot] merged 3 commits intoflutter:masterfrom
matanlurey:retry-android-hc-pv

Conversation

@matanlurey
Copy link
Contributor

Trying to figure out if flake reports#162362 and#162363 are related to#162310.

I was unable to reproduce locally:

dart tool/deflake.dart lib/platform_view/hybrid_composition_platform_view_main.dart

... so either the Mac Android emulators don't show this behavior, or perhaps its just the slowness of CI VMs.

Either way, this should try taking a screenshot 2 more times (which has built-in waits/sleeps), so if the problem persists that means there is a more critical HC problem (the screen isalways drawn black sometimes) versus a more transient problem (it "takes longer").

Copy link
Contributor

@jonahwilliamsjonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Clickhere to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visitWriting a golden file test forpackage:flutter.

Reviewers: Read theTree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request#162400 at shac700474

@flutter-dashboardflutter-dashboardbot added the will affect goldensChanges to golden files labelJan 29, 2025
@matanlureymatanlurey added the autosubmitMerge PR when tree becomes green via auto submit App labelJan 29, 2025
@auto-submit
Copy link
Contributor

autosubmit label was removed for flutter/flutter/162400, because - The status or check suiteMac channels_integration_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submitauto-submitbot removed the autosubmitMerge PR when tree becomes green via auto submit App labelJan 29, 2025
@matanlureymatanlurey added the autosubmitMerge PR when tree becomes green via auto submit App labelJan 29, 2025
@auto-submitauto-submitbot added this pull request to themerge queueJan 29, 2025
Merged via the queue intoflutter:master with commit536408fJan 29, 2025
149 checks passed
@flutter-dashboardflutter-dashboardbot removed the autosubmitMerge PR when tree becomes green via auto submit App labelJan 29, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestJan 30, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestJan 30, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestJan 30, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestJan 30, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestJan 31, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestJan 31, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 2, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 2, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestFeb 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@jonahwilliamsjonahwilliamsjonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

will affect goldensChanges to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matanlurey@jonahwilliams

Comments


[8]ページ先頭

©2009-2026 Movatter.jp