Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

FixTab linear and elastic animation blink#162315

Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom
TahaTesser:fix_tab_linear_elastic_animation_blink
Jan 29, 2025
Merged

FixTab linear and elastic animation blink#162315
auto-submit[bot] merged 2 commits intoflutter:masterfrom
TahaTesser:fix_tab_linear_elastic_animation_blink

Conversation

@TahaTesser
Copy link
Contributor

@TahaTesserTahaTesser commentedJan 28, 2025
edited
Loading

Fixes#162098

Description

This PR fixesTab linear and elastic animation blinks/flickers when skipping multiple tabs. Previous attempt to fix elastic animation didn't cover linear animation tests and didn't have enough number of tab items which this PR fixes.

  • Fixed Linear and elastic animation blink issue.
  • Added tests for linear and elastic animation with various tab sizes (LTR and RTL)
  • Added tests for linear and elastic animation when skipping tabs (LTR and RTL)

Code Sample

expand to view the code sample
import'package:flutter/material.dart';// import 'package:flutter/scheduler.dart';voidmain() {// timeDilation = 10;runApp(constTabBarDemo());}classTabBarDemoextendsStatelessWidget {constTabBarDemo({super.key});@overrideWidgetbuild(BuildContext context) {finalList<Widget> tabs=<Widget>[constTab(text:'Short'),constTab(text:'A Bit Longer Text'),constTab(text:'An Extremely Long Tab Label That Overflows'),constTab(text:'Tiny'),constTab(text:'Moderate Length'),constTab(text:'Just Right'),constTab(text:'Supercalifragilisticexpialidocious'),constTab(text:'Longer Than Usual'),    ];returnMaterialApp(      home:DefaultTabController(        length: tabs.length,        child:Scaffold(          appBar:AppBar(            bottom:TabBar(              tabAlignment:TabAlignment.start,              isScrollable:true,              indicatorAnimation:TabIndicatorAnimation.elastic,              tabs: tabs,            ),            title:constText('Tabs Demo'),          ),          body:TabBarView(            children:<Widget>[for (int i=0; i< tabs.length; i++)constIcon(Icons.directions_car),            ],          ),        ),      ),    );  }}

Before

before.mov

After

after.mov

Linear animation before (left) and After (right) comparison.

Screenshot 2025-01-28 at 17 27 50

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel onDiscord.

techouse, bernaferrari, rafayali, jlzhjp, and AhmedLSayed9 reacted with thumbs up emoji
@github-actionsgithub-actionsbot added frameworkflutter/packages/flutter repository. See also f: labels. f: material designflutter/packages/flutter/material repository. labelsJan 28, 2025
@TahaTesserTahaTesser marked this pull request as ready for reviewJanuary 28, 2025 21:05
Copy link
Contributor

@justinmcjustinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 👍. Looks solid to me in the video.

const Tab(text: 'Tiny'),
const Tab(text: 'Moderate Length'),
const Tab(text: 'Just Right'),
const Tab(text: 'Supercalifragilisticexpialidocious'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

☂️

matchesGoldenFile('tab_indicator.elastic_animation.various_size_tabs.ltr.png'),
);
}, skip: isBrowser); // https://github.com/flutter/flutter/issues/56001
testWidgets('Elastic Tab animation with various size tabs - RTL', (WidgetTester tester) async {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nit: Empty line above this.

TahaTesser reacted with heart emoji
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Clickhere to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visitWriting a golden file test forpackage:flutter.

Reviewers: Read theTree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request#162315 at sha61bad33

@flutter-dashboardflutter-dashboardbot added the will affect goldensChanges to golden files labelJan 29, 2025
@TahaTesserTahaTesser added the autosubmitMerge PR when tree becomes green via auto submit App labelJan 29, 2025
@auto-submitauto-submitbot added this pull request to themerge queueJan 29, 2025
Merged via the queue intoflutter:master with commitb007899Jan 29, 2025
78 checks passed
@flutter-dashboardflutter-dashboardbot removed the autosubmitMerge PR when tree becomes green via auto submit App labelJan 29, 2025
@TahaTesserTahaTesser deleted the fix_tab_linear_elastic_animation_blink branchJanuary 29, 2025 13:42
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestJan 29, 2025
@TahaTesser
Copy link
ContributorAuthor

reason for revert: Red tree due to unapproved golden images.

@TahaTesserTahaTesser added the revertAutorevert PR (with "Reason for revert:" comment) labelJan 29, 2025
auto-submitbot pushed a commit that referenced this pull requestJan 29, 2025
@auto-submitauto-submitbot removed the revertAutorevert PR (with "Reason for revert:" comment) labelJan 29, 2025
@mdebbarmdebbar added the revertAutorevert PR (with "Reason for revert:" comment) labelJan 29, 2025
@auto-submit
Copy link
Contributor

Unable to create the revert pull request due to ProcessException: Standard error
Pushing tohttps://github.com/flutter/flutter.git
Tohttps://github.com/flutter/flutter.git
! [rejected] revert_b007899d3a7a072e880e3984856c777cc9c5082b -> revert_b007899d3a7a072e880e3984856c777cc9c5082b (non-fast-forward)
error: failed to push some refs to 'https://github.com/flutter/flutter.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
Command: git push --verbose origin revert_b007899d3a7a072e880e3984856c777cc9c5082b

@auto-submitauto-submitbot removed the revertAutorevert PR (with "Reason for revert:" comment) labelJan 29, 2025
@TahaTesser
Copy link
ContributorAuthor

The bot created the revert pull request#162387.

#162315 (comment) is unexpected.

mdebbar reacted with thumbs up emoji

github-merge-queuebot pushed a commit that referenced this pull requestJan 29, 2025
…2387)<!-- start_original_pr_link -->Reverts:#162315<!-- end_original_pr_link --><!-- start_initiating_author -->Initiated by: TahaTesser<!-- end_initiating_author --><!-- start_revert_reason -->Reason for reverting: Red tree due to unapproved golden images. <!-- end_revert_reason --><!-- start_original_pr_author -->Original PR Author: TahaTesser<!-- end_original_pr_author --><!-- start_reviewers -->Reviewed By: {justinmc}<!-- end_reviewers --><!-- start_revert_body -->This change reverts the following previous change:Fixes[https://github.com/flutter/flutter/issues/162098](https://github.com/flutter/flutter/issues/162098)### Description This PR fixes `Tab` linear and elastic animation blinks/flickers whenskipping multiple tabs. Previous attempt to fix elastic animation didn'tcover linear animation tests and didn't have enough number of tab itemswhich this PR fixes.- Fixed Linear and elastic animation blink issue.- Added tests for linear and elastic animation with various tab sizes(LTR and RTL)- Added tests for linear and elastic animation when skipping tabs (LTRand RTL)### Code Sample<details><summary>expand to view the code sample</summary> ```dartimport 'package:flutter/material.dart';// import 'package:flutter/scheduler.dart';void main() {  // timeDilation = 10;  runApp(const TabBarDemo());}class TabBarDemo extends StatelessWidget {  const TabBarDemo({super.key});@OverRide  Widget build(BuildContext context) {    final List<Widget> tabs = <Widget>[      const Tab(text: 'Short'),      const Tab(text: 'A Bit Longer Text'),      const Tab(text: 'An Extremely Long Tab Label That Overflows'),      const Tab(text: 'Tiny'),      const Tab(text: 'Moderate Length'),      const Tab(text: 'Just Right'),      const Tab(text: 'Supercalifragilisticexpialidocious'),      const Tab(text: 'Longer Than Usual'),    ];    return MaterialApp(      home: DefaultTabController(        length: tabs.length,        child: Scaffold(          appBar: AppBar(            bottom: TabBar(              tabAlignment: TabAlignment.start,              isScrollable: true,              indicatorAnimation: TabIndicatorAnimation.elastic,              tabs: tabs,            ),            title: const Text('Tabs Demo'),          ),          body: TabBarView(            children: <Widget>[              for (int i = 0; i < tabs.length; i++) const Icon(Icons.directions_car),            ],          ),        ),      ),    );  }}```</details>### Beforehttps://github.com/user-attachments/assets/5c271948-5a01-4520-90a3-921c20c79470### Afterhttps://github.com/user-attachments/assets/6af32d43-3588-488f-ba50-be59323ed692### Linear animation before (left) and After (right) comparison.<img width="1048" alt="Screenshot 2025-01-28 at 17 27 50"src="https://github.com/user-attachments/assets/4ba587a5-24d0-40ce-817c-366d004abc05"/>## Pre-launch Checklist- [x] I read the [Contributor Guide] and followed the process outlinedthere for submitting PRs.- [x] I read the [Tree Hygiene] wiki page, which explains myresponsibilities.- [x] I read and followed the [Flutter Style Guide], including [Featureswe expect every widget to implement].- [x] I signed the [CLA].- [x] I listed at least one issue that this PR fixes in the descriptionabove.- [x] I updated/added relevant documentation (doc comments with `///`).- [x] I added new tests to check the change I am making, or this PR is[test-exempt].- [ ] I followed the [breaking change policy] and added [Data DrivenFixes] where supported.- [x] All existing and new tests are passing.If you need help, consider asking for advice on the #hackers-new channelon [Discord].<!-- Links -->[Contributor Guide]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview[Tree Hygiene]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md[test-exempt]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests[Flutter Style Guide]:https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md[Features we expect every widget to implement]:https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement[CLA]:https://cla.developers.google.com/[flutter/tests]:https://github.com/flutter/tests[breaking change policy]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes[Discord]:https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md[Data Driven Fixes]:https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md<!-- end_revert_body -->Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
auto-submitbot pushed a commit to flutter/packages that referenced this pull requestJan 30, 2025
Roll Flutter fromc1ffaa9 tob007899 (43 revisions)flutter/flutter@c1ffaa9...b0078992025-01-29 tessertaha@gmail.com Fix `Tab` linear and elastic animation blink (flutter/flutter#162315)2025-01-29 pateltirth454@gmail.com Pass-through `textInputAction` in `DropdownMenu` (flutter/flutter#162309)2025-01-29 38378650+hgraceb@users.noreply.github.com Fix scrollUntilVisible in WidgetTester (flutter/flutter#159582)2025-01-29 pateltirth454@gmail.com Pass-through `maxLines` in `DropdownMenu` (flutter/flutter#161903)2025-01-29 gaganyadav80@gmail.com fix: appbar leading width is not square for custom toolbar height (flutter/flutter#161880)2025-01-29 chinmaygarde@google.com [DisplayList] Don't call Skia Ganesh methods when its not available. (flutter/flutter#162345)2025-01-29 reidbaker@google.com Update README.md to include googler post verification steps (flutter/flutter#162272)2025-01-29 kevmoo@users.noreply.github.com [engine, web] return switch expressions in many places (flutter/flutter#162336)2025-01-29 reidbaker@google.com Update README.md to not have engine link for android (flutter/flutter#162330)2025-01-29 bkonyi@google.com Reland "[ Widget Previews ] Add support for detecting previews and generating code (#161911)"" (flutter/flutter#162337)2025-01-29 34871572+gmackall@users.noreply.github.com Add instructions to download the Gradle wrapper to FGP readme, and add to gitignore (flutter/flutter#162332)2025-01-29 matanlurey@users.noreply.github.com Fix tests to prepare for `--explicit-package-dependencies` and a bug. (flutter/flutter#162289)2025-01-29 matanlurey@users.noreply.github.com Add a currently unused `runs_in_merge_queue` property to `Linux analyze`. (flutter/flutter#162335)2025-01-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ Widget Previews ] Add support for detecting previews and generating code (#161911)" (flutter/flutter#162327)2025-01-28 58529443+srujzs@users.noreply.github.com Support hot restart for DDC library bundle format (flutter/flutter#162123)2025-01-28 30870216+gaaclarke@users.noreply.github.com Started adjusting uvs to match pixel snapping. (flutter/flutter#162049)2025-01-28 mohellebiabdessalem@gmail.com Refactor code inside flutter.groovy  (flutter/flutter#160250)2025-01-28 47866232+chunhtai@users.noreply.github.com Table implements redepth (flutter/flutter#162282)2025-01-28 bkonyi@google.com [ Widget Previews ] Add support for detecting previews and generating code (flutter/flutter#161911)2025-01-28 andrewrkolos@gmail.com remove dependency on `Usage` from `Pub` class (flutter/flutter#162279)2025-01-28 engine-flutter-autoroll@skia.org Roll Packages from258f6dc to02c6fef (6 revisions) (flutter/flutter#162313)2025-01-28 matanlurey@users.noreply.github.com Remove `scenario_app/android` and rename to `ios_scenario_app`. (flutter/flutter#160992)2025-01-28 matanlurey@users.noreply.github.com Apparently it is illegal to use `stderr` in this project. (flutter/flutter#162294)2025-01-28 aam@google.com Fix update_engine_version_test in presence of FLUTTER_PREBUILT_ENGINE_VERSION env vars. (flutter/flutter#162270)2025-01-28 matanlurey@users.noreply.github.com Add missing `properties: ...` and move to presubmit. (flutter/flutter#162170)2025-01-27 jonahwilliams@google.com [Impeller] make swapchain related external fence/semaphore extensions optional. (flutter/flutter#162205)2025-01-27 49699333+dependabot[bot]@users.noreply.github.com Bump the all-github-actions group with 2 updates (flutter/flutter#162277)2025-01-27 chinmaygarde@google.com Don't depend on Dart from FML. (flutter/flutter#162271)2025-01-27 chinmaygarde@google.com [DisplayList] Move nested canvas enums into their own TU. (flutter/flutter#162037)2025-01-27 importRyan@gmail.com Avoid iOS text selection crash by returning nil range (flutter/flutter#161996)2025-01-27 mohellebiabdessalem@gmail.com fix `felt` link to point to flutter repo instead of the engine repo (flutter/flutter#161423)2025-01-27 matanlurey@users.noreply.github.com Enable the Android Engine OpenGLES/Vulkan suites. (flutter/flutter#162258)2025-01-27 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Fix debug build for CanvasKit (flutter/flutter#162198)2025-01-27 engine-flutter-autoroll@skia.org Roll Packages from3d3ab7b to258f6dc (19 revisions) (flutter/flutter#162254)2025-01-25 matanlurey@users.noreply.github.com Pin `customer_testing` to the SHA specified in `tests.version` (flutter/flutter#162048)2025-01-25 matanlurey@users.noreply.github.com Formalize `update_engine_version.{sh|ps1}`. (flutter/flutter#162118)2025-01-25 pateltirth454@gmail.com Rename 'SelectionChangedCause.scribble' to 'SelectionChangedCause.stylusHandwriting' (flutter/flutter#161518)2025-01-25 jacksongardner@google.com Don't install xcode when doing `local_engine` web builds on mac. (flutter/flutter#162164)2025-01-25 matanlurey@users.noreply.github.com Force Impeller backend for `android_engine_test`, and test both OpenGLES and Vulkan (flutter/flutter#162089)2025-01-24 jonahwilliams@google.com [Impeller] when a command pool has many unused buffers, reset with release resources flag. (flutter/flutter#162171)2025-01-24 mdebbar@google.com [web] Remove HTML renderer from framework tests (flutter/flutter#162038)2025-01-24 jonahwilliams@google.com [Impeller] Skip clip entity replay that cannot impact current clip. (flutter/flutter#162113)2025-01-24 de.frankenapps@gmail.com Update Android integration test package for newer AGP (flutter/flutter#161856)If this roll has caused a breakage, revert this CL and stop the rollerusing the controls here:...
github-merge-queuebot pushed a commit that referenced this pull requestJan 31, 2025
)Relands#162315Removed animated sheet golden tests as they're not consistent for longanimation tests. Rewritten the tests to be more precise using mockcanvas checks.--- Fixes[https://github.com/flutter/flutter/issues/162098](https://github.com/flutter/flutter/issues/162098)### Description This PR fixes `Tab` linear and elastic animation blinks/flickers whenskipping multiple tabs. Previous attempt to fix elastic animation didn'tcover linear animation tests and didn't have enough number of tab itemswhich this PR fixes.- Fixed Linear and elastic animation blink issue.- Added tests for linear and elastic animation with various tab sizes(LTR and RTL)- Added tests for linear and elastic animation when skipping tabs (LTRand RTL)### Code Sample<details><summary>expand to view the code sample</summary> ```dartimport 'package:flutter/material.dart';// import 'package:flutter/scheduler.dart';void main() {  // timeDilation = 10;  runApp(const TabBarDemo());}class TabBarDemo extends StatelessWidget {  const TabBarDemo({super.key});@OverRide  Widget build(BuildContext context) {    final List<Widget> tabs = <Widget>[      const Tab(text: 'Short'),      const Tab(text: 'A Bit Longer Text'),      const Tab(text: 'An Extremely Long Tab Label That Overflows'),      const Tab(text: 'Tiny'),      const Tab(text: 'Moderate Length'),      const Tab(text: 'Just Right'),      const Tab(text: 'Supercalifragilisticexpialidocious'),      const Tab(text: 'Longer Than Usual'),    ];    return MaterialApp(      home: DefaultTabController(        length: tabs.length,        child: Scaffold(          appBar: AppBar(            bottom: TabBar(              tabAlignment: TabAlignment.start,              isScrollable: true,              indicatorAnimation: TabIndicatorAnimation.elastic,              tabs: tabs,            ),            title: const Text('Tabs Demo'),          ),          body: TabBarView(            children: <Widget>[              for (int i = 0; i < tabs.length; i++) const Icon(Icons.directions_car),            ],          ),        ),      ),    );  }}```</details>### Beforehttps://github.com/user-attachments/assets/5c271948-5a01-4520-90a3-921c20c79470### Afterhttps://github.com/user-attachments/assets/6af32d43-3588-488f-ba50-be59323ed692### Linear animation before (left) and After (right) comparison.<img width="1048" alt="Screenshot 2025-01-28 at 17 27 50"src="https://github.com/user-attachments/assets/4ba587a5-24d0-40ce-817c-366d004abc05"/>## Pre-launch Checklist- [x] I read the [Contributor Guide] and followed the process outlinedthere for submitting PRs.- [x] I read the [Tree Hygiene] wiki page, which explains myresponsibilities.- [x] I read and followed the [Flutter Style Guide], including [Featureswe expect every widget to implement].- [x] I signed the [CLA].- [x] I listed at least one issue that this PR fixes in the descriptionabove.- [x] I updated/added relevant documentation (doc comments with `///`).- [x] I added new tests to check the change I am making, or this PR is[test-exempt].- [ ] I followed the [breaking change policy] and added [Data DrivenFixes] where supported.- [x] All existing and new tests are passing.If you need help, consider asking for advice on the #hackers-new channelon [Discord].<!-- Links -->[Contributor Guide]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview[Tree Hygiene]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md[test-exempt]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests[Flutter Style Guide]:https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md[Features we expect every widget to implement]:https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement[CLA]:https://cla.developers.google.com/[flutter/tests]:https://github.com/flutter/tests[breaking change policy]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes[Discord]:https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md[Data Driven Fixes]:https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
flutteractionsbot pushed a commit to flutteractionsbot/flutter that referenced this pull requestFeb 21, 2025
flutter#162450)Relandsflutter#162315Removed animated sheet golden tests as they're not consistent for longanimation tests. Rewritten the tests to be more precise using mockcanvas checks.--- Fixes[https://github.com/flutter/flutter/issues/162098](https://github.com/flutter/flutter/issues/162098)### Description This PR fixes `Tab` linear and elastic animation blinks/flickers whenskipping multiple tabs. Previous attempt to fix elastic animation didn'tcover linear animation tests and didn't have enough number of tab itemswhich this PR fixes.- Fixed Linear and elastic animation blink issue.- Added tests for linear and elastic animation with various tab sizes(LTR and RTL)- Added tests for linear and elastic animation when skipping tabs (LTRand RTL)### Code Sample<details><summary>expand to view the code sample</summary> ```dartimport 'package:flutter/material.dart';// import 'package:flutter/scheduler.dart';void main() {  // timeDilation = 10;  runApp(const TabBarDemo());}class TabBarDemo extends StatelessWidget {  const TabBarDemo({super.key});@OverRide  Widget build(BuildContext context) {    final List<Widget> tabs = <Widget>[      const Tab(text: 'Short'),      const Tab(text: 'A Bit Longer Text'),      const Tab(text: 'An Extremely Long Tab Label That Overflows'),      const Tab(text: 'Tiny'),      const Tab(text: 'Moderate Length'),      const Tab(text: 'Just Right'),      const Tab(text: 'Supercalifragilisticexpialidocious'),      const Tab(text: 'Longer Than Usual'),    ];    return MaterialApp(      home: DefaultTabController(        length: tabs.length,        child: Scaffold(          appBar: AppBar(            bottom: TabBar(              tabAlignment: TabAlignment.start,              isScrollable: true,              indicatorAnimation: TabIndicatorAnimation.elastic,              tabs: tabs,            ),            title: const Text('Tabs Demo'),          ),          body: TabBarView(            children: <Widget>[              for (int i = 0; i < tabs.length; i++) const Icon(Icons.directions_car),            ],          ),        ),      ),    );  }}```</details>### Beforehttps://github.com/user-attachments/assets/5c271948-5a01-4520-90a3-921c20c79470### Afterhttps://github.com/user-attachments/assets/6af32d43-3588-488f-ba50-be59323ed692### Linear animation before (left) and After (right) comparison.<img width="1048" alt="Screenshot 2025-01-28 at 17 27 50"src="https://github.com/user-attachments/assets/4ba587a5-24d0-40ce-817c-366d004abc05"/>## Pre-launch Checklist- [x] I read the [Contributor Guide] and followed the process outlinedthere for submitting PRs.- [x] I read the [Tree Hygiene] wiki page, which explains myresponsibilities.- [x] I read and followed the [Flutter Style Guide], including [Featureswe expect every widget to implement].- [x] I signed the [CLA].- [x] I listed at least one issue that this PR fixes in the descriptionabove.- [x] I updated/added relevant documentation (doc comments with `///`).- [x] I added new tests to check the change I am making, or this PR is[test-exempt].- [ ] I followed the [breaking change policy] and added [Data DrivenFixes] where supported.- [x] All existing and new tests are passing.If you need help, consider asking for advice on the #hackers-new channelon [Discord].<!-- Links -->[Contributor Guide]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview[Tree Hygiene]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md[test-exempt]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests[Flutter Style Guide]:https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md[Features we expect every widget to implement]:https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement[CLA]:https://cla.developers.google.com/[flutter/tests]:https://github.com/flutter/tests[breaking change policy]:https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes[Discord]:https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md[Data Driven Fixes]:https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
auto-submitbot pushed a commit that referenced this pull requestFeb 26, 2025
…2315) (#163830)This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.### Issue Link:Cherry picked PR:#162450Issue:#162098< Replace with issue link here >### Changelog Description:Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples< Replace with changelog description here >### Impact Description:What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) Anyone using the `TabBar` widget. High impact.### Workaround:Is there a workaround for this issue?None.### Risk:What is the risk level of this cherry-pick?### Test Coverage:Are you confident that your fix is well-tested by automated tests?### Validation Steps:What are the steps to validate that this fix works? Run a `TabBar` with linear tab animation and tap third or fourth or use elastic animation observe tab indictor highlight.
@reidbakerreidbaker mentioned this pull requestApr 4, 2025
9 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 21, 2025
androidseb pushed a commit to androidseb/packages that referenced this pull requestJun 8, 2025
Roll Flutter fromc1ffaa9 tob007899 (43 revisions)flutter/flutter@c1ffaa9...b0078992025-01-29 tessertaha@gmail.com Fix `Tab` linear and elastic animation blink (flutter/flutter#162315)2025-01-29 pateltirth454@gmail.com Pass-through `textInputAction` in `DropdownMenu` (flutter/flutter#162309)2025-01-29 38378650+hgraceb@users.noreply.github.com Fix scrollUntilVisible in WidgetTester (flutter/flutter#159582)2025-01-29 pateltirth454@gmail.com Pass-through `maxLines` in `DropdownMenu` (flutter/flutter#161903)2025-01-29 gaganyadav80@gmail.com fix: appbar leading width is not square for custom toolbar height (flutter/flutter#161880)2025-01-29 chinmaygarde@google.com [DisplayList] Don't call Skia Ganesh methods when its not available. (flutter/flutter#162345)2025-01-29 reidbaker@google.com Update README.md to include googler post verification steps (flutter/flutter#162272)2025-01-29 kevmoo@users.noreply.github.com [engine, web] return switch expressions in many places (flutter/flutter#162336)2025-01-29 reidbaker@google.com Update README.md to not have engine link for android (flutter/flutter#162330)2025-01-29 bkonyi@google.com Reland "[ Widget Previews ] Add support for detecting previews and generating code (#161911)"" (flutter/flutter#162337)2025-01-29 34871572+gmackall@users.noreply.github.com Add instructions to download the Gradle wrapper to FGP readme, and add to gitignore (flutter/flutter#162332)2025-01-29 matanlurey@users.noreply.github.com Fix tests to prepare for `--explicit-package-dependencies` and a bug. (flutter/flutter#162289)2025-01-29 matanlurey@users.noreply.github.com Add a currently unused `runs_in_merge_queue` property to `Linux analyze`. (flutter/flutter#162335)2025-01-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ Widget Previews ] Add support for detecting previews and generating code (#161911)" (flutter/flutter#162327)2025-01-28 58529443+srujzs@users.noreply.github.com Support hot restart for DDC library bundle format (flutter/flutter#162123)2025-01-28 30870216+gaaclarke@users.noreply.github.com Started adjusting uvs to match pixel snapping. (flutter/flutter#162049)2025-01-28 mohellebiabdessalem@gmail.com Refactor code inside flutter.groovy  (flutter/flutter#160250)2025-01-28 47866232+chunhtai@users.noreply.github.com Table implements redepth (flutter/flutter#162282)2025-01-28 bkonyi@google.com [ Widget Previews ] Add support for detecting previews and generating code (flutter/flutter#161911)2025-01-28 andrewrkolos@gmail.com remove dependency on `Usage` from `Pub` class (flutter/flutter#162279)2025-01-28 engine-flutter-autoroll@skia.org Roll Packages from258f6dc to02c6fef (6 revisions) (flutter/flutter#162313)2025-01-28 matanlurey@users.noreply.github.com Remove `scenario_app/android` and rename to `ios_scenario_app`. (flutter/flutter#160992)2025-01-28 matanlurey@users.noreply.github.com Apparently it is illegal to use `stderr` in this project. (flutter/flutter#162294)2025-01-28 aam@google.com Fix update_engine_version_test in presence of FLUTTER_PREBUILT_ENGINE_VERSION env vars. (flutter/flutter#162270)2025-01-28 matanlurey@users.noreply.github.com Add missing `properties: ...` and move to presubmit. (flutter/flutter#162170)2025-01-27 jonahwilliams@google.com [Impeller] make swapchain related external fence/semaphore extensions optional. (flutter/flutter#162205)2025-01-27 49699333+dependabot[bot]@users.noreply.github.com Bump the all-github-actions group with 2 updates (flutter/flutter#162277)2025-01-27 chinmaygarde@google.com Don't depend on Dart from FML. (flutter/flutter#162271)2025-01-27 chinmaygarde@google.com [DisplayList] Move nested canvas enums into their own TU. (flutter/flutter#162037)2025-01-27 importRyan@gmail.com Avoid iOS text selection crash by returning nil range (flutter/flutter#161996)2025-01-27 mohellebiabdessalem@gmail.com fix `felt` link to point to flutter repo instead of the engine repo (flutter/flutter#161423)2025-01-27 matanlurey@users.noreply.github.com Enable the Android Engine OpenGLES/Vulkan suites. (flutter/flutter#162258)2025-01-27 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Fix debug build for CanvasKit (flutter/flutter#162198)2025-01-27 engine-flutter-autoroll@skia.org Roll Packages from3d3ab7b to258f6dc (19 revisions) (flutter/flutter#162254)2025-01-25 matanlurey@users.noreply.github.com Pin `customer_testing` to the SHA specified in `tests.version` (flutter/flutter#162048)2025-01-25 matanlurey@users.noreply.github.com Formalize `update_engine_version.{sh|ps1}`. (flutter/flutter#162118)2025-01-25 pateltirth454@gmail.com Rename 'SelectionChangedCause.scribble' to 'SelectionChangedCause.stylusHandwriting' (flutter/flutter#161518)2025-01-25 jacksongardner@google.com Don't install xcode when doing `local_engine` web builds on mac. (flutter/flutter#162164)2025-01-25 matanlurey@users.noreply.github.com Force Impeller backend for `android_engine_test`, and test both OpenGLES and Vulkan (flutter/flutter#162089)2025-01-24 jonahwilliams@google.com [Impeller] when a command pool has many unused buffers, reset with release resources flag. (flutter/flutter#162171)2025-01-24 mdebbar@google.com [web] Remove HTML renderer from framework tests (flutter/flutter#162038)2025-01-24 jonahwilliams@google.com [Impeller] Skip clip entity replay that cannot impact current clip. (flutter/flutter#162113)2025-01-24 de.frankenapps@gmail.com Update Android integration test package for newer AGP (flutter/flutter#161856)If this roll has caused a breakage, revert this CL and stop the rollerusing the controls here:...
FMorschel pushed a commit to FMorschel/packages that referenced this pull requestJun 9, 2025
Roll Flutter fromc1ffaa9 tob007899 (43 revisions)flutter/flutter@c1ffaa9...b0078992025-01-29 tessertaha@gmail.com Fix `Tab` linear and elastic animation blink (flutter/flutter#162315)2025-01-29 pateltirth454@gmail.com Pass-through `textInputAction` in `DropdownMenu` (flutter/flutter#162309)2025-01-29 38378650+hgraceb@users.noreply.github.com Fix scrollUntilVisible in WidgetTester (flutter/flutter#159582)2025-01-29 pateltirth454@gmail.com Pass-through `maxLines` in `DropdownMenu` (flutter/flutter#161903)2025-01-29 gaganyadav80@gmail.com fix: appbar leading width is not square for custom toolbar height (flutter/flutter#161880)2025-01-29 chinmaygarde@google.com [DisplayList] Don't call Skia Ganesh methods when its not available. (flutter/flutter#162345)2025-01-29 reidbaker@google.com Update README.md to include googler post verification steps (flutter/flutter#162272)2025-01-29 kevmoo@users.noreply.github.com [engine, web] return switch expressions in many places (flutter/flutter#162336)2025-01-29 reidbaker@google.com Update README.md to not have engine link for android (flutter/flutter#162330)2025-01-29 bkonyi@google.com Reland "[ Widget Previews ] Add support for detecting previews and generating code (#161911)"" (flutter/flutter#162337)2025-01-29 34871572+gmackall@users.noreply.github.com Add instructions to download the Gradle wrapper to FGP readme, and add to gitignore (flutter/flutter#162332)2025-01-29 matanlurey@users.noreply.github.com Fix tests to prepare for `--explicit-package-dependencies` and a bug. (flutter/flutter#162289)2025-01-29 matanlurey@users.noreply.github.com Add a currently unused `runs_in_merge_queue` property to `Linux analyze`. (flutter/flutter#162335)2025-01-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ Widget Previews ] Add support for detecting previews and generating code (#161911)" (flutter/flutter#162327)2025-01-28 58529443+srujzs@users.noreply.github.com Support hot restart for DDC library bundle format (flutter/flutter#162123)2025-01-28 30870216+gaaclarke@users.noreply.github.com Started adjusting uvs to match pixel snapping. (flutter/flutter#162049)2025-01-28 mohellebiabdessalem@gmail.com Refactor code inside flutter.groovy  (flutter/flutter#160250)2025-01-28 47866232+chunhtai@users.noreply.github.com Table implements redepth (flutter/flutter#162282)2025-01-28 bkonyi@google.com [ Widget Previews ] Add support for detecting previews and generating code (flutter/flutter#161911)2025-01-28 andrewrkolos@gmail.com remove dependency on `Usage` from `Pub` class (flutter/flutter#162279)2025-01-28 engine-flutter-autoroll@skia.org Roll Packages from258f6dc to02c6fef (6 revisions) (flutter/flutter#162313)2025-01-28 matanlurey@users.noreply.github.com Remove `scenario_app/android` and rename to `ios_scenario_app`. (flutter/flutter#160992)2025-01-28 matanlurey@users.noreply.github.com Apparently it is illegal to use `stderr` in this project. (flutter/flutter#162294)2025-01-28 aam@google.com Fix update_engine_version_test in presence of FLUTTER_PREBUILT_ENGINE_VERSION env vars. (flutter/flutter#162270)2025-01-28 matanlurey@users.noreply.github.com Add missing `properties: ...` and move to presubmit. (flutter/flutter#162170)2025-01-27 jonahwilliams@google.com [Impeller] make swapchain related external fence/semaphore extensions optional. (flutter/flutter#162205)2025-01-27 49699333+dependabot[bot]@users.noreply.github.com Bump the all-github-actions group with 2 updates (flutter/flutter#162277)2025-01-27 chinmaygarde@google.com Don't depend on Dart from FML. (flutter/flutter#162271)2025-01-27 chinmaygarde@google.com [DisplayList] Move nested canvas enums into their own TU. (flutter/flutter#162037)2025-01-27 importRyan@gmail.com Avoid iOS text selection crash by returning nil range (flutter/flutter#161996)2025-01-27 mohellebiabdessalem@gmail.com fix `felt` link to point to flutter repo instead of the engine repo (flutter/flutter#161423)2025-01-27 matanlurey@users.noreply.github.com Enable the Android Engine OpenGLES/Vulkan suites. (flutter/flutter#162258)2025-01-27 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Fix debug build for CanvasKit (flutter/flutter#162198)2025-01-27 engine-flutter-autoroll@skia.org Roll Packages from3d3ab7b to258f6dc (19 revisions) (flutter/flutter#162254)2025-01-25 matanlurey@users.noreply.github.com Pin `customer_testing` to the SHA specified in `tests.version` (flutter/flutter#162048)2025-01-25 matanlurey@users.noreply.github.com Formalize `update_engine_version.{sh|ps1}`. (flutter/flutter#162118)2025-01-25 pateltirth454@gmail.com Rename 'SelectionChangedCause.scribble' to 'SelectionChangedCause.stylusHandwriting' (flutter/flutter#161518)2025-01-25 jacksongardner@google.com Don't install xcode when doing `local_engine` web builds on mac. (flutter/flutter#162164)2025-01-25 matanlurey@users.noreply.github.com Force Impeller backend for `android_engine_test`, and test both OpenGLES and Vulkan (flutter/flutter#162089)2025-01-24 jonahwilliams@google.com [Impeller] when a command pool has many unused buffers, reset with release resources flag. (flutter/flutter#162171)2025-01-24 mdebbar@google.com [web] Remove HTML renderer from framework tests (flutter/flutter#162038)2025-01-24 jonahwilliams@google.com [Impeller] Skip clip entity replay that cannot impact current clip. (flutter/flutter#162113)2025-01-24 de.frankenapps@gmail.com Update Android integration test package for newer AGP (flutter/flutter#161856)If this roll has caused a breakage, revert this CL and stop the rollerusing the controls here:...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@justinmcjustinmcjustinmc approved these changes

Assignees

No one assigned

Labels

f: material designflutter/packages/flutter/material repository.frameworkflutter/packages/flutter repository. See also f: labels.will affect goldensChanges to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TabBar broken animation

3 participants

@TahaTesser@justinmc@mdebbar

[8]ページ先頭

©2009-2026 Movatter.jp