Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Do not handle Dart isolate messages if the isolate is being shut down#161824

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
jason-simmons:bug_160003
Jan 21, 2025
Merged

Do not handle Dart isolate messages if the isolate is being shut down#161824
auto-submit[bot] merged 1 commit intoflutter:masterfrom
jason-simmons:bug_160003

Conversation

@jason-simmons
Copy link
Member

This fixes a race that can happen if Dart invokes an isolate's message handling callback during isolate shutdown. The callback installed by Tonic will invoke a dispatcher set by the engine's DartIsolate::SetMessageHandlingTaskRunner, which will queue a message handling task to the designated task runner.

If the queued task runs after DartIsolate::Shutdown has been called, then Tonic's DartMessageHandler::OnHandleMessage will fail when it tries to enter the isolate.

DartIsolate will set a shutdown flag on the DartState when Dart invokes the isolate's shutdown callback. Tonic can avoid this race by checking that flag before proceeding with message handling.

Fixes#160003

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel inDiscord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself,is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read theTree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, soall reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actionsgithub-actionsbot added the engineflutter/engine related. See also e: labels. labelJan 17, 2025
@jason-simmons
Copy link
MemberAuthor

This is a migration offlutter/engine#57081 to the monorepo.

Testing: this will be verified by monitoring runs of thelinux_benchmarks builder and checking that the flakes inui_benchmarks are no longer occurring (https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20linux_benchmarks)

@jonahwilliamsjonahwilliams self-requested a reviewJanuary 21, 2025 17:04
Copy link
Contributor

@jonahwilliamsjonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

change LGTM, test failures may need rebase?

This fixes a race that can happen if Dart invokes an isolate's message handling callback during isolate shutdown.  The callback installed by Tonic will invoke a dispatcher set by the engine's DartIsolate::SetMessageHandlingTaskRunner, which will queue a message handling task to the designated task runner.If the queued task runs after DartIsolate::Shutdown has been called, then Tonic's DartMessageHandler::OnHandleMessage will fail when it tries to enter the isolate.DartIsolate will set a shutdown flag on the DartState when Dart invokes the isolate's shutdown callback.  Tonic can avoid this race by checking that flag before proceeding with message handling.Fixesflutter#160003
@jason-simmonsjason-simmons added the autosubmitMerge PR when tree becomes green via auto submit App labelJan 21, 2025
@auto-submitauto-submitbot added this pull request to themerge queueJan 21, 2025
Merged via the queue intoflutter:master with commitbdecbaeJan 21, 2025
181 checks passed
@flutter-dashboardflutter-dashboardbot removed the autosubmitMerge PR when tree becomes green via auto submit App labelJan 21, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestJan 22, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestJan 22, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestJan 22, 2025
auto-submitbot pushed a commit to flutter/packages that referenced this pull requestJan 23, 2025
Manual roll Flutter fromb9e86a5 tob2f515f (42 revisions)Manual roll requested by tarrinneal@google.comflutter/flutter@b9e86a5...b2f515f2025-01-22 a-siva@users.noreply.github.com Roll Dart to Version 3.8.0-24.0.dev (flutter/flutter#162035)2025-01-22 nate.w5687@gmail.com `const AnimationStyle` (flutter/flutter#160564)2025-01-22 matanlurey@users.noreply.github.com Add piping and bringup nodes for `_vulkan` and `_opengles` suites. (flutter/flutter#162020)2025-01-22 flar@google.com [Impeller] Migrate unit tests off of Skia geometry classes (flutter/flutter#161855)2025-01-22 matanlurey@users.noreply.github.com Experiment with a `files-changed.json` per PR (flutter/flutter#161788)2025-01-22 robert.ancell@canonical.com Move FlKeyboardManager and FlKeyboardHandler from FlView to FlEngine. (flutter/flutter#161925)2025-01-22 engine-flutter-autoroll@skia.org Roll Packages frome8f1f63 to3d3ab7b (1 revision) (flutter/flutter#162019)2025-01-22 47866232+chunhtai@users.noreply.github.com Adds cupertino picker semantics test (flutter/flutter#161768)2025-01-22 mdebbar@google.com [web] Remove deprecated web-only APIs from dart:ui (flutter/flutter#161775)2025-01-22 34465683+rkishan516@users.noreply.github.com fix: Add enabled property for search anchor named constructor (flutter/flutter#161468)2025-01-22 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162015)2025-01-22 mdebbar@google.com [web] Remove spam from test output (flutter/flutter#161774)2025-01-22 43089218+chika3742@users.noreply.github.com Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (2) (flutter/flutter#161577)2025-01-22 matanlurey@users.noreply.github.com Make `font-subset` a standalone `run_tests.py` variant. (flutter/flutter#162016)2025-01-22 kczarnota7@gmail.com Enabled provisioning updates and device registration during building xcarchive. (flutter/flutter#159622)2025-01-22 mdebbar@google.com [web] Remove HTML from bots, test suites and e2e tests (flutter/flutter#161537)2025-01-22 matanlurey@users.noreply.github.com Expand the `.ci.yaml` and `builder.json` linter (flutter/flutter#161991)2025-01-22 37592940+sethmfuller@users.noreply.github.com Fix incorrect [enabled] documentation (flutter/flutter#161650)2025-01-22 matanlurey@users.noreply.github.com Add `windows_host_engine_test`. (flutter/flutter#161992)2025-01-22 a-siva@users.noreply.github.com Roll Dart to version Version 3.8.0-19.0.dev (flutter/flutter#161989)2025-01-22 tessertaha@gmail.com Deprecate `ThemeData.indicatorColor` in favor of `TabBarThemeData.indicatorColor` (flutter/flutter#160024)2025-01-22 jonahwilliams@google.com [Impeller] disable older xclipse gpu driver. (flutter/flutter#161981)2025-01-22 jacksongardner@google.com Merge changelog for 3.27.3 release (flutter/flutter#161977)2025-01-21 robert.ancell@canonical.com Remove FlKeyboardViewDelegate (flutter/flutter#161705)2025-01-21 mernen@users.noreply.github.com Fix documentation of Flow.clipBehavior (flutter/flutter#161863)2025-01-21 jonahwilliams@google.com [impeller] prevent PowerVR from using Vulkan backend. (flutter/flutter#161841)2025-01-21 30870216+gaaclarke@users.noreply.github.com [Impeller] backfilling TextContents unit tests (flutter/flutter#161625)2025-01-21 jason-simmons@users.noreply.github.com Do not handle Dart isolate messages if the isolate is being shut down (flutter/flutter#161824)2025-01-21 mohellebiabdessalem@gmail.com fix failing lint : findByPath requires a specific ordering of project evaluation in `aar_init_script.gradle` (flutter/flutter#159301)2025-01-21 jacksongardner@google.com Get `et` working for local web engine builds. (flutter/flutter#161825)2025-01-21 magder@google.com Mark Linux_pixel_7pro flavors_test unflaky (flutter/flutter#160994)2025-01-21 fluttergithubbot@gmail.com Marks Mac_mokey run_debug_test_android to be flaky (flutter/flutter#161656)2025-01-21 saltedpotatos@users.noreply.github.com Don't crash flutter tool if Chrome is not available (flutter/flutter#154941)2025-01-21 bruno.leroux@gmail.com Fix DropdownMenu icon and item icon misalignment (flutter/flutter#161717)2025-01-21 dacoharkes@google.com [native assets] Cleanup dead code 2 (flutter/flutter#161916)2025-01-21 tessertaha@gmail.com Update `ListTile` test to prevent log dump and test error message. (flutter/flutter#161811)2025-01-21 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161924)2025-01-21 31859944+LongCatIsLooong@users.noreply.github.com Make `PipelineOwner` a `base` class (flutter/flutter#161789)2025-01-20 dacoharkes@google.com [native assets] Cleanup dead code (flutter/flutter#161913)2025-01-20 engine-flutter-autoroll@skia.org Roll Packages fromf73cb00 toe8f1f63 (9 revisions) (flutter/flutter#161914)2025-01-20 bkonyi@google.com [ flutter_tool ] Fix flakiness in doctor_test.dart (flutter/flutter#161917)2025-01-19 robert.ancell@canonical.com Update documentation on what display information is provided. (flutter/flutter#161785)If this roll has caused a breakage, revert this CL and stop the roller...
Wasmund1 pushed a commit to Wasmund1/flutter that referenced this pull requestJan 24, 2025
…flutter#161824)This fixes a race that can happen if Dart invokes an isolate's messagehandling callback during isolate shutdown. The callback installed byTonic will invoke a dispatcher set by the engine'sDartIsolate::SetMessageHandlingTaskRunner, which will queue a messagehandling task to the designated task runner.If the queued task runs after DartIsolate::Shutdown has been called,then Tonic's DartMessageHandler::OnHandleMessage will fail when it triesto enter the isolate.DartIsolate will set a shutdown flag on the DartState when Dart invokesthe isolate's shutdown callback. Tonic can avoid this race by checkingthat flag before proceeding with message handling.Fixesflutter#160003
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 21, 2025
androidseb pushed a commit to androidseb/packages that referenced this pull requestJun 8, 2025
)Manual roll Flutter fromb9e86a5 tob2f515f (42 revisions)Manual roll requested by tarrinneal@google.comflutter/flutter@b9e86a5...b2f515f2025-01-22 a-siva@users.noreply.github.com Roll Dart to Version 3.8.0-24.0.dev (flutter/flutter#162035)2025-01-22 nate.w5687@gmail.com `const AnimationStyle` (flutter/flutter#160564)2025-01-22 matanlurey@users.noreply.github.com Add piping and bringup nodes for `_vulkan` and `_opengles` suites. (flutter/flutter#162020)2025-01-22 flar@google.com [Impeller] Migrate unit tests off of Skia geometry classes (flutter/flutter#161855)2025-01-22 matanlurey@users.noreply.github.com Experiment with a `files-changed.json` per PR (flutter/flutter#161788)2025-01-22 robert.ancell@canonical.com Move FlKeyboardManager and FlKeyboardHandler from FlView to FlEngine. (flutter/flutter#161925)2025-01-22 engine-flutter-autoroll@skia.org Roll Packages frome8f1f63 to3d3ab7b (1 revision) (flutter/flutter#162019)2025-01-22 47866232+chunhtai@users.noreply.github.com Adds cupertino picker semantics test (flutter/flutter#161768)2025-01-22 mdebbar@google.com [web] Remove deprecated web-only APIs from dart:ui (flutter/flutter#161775)2025-01-22 34465683+rkishan516@users.noreply.github.com fix: Add enabled property for search anchor named constructor (flutter/flutter#161468)2025-01-22 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162015)2025-01-22 mdebbar@google.com [web] Remove spam from test output (flutter/flutter#161774)2025-01-22 43089218+chika3742@users.noreply.github.com Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (2) (flutter/flutter#161577)2025-01-22 matanlurey@users.noreply.github.com Make `font-subset` a standalone `run_tests.py` variant. (flutter/flutter#162016)2025-01-22 kczarnota7@gmail.com Enabled provisioning updates and device registration during building xcarchive. (flutter/flutter#159622)2025-01-22 mdebbar@google.com [web] Remove HTML from bots, test suites and e2e tests (flutter/flutter#161537)2025-01-22 matanlurey@users.noreply.github.com Expand the `.ci.yaml` and `builder.json` linter (flutter/flutter#161991)2025-01-22 37592940+sethmfuller@users.noreply.github.com Fix incorrect [enabled] documentation (flutter/flutter#161650)2025-01-22 matanlurey@users.noreply.github.com Add `windows_host_engine_test`. (flutter/flutter#161992)2025-01-22 a-siva@users.noreply.github.com Roll Dart to version Version 3.8.0-19.0.dev (flutter/flutter#161989)2025-01-22 tessertaha@gmail.com Deprecate `ThemeData.indicatorColor` in favor of `TabBarThemeData.indicatorColor` (flutter/flutter#160024)2025-01-22 jonahwilliams@google.com [Impeller] disable older xclipse gpu driver. (flutter/flutter#161981)2025-01-22 jacksongardner@google.com Merge changelog for 3.27.3 release (flutter/flutter#161977)2025-01-21 robert.ancell@canonical.com Remove FlKeyboardViewDelegate (flutter/flutter#161705)2025-01-21 mernen@users.noreply.github.com Fix documentation of Flow.clipBehavior (flutter/flutter#161863)2025-01-21 jonahwilliams@google.com [impeller] prevent PowerVR from using Vulkan backend. (flutter/flutter#161841)2025-01-21 30870216+gaaclarke@users.noreply.github.com [Impeller] backfilling TextContents unit tests (flutter/flutter#161625)2025-01-21 jason-simmons@users.noreply.github.com Do not handle Dart isolate messages if the isolate is being shut down (flutter/flutter#161824)2025-01-21 mohellebiabdessalem@gmail.com fix failing lint : findByPath requires a specific ordering of project evaluation in `aar_init_script.gradle` (flutter/flutter#159301)2025-01-21 jacksongardner@google.com Get `et` working for local web engine builds. (flutter/flutter#161825)2025-01-21 magder@google.com Mark Linux_pixel_7pro flavors_test unflaky (flutter/flutter#160994)2025-01-21 fluttergithubbot@gmail.com Marks Mac_mokey run_debug_test_android to be flaky (flutter/flutter#161656)2025-01-21 saltedpotatos@users.noreply.github.com Don't crash flutter tool if Chrome is not available (flutter/flutter#154941)2025-01-21 bruno.leroux@gmail.com Fix DropdownMenu icon and item icon misalignment (flutter/flutter#161717)2025-01-21 dacoharkes@google.com [native assets] Cleanup dead code 2 (flutter/flutter#161916)2025-01-21 tessertaha@gmail.com Update `ListTile` test to prevent log dump and test error message. (flutter/flutter#161811)2025-01-21 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161924)2025-01-21 31859944+LongCatIsLooong@users.noreply.github.com Make `PipelineOwner` a `base` class (flutter/flutter#161789)2025-01-20 dacoharkes@google.com [native assets] Cleanup dead code (flutter/flutter#161913)2025-01-20 engine-flutter-autoroll@skia.org Roll Packages fromf73cb00 toe8f1f63 (9 revisions) (flutter/flutter#161914)2025-01-20 bkonyi@google.com [ flutter_tool ] Fix flakiness in doctor_test.dart (flutter/flutter#161917)2025-01-19 robert.ancell@canonical.com Update documentation on what display information is provided. (flutter/flutter#161785)If this roll has caused a breakage, revert this CL and stop the roller...
FMorschel pushed a commit to FMorschel/packages that referenced this pull requestJun 9, 2025
)Manual roll Flutter fromb9e86a5 tob2f515f (42 revisions)Manual roll requested by tarrinneal@google.comflutter/flutter@b9e86a5...b2f515f2025-01-22 a-siva@users.noreply.github.com Roll Dart to Version 3.8.0-24.0.dev (flutter/flutter#162035)2025-01-22 nate.w5687@gmail.com `const AnimationStyle` (flutter/flutter#160564)2025-01-22 matanlurey@users.noreply.github.com Add piping and bringup nodes for `_vulkan` and `_opengles` suites. (flutter/flutter#162020)2025-01-22 flar@google.com [Impeller] Migrate unit tests off of Skia geometry classes (flutter/flutter#161855)2025-01-22 matanlurey@users.noreply.github.com Experiment with a `files-changed.json` per PR (flutter/flutter#161788)2025-01-22 robert.ancell@canonical.com Move FlKeyboardManager and FlKeyboardHandler from FlView to FlEngine. (flutter/flutter#161925)2025-01-22 engine-flutter-autoroll@skia.org Roll Packages frome8f1f63 to3d3ab7b (1 revision) (flutter/flutter#162019)2025-01-22 47866232+chunhtai@users.noreply.github.com Adds cupertino picker semantics test (flutter/flutter#161768)2025-01-22 mdebbar@google.com [web] Remove deprecated web-only APIs from dart:ui (flutter/flutter#161775)2025-01-22 34465683+rkishan516@users.noreply.github.com fix: Add enabled property for search anchor named constructor (flutter/flutter#161468)2025-01-22 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162015)2025-01-22 mdebbar@google.com [web] Remove spam from test output (flutter/flutter#161774)2025-01-22 43089218+chika3742@users.noreply.github.com Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (2) (flutter/flutter#161577)2025-01-22 matanlurey@users.noreply.github.com Make `font-subset` a standalone `run_tests.py` variant. (flutter/flutter#162016)2025-01-22 kczarnota7@gmail.com Enabled provisioning updates and device registration during building xcarchive. (flutter/flutter#159622)2025-01-22 mdebbar@google.com [web] Remove HTML from bots, test suites and e2e tests (flutter/flutter#161537)2025-01-22 matanlurey@users.noreply.github.com Expand the `.ci.yaml` and `builder.json` linter (flutter/flutter#161991)2025-01-22 37592940+sethmfuller@users.noreply.github.com Fix incorrect [enabled] documentation (flutter/flutter#161650)2025-01-22 matanlurey@users.noreply.github.com Add `windows_host_engine_test`. (flutter/flutter#161992)2025-01-22 a-siva@users.noreply.github.com Roll Dart to version Version 3.8.0-19.0.dev (flutter/flutter#161989)2025-01-22 tessertaha@gmail.com Deprecate `ThemeData.indicatorColor` in favor of `TabBarThemeData.indicatorColor` (flutter/flutter#160024)2025-01-22 jonahwilliams@google.com [Impeller] disable older xclipse gpu driver. (flutter/flutter#161981)2025-01-22 jacksongardner@google.com Merge changelog for 3.27.3 release (flutter/flutter#161977)2025-01-21 robert.ancell@canonical.com Remove FlKeyboardViewDelegate (flutter/flutter#161705)2025-01-21 mernen@users.noreply.github.com Fix documentation of Flow.clipBehavior (flutter/flutter#161863)2025-01-21 jonahwilliams@google.com [impeller] prevent PowerVR from using Vulkan backend. (flutter/flutter#161841)2025-01-21 30870216+gaaclarke@users.noreply.github.com [Impeller] backfilling TextContents unit tests (flutter/flutter#161625)2025-01-21 jason-simmons@users.noreply.github.com Do not handle Dart isolate messages if the isolate is being shut down (flutter/flutter#161824)2025-01-21 mohellebiabdessalem@gmail.com fix failing lint : findByPath requires a specific ordering of project evaluation in `aar_init_script.gradle` (flutter/flutter#159301)2025-01-21 jacksongardner@google.com Get `et` working for local web engine builds. (flutter/flutter#161825)2025-01-21 magder@google.com Mark Linux_pixel_7pro flavors_test unflaky (flutter/flutter#160994)2025-01-21 fluttergithubbot@gmail.com Marks Mac_mokey run_debug_test_android to be flaky (flutter/flutter#161656)2025-01-21 saltedpotatos@users.noreply.github.com Don't crash flutter tool if Chrome is not available (flutter/flutter#154941)2025-01-21 bruno.leroux@gmail.com Fix DropdownMenu icon and item icon misalignment (flutter/flutter#161717)2025-01-21 dacoharkes@google.com [native assets] Cleanup dead code 2 (flutter/flutter#161916)2025-01-21 tessertaha@gmail.com Update `ListTile` test to prevent log dump and test error message. (flutter/flutter#161811)2025-01-21 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#161924)2025-01-21 31859944+LongCatIsLooong@users.noreply.github.com Make `PipelineOwner` a `base` class (flutter/flutter#161789)2025-01-20 dacoharkes@google.com [native assets] Cleanup dead code (flutter/flutter#161913)2025-01-20 engine-flutter-autoroll@skia.org Roll Packages fromf73cb00 toe8f1f63 (9 revisions) (flutter/flutter#161914)2025-01-20 bkonyi@google.com [ flutter_tool ] Fix flakiness in doctor_test.dart (flutter/flutter#161917)2025-01-19 robert.ancell@canonical.com Update documentation on what display information is provided. (flutter/flutter#161785)If this roll has caused a breakage, revert this CL and stop the roller...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chinmaygardechinmaygardeAwaiting requested review from chinmaygarde

1 more reviewer

@jonahwilliamsjonahwilliamsjonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

engineflutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ui_benchmarks sometimes is crashing

2 participants

@jason-simmons@jonahwilliams

Comments

[8]ページ先頭
©2009-2026 Movatter.jp