- Notifications
You must be signed in to change notification settings - Fork30k
Comments
Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12#160974
Merged
bartekpacia merged 2 commits intomasterfromJan 23, 2025
Conversation
bdddcc4 toef1c594CompareUh oh!
There was an error while loading.Please reload this page.
| const String templateAndroidGradlePluginVersion = '8.7.0'; | ||
| const String templateAndroidGradlePluginVersionForModule = '8.7.0'; | ||
| const String templateKotlinGradlePluginVersion = '1.8.22'; | ||
| const String templateKotlinGradlePluginVersion = '2.1.0'; |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I believe to do this we need to enforce that gradle is at least 8.3.
Also this is a new condition in our 4 (now 5 way) dependency graph.
https://kotlinlang.org/docs/whatsnew20.html#current-k2-compiler-limitations
The highest version I think you can use without running into gradle compatibility issues is kotlin1.9.25
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This template is technically ok since the AGP version is 8.7 but I think we need a new test in dev/devicelab/bin/tasks/android_java17_dependency_smoke_tests.dart
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I believe to do this we need to enforce that gradle is at least 8.3.
Yes, but don't we already do this since (as you said) in new Android project template we already have Gradle/AGP/Kotlin versions that are compatible with each other?
I think we need a new test in
dev/devicelab/bin/tasks android_java17_dependency_smoke_tests.dart
Done.
b30aec3 to3e68096CompareMemberAuthor
bartekpacia commentedJan 10, 2025
I decided that while I'm already at it, it probably won't hurt to also upgrade to latest stable Gradle 8.12. |
reidbaker approved these changesJan 10, 2025
Contributor
reidbaker left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
want a second review from@gmackall
I think this is ok to land but we probably need to update our compatibility logic to look at gradle and kotlin support now that we know that kotlin 2 requires AGP 8.3 or higher.
Contributor
reidbaker commentedJan 10, 2025
3e68096 to2e6b0f3CompareMemberAuthor
bartekpacia commentedJan 23, 2025
cc@gmackall second review will be appreciated |
gmackall approved these changesJan 23, 2025
Member
gmackall left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
Uh oh!
There was an error while loading.Please reload this page.
Merged via the queue intomaster with commitJan 23, 2025
558b21a 172 checks passed
Uh oh!
There was an error while loading.Please reload this page.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestJan 24, 2025
…, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestJan 24, 2025
…, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)
Wasmund1 pushed a commit to Wasmund1/flutter that referenced this pull requestJan 24, 2025
… default Gradle from 8.9 to 8.12 (flutter#160974)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestJan 24, 2025
…, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestJan 24, 2025
…, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestJan 24, 2025
…, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)
auto-submitbot pushed a commit to flutter/packages that referenced this pull requestJan 24, 2025
Manual roll requested by tarrinneal@google.comflutter/flutter@c1561a4...c1ffaa92025-01-24 737941+loic-sharma@users.noreply.github.com Fix link to hotfix documentation best practices (flutter/flutter#162116)2025-01-24 reidbaker@google.com Add integration test for cutout rotation evaluation (flutter/flutter#160354)2025-01-24 flar@google.com Reland "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162146)2025-01-24 bruno.leroux@gmail.com Fix TextField intrinsic width when hint is not visible (flutter/flutter#161235)2025-01-24 magder@google.com When parsing flavors, handle Xcode build configurations that are not lowercase (flutter/flutter#161455)2025-01-24 flar@google.com [Impeller] Fix source offset in PathBuilder::AddPath (flutter/flutter#162052)2025-01-24 jessiewong401@gmail.com Add to Setup Path Example to Engine README (flutter/flutter#162115)2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unskip test. (#162106)" (flutter/flutter#162122)2025-01-23 31410839+maheshj01@users.noreply.github.com feat: Add `hint` (Widget) property to InputDecoration (flutter/flutter#161424)2025-01-23 jacksongardner@google.com Fix skwasm target in wasm_debug_unopt build. (flutter/flutter#162100)2025-01-23 fluttergithubbot@gmail.com Marks Linux_android_emu android views to be unflaky (flutter/flutter#160493)2025-01-23 polinach@google.com Unskip test. (flutter/flutter#162106)2025-01-23 tessertaha@gmail.com Add ability to maintain bottom view padding in `NavigationBar` safe area (flutter/flutter#162076)2025-01-23 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162095)2025-01-23 matanlurey@users.noreply.github.com Delete an unused (manual) workflow, added missing copyright headers. (flutter/flutter#162050)2025-01-23 barpac02@gmail.com Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)2025-01-23 chris@bracken.jp flutter_tools: flutter_tester is a host artifact (flutter/flutter#162047)2025-01-23 jason-simmons@users.noreply.github.com [Impeller] Make glIsTexture mockable for use by the ReactorGLES.NameUntrackedHandle test (flutter/flutter#162082)2025-01-23 magder@google.com Remove "Mac Designed for iPad" as a discoverable `flutter run` device (flutter/flutter#161459)2025-01-23 737941+loic-sharma@users.noreply.github.com Show error on macOS if missing Local Network permissions (flutter/flutter#161846)2025-01-23 jmccandless@google.com Autocomplete keyboard navigation (flutter/flutter#159455)If this roll has caused a breakage, revert this CL and stop the rollerusing the controls here:https://autoroll.skia.org/r/flutter-packagesPlease CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a humanis aware of the problem.To file a bug in Packages:https://github.com/flutter/flutter/issues/new/chooseTo report a problem with the AutoRoller itself, please file a bug:https://issues.skia.org/issues/new?component=1389291&template=1850622Documentation for the AutoRoller is here:https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 20, 2025
…, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 20, 2025
…, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 21, 2025
…, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)
androidseb pushed a commit to androidseb/packages that referenced this pull requestJun 8, 2025
)Manual roll requested by tarrinneal@google.comflutter/flutter@c1561a4...c1ffaa92025-01-24 737941+loic-sharma@users.noreply.github.com Fix link to hotfix documentation best practices (flutter/flutter#162116)2025-01-24 reidbaker@google.com Add integration test for cutout rotation evaluation (flutter/flutter#160354)2025-01-24 flar@google.com Reland "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162146)2025-01-24 bruno.leroux@gmail.com Fix TextField intrinsic width when hint is not visible (flutter/flutter#161235)2025-01-24 magder@google.com When parsing flavors, handle Xcode build configurations that are not lowercase (flutter/flutter#161455)2025-01-24 flar@google.com [Impeller] Fix source offset in PathBuilder::AddPath (flutter/flutter#162052)2025-01-24 jessiewong401@gmail.com Add to Setup Path Example to Engine README (flutter/flutter#162115)2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unskip test. (#162106)" (flutter/flutter#162122)2025-01-23 31410839+maheshj01@users.noreply.github.com feat: Add `hint` (Widget) property to InputDecoration (flutter/flutter#161424)2025-01-23 jacksongardner@google.com Fix skwasm target in wasm_debug_unopt build. (flutter/flutter#162100)2025-01-23 fluttergithubbot@gmail.com Marks Linux_android_emu android views to be unflaky (flutter/flutter#160493)2025-01-23 polinach@google.com Unskip test. (flutter/flutter#162106)2025-01-23 tessertaha@gmail.com Add ability to maintain bottom view padding in `NavigationBar` safe area (flutter/flutter#162076)2025-01-23 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162095)2025-01-23 matanlurey@users.noreply.github.com Delete an unused (manual) workflow, added missing copyright headers. (flutter/flutter#162050)2025-01-23 barpac02@gmail.com Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)2025-01-23 chris@bracken.jp flutter_tools: flutter_tester is a host artifact (flutter/flutter#162047)2025-01-23 jason-simmons@users.noreply.github.com [Impeller] Make glIsTexture mockable for use by the ReactorGLES.NameUntrackedHandle test (flutter/flutter#162082)2025-01-23 magder@google.com Remove "Mac Designed for iPad" as a discoverable `flutter run` device (flutter/flutter#161459)2025-01-23 737941+loic-sharma@users.noreply.github.com Show error on macOS if missing Local Network permissions (flutter/flutter#161846)2025-01-23 jmccandless@google.com Autocomplete keyboard navigation (flutter/flutter#159455)If this roll has caused a breakage, revert this CL and stop the rollerusing the controls here:https://autoroll.skia.org/r/flutter-packagesPlease CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a humanis aware of the problem.To file a bug in Packages:https://github.com/flutter/flutter/issues/new/chooseTo report a problem with the AutoRoller itself, please file a bug:https://issues.skia.org/issues/new?component=1389291&template=1850622Documentation for the AutoRoller is here:https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull requestJun 9, 2025
)Manual roll requested by tarrinneal@google.comflutter/flutter@c1561a4...c1ffaa92025-01-24 737941+loic-sharma@users.noreply.github.com Fix link to hotfix documentation best practices (flutter/flutter#162116)2025-01-24 reidbaker@google.com Add integration test for cutout rotation evaluation (flutter/flutter#160354)2025-01-24 flar@google.com Reland "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162146)2025-01-24 bruno.leroux@gmail.com Fix TextField intrinsic width when hint is not visible (flutter/flutter#161235)2025-01-24 magder@google.com When parsing flavors, handle Xcode build configurations that are not lowercase (flutter/flutter#161455)2025-01-24 flar@google.com [Impeller] Fix source offset in PathBuilder::AddPath (flutter/flutter#162052)2025-01-24 jessiewong401@gmail.com Add to Setup Path Example to Engine README (flutter/flutter#162115)2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unskip test. (#162106)" (flutter/flutter#162122)2025-01-23 31410839+maheshj01@users.noreply.github.com feat: Add `hint` (Widget) property to InputDecoration (flutter/flutter#161424)2025-01-23 jacksongardner@google.com Fix skwasm target in wasm_debug_unopt build. (flutter/flutter#162100)2025-01-23 fluttergithubbot@gmail.com Marks Linux_android_emu android views to be unflaky (flutter/flutter#160493)2025-01-23 polinach@google.com Unskip test. (flutter/flutter#162106)2025-01-23 tessertaha@gmail.com Add ability to maintain bottom view padding in `NavigationBar` safe area (flutter/flutter#162076)2025-01-23 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162095)2025-01-23 matanlurey@users.noreply.github.com Delete an unused (manual) workflow, added missing copyright headers. (flutter/flutter#162050)2025-01-23 barpac02@gmail.com Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)2025-01-23 chris@bracken.jp flutter_tools: flutter_tester is a host artifact (flutter/flutter#162047)2025-01-23 jason-simmons@users.noreply.github.com [Impeller] Make glIsTexture mockable for use by the ReactorGLES.NameUntrackedHandle test (flutter/flutter#162082)2025-01-23 magder@google.com Remove "Mac Designed for iPad" as a discoverable `flutter run` device (flutter/flutter#161459)2025-01-23 737941+loic-sharma@users.noreply.github.com Show error on macOS if missing Local Network permissions (flutter/flutter#161846)2025-01-23 jmccandless@google.com Autocomplete keyboard navigation (flutter/flutter#159455)If this roll has caused a breakage, revert this CL and stop the rollerusing the controls here:https://autoroll.skia.org/r/flutter-packagesPlease CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a humanis aware of the problem.To file a bug in Packages:https://github.com/flutter/flutter/issues/new/chooseTo report a problem with the AutoRoller itself, please file a bug:https://issues.skia.org/issues/new?component=1389291&template=1850622Documentation for the AutoRoller is here:https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.