- Notifications
You must be signed in to change notification settings - Fork30k
Autocomplete keyboard navigation#159455
Merged
auto-submit[bot] merged 16 commits intoflutter:masterfromJan 23, 2025
Merged
Conversation
Trying out <select> on web, it doesn't wrap, so let's not wrap either.
But maybe I want to test this with the highlight index instead ofsubmitting each time...
Contributor
victorsanni commentedNov 26, 2024
Should this land before or after#143249? |
ContributorAuthor
justinmc commentedNov 26, 2024
Ah I was hoping this would be totally separate and not conflict, but I do see merge conflicts if I try to merge one into the other. Is#143249 close to merging? I don't want to delay that any further, so this one can probably wait. |
Contributor
victorsanni left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't fully understand actions/intents in Flutter, but the approach and tests lgtm.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
ContributorAuthor
justinmc commentedJan 15, 2025
Updated to the monorepo and autoformatter, but waiting for#143249 to be relanded. |
victorsanni approved these changesJan 21, 2025
Contributor
victorsanni left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not very knowledgeable about actions/intents, but the autocomplete parts lgtm. How much of a breaking change is the options list no longer wrapping at the ends?
| debugLabel: '_RawAutocompleteState', | ||
| ); | ||
| static const int _pageSize = 4; |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There should be a comment here explaining what this variable means.
ContributorAuthor
justinmc commentedJan 21, 2025
@Renzo-Olivares Could you do the secondary review here just to make sure the action/intent stuff looks good? |
ContributorAuthor
justinmc commentedJan 21, 2025
It seems to not break any Google or customer tests. I adjusted two places in our tests that broke when I made the change. I think I wrote that wrapping behavior just off the top of my head without trying |
Renzo-Olivares approved these changesJan 23, 2025
Contributor
Renzo-Olivares left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Actions/intents LGTM
Merged via the queue intoflutter:master with commitJan 23, 2025
3baa356 104 checks passed
Uh oh!
There was an error while loading.Please reload this page.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestJan 24, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestJan 24, 2025
Wasmund1 pushed a commit to Wasmund1/flutter that referenced this pull requestJan 24, 2025
I noticed some problems with Autocomplete keyboard navigation:* Previously, when wrapping from the top to bottom or vice-versa,scrolling wouldn't happen until after you hit the arrow key a few extratimes. This is due to the way we were doing scrolling and the fact thatthose items were not yet built by ListView.builder. I fixed this.<details><summary>Video of scrolling bug</summary>[Screencast from 2024-11-2516-21-06.webm](https://github.com/user-attachments/assets/ce01065a-1a03-4f37-b0f6-2d6273852ac4)</details>* This wrapping feature itself seemed to not be part of the `<select>`tag on web ([try it onMDN](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/select)),which Autocomplete is kind of based on, so I removed it. It now stops atthe top/bottom.* We were missing a couple of keyboard shortcuts(flutter#85233)Fixesflutter#85233
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestJan 24, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestJan 24, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestJan 24, 2025
auto-submitbot pushed a commit to flutter/packages that referenced this pull requestJan 24, 2025
Manual roll requested by tarrinneal@google.comflutter/flutter@c1561a4...c1ffaa92025-01-24 737941+loic-sharma@users.noreply.github.com Fix link to hotfix documentation best practices (flutter/flutter#162116)2025-01-24 reidbaker@google.com Add integration test for cutout rotation evaluation (flutter/flutter#160354)2025-01-24 flar@google.com Reland "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162146)2025-01-24 bruno.leroux@gmail.com Fix TextField intrinsic width when hint is not visible (flutter/flutter#161235)2025-01-24 magder@google.com When parsing flavors, handle Xcode build configurations that are not lowercase (flutter/flutter#161455)2025-01-24 flar@google.com [Impeller] Fix source offset in PathBuilder::AddPath (flutter/flutter#162052)2025-01-24 jessiewong401@gmail.com Add to Setup Path Example to Engine README (flutter/flutter#162115)2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unskip test. (#162106)" (flutter/flutter#162122)2025-01-23 31410839+maheshj01@users.noreply.github.com feat: Add `hint` (Widget) property to InputDecoration (flutter/flutter#161424)2025-01-23 jacksongardner@google.com Fix skwasm target in wasm_debug_unopt build. (flutter/flutter#162100)2025-01-23 fluttergithubbot@gmail.com Marks Linux_android_emu android views to be unflaky (flutter/flutter#160493)2025-01-23 polinach@google.com Unskip test. (flutter/flutter#162106)2025-01-23 tessertaha@gmail.com Add ability to maintain bottom view padding in `NavigationBar` safe area (flutter/flutter#162076)2025-01-23 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162095)2025-01-23 matanlurey@users.noreply.github.com Delete an unused (manual) workflow, added missing copyright headers. (flutter/flutter#162050)2025-01-23 barpac02@gmail.com Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)2025-01-23 chris@bracken.jp flutter_tools: flutter_tester is a host artifact (flutter/flutter#162047)2025-01-23 jason-simmons@users.noreply.github.com [Impeller] Make glIsTexture mockable for use by the ReactorGLES.NameUntrackedHandle test (flutter/flutter#162082)2025-01-23 magder@google.com Remove "Mac Designed for iPad" as a discoverable `flutter run` device (flutter/flutter#161459)2025-01-23 737941+loic-sharma@users.noreply.github.com Show error on macOS if missing Local Network permissions (flutter/flutter#161846)2025-01-23 jmccandless@google.com Autocomplete keyboard navigation (flutter/flutter#159455)If this roll has caused a breakage, revert this CL and stop the rollerusing the controls here:https://autoroll.skia.org/r/flutter-packagesPlease CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a humanis aware of the problem.To file a bug in Packages:https://github.com/flutter/flutter/issues/new/chooseTo report a problem with the AutoRoller itself, please file a bug:https://issues.skia.org/issues/new?component=1389291&template=1850622Documentation for the AutoRoller is here:https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 21, 2025
androidseb pushed a commit to androidseb/packages that referenced this pull requestJun 8, 2025
)Manual roll requested by tarrinneal@google.comflutter/flutter@c1561a4...c1ffaa92025-01-24 737941+loic-sharma@users.noreply.github.com Fix link to hotfix documentation best practices (flutter/flutter#162116)2025-01-24 reidbaker@google.com Add integration test for cutout rotation evaluation (flutter/flutter#160354)2025-01-24 flar@google.com Reland "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162146)2025-01-24 bruno.leroux@gmail.com Fix TextField intrinsic width when hint is not visible (flutter/flutter#161235)2025-01-24 magder@google.com When parsing flavors, handle Xcode build configurations that are not lowercase (flutter/flutter#161455)2025-01-24 flar@google.com [Impeller] Fix source offset in PathBuilder::AddPath (flutter/flutter#162052)2025-01-24 jessiewong401@gmail.com Add to Setup Path Example to Engine README (flutter/flutter#162115)2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unskip test. (#162106)" (flutter/flutter#162122)2025-01-23 31410839+maheshj01@users.noreply.github.com feat: Add `hint` (Widget) property to InputDecoration (flutter/flutter#161424)2025-01-23 jacksongardner@google.com Fix skwasm target in wasm_debug_unopt build. (flutter/flutter#162100)2025-01-23 fluttergithubbot@gmail.com Marks Linux_android_emu android views to be unflaky (flutter/flutter#160493)2025-01-23 polinach@google.com Unskip test. (flutter/flutter#162106)2025-01-23 tessertaha@gmail.com Add ability to maintain bottom view padding in `NavigationBar` safe area (flutter/flutter#162076)2025-01-23 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162095)2025-01-23 matanlurey@users.noreply.github.com Delete an unused (manual) workflow, added missing copyright headers. (flutter/flutter#162050)2025-01-23 barpac02@gmail.com Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)2025-01-23 chris@bracken.jp flutter_tools: flutter_tester is a host artifact (flutter/flutter#162047)2025-01-23 jason-simmons@users.noreply.github.com [Impeller] Make glIsTexture mockable for use by the ReactorGLES.NameUntrackedHandle test (flutter/flutter#162082)2025-01-23 magder@google.com Remove "Mac Designed for iPad" as a discoverable `flutter run` device (flutter/flutter#161459)2025-01-23 737941+loic-sharma@users.noreply.github.com Show error on macOS if missing Local Network permissions (flutter/flutter#161846)2025-01-23 jmccandless@google.com Autocomplete keyboard navigation (flutter/flutter#159455)If this roll has caused a breakage, revert this CL and stop the rollerusing the controls here:https://autoroll.skia.org/r/flutter-packagesPlease CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a humanis aware of the problem.To file a bug in Packages:https://github.com/flutter/flutter/issues/new/chooseTo report a problem with the AutoRoller itself, please file a bug:https://issues.skia.org/issues/new?component=1389291&template=1850622Documentation for the AutoRoller is here:https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull requestJun 9, 2025
)Manual roll requested by tarrinneal@google.comflutter/flutter@c1561a4...c1ffaa92025-01-24 737941+loic-sharma@users.noreply.github.com Fix link to hotfix documentation best practices (flutter/flutter#162116)2025-01-24 reidbaker@google.com Add integration test for cutout rotation evaluation (flutter/flutter#160354)2025-01-24 flar@google.com Reland "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162146)2025-01-24 bruno.leroux@gmail.com Fix TextField intrinsic width when hint is not visible (flutter/flutter#161235)2025-01-24 magder@google.com When parsing flavors, handle Xcode build configurations that are not lowercase (flutter/flutter#161455)2025-01-24 flar@google.com [Impeller] Fix source offset in PathBuilder::AddPath (flutter/flutter#162052)2025-01-24 jessiewong401@gmail.com Add to Setup Path Example to Engine README (flutter/flutter#162115)2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unskip test. (#162106)" (flutter/flutter#162122)2025-01-23 31410839+maheshj01@users.noreply.github.com feat: Add `hint` (Widget) property to InputDecoration (flutter/flutter#161424)2025-01-23 jacksongardner@google.com Fix skwasm target in wasm_debug_unopt build. (flutter/flutter#162100)2025-01-23 fluttergithubbot@gmail.com Marks Linux_android_emu android views to be unflaky (flutter/flutter#160493)2025-01-23 polinach@google.com Unskip test. (flutter/flutter#162106)2025-01-23 tessertaha@gmail.com Add ability to maintain bottom view padding in `NavigationBar` safe area (flutter/flutter#162076)2025-01-23 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162095)2025-01-23 matanlurey@users.noreply.github.com Delete an unused (manual) workflow, added missing copyright headers. (flutter/flutter#162050)2025-01-23 barpac02@gmail.com Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)2025-01-23 chris@bracken.jp flutter_tools: flutter_tester is a host artifact (flutter/flutter#162047)2025-01-23 jason-simmons@users.noreply.github.com [Impeller] Make glIsTexture mockable for use by the ReactorGLES.NameUntrackedHandle test (flutter/flutter#162082)2025-01-23 magder@google.com Remove "Mac Designed for iPad" as a discoverable `flutter run` device (flutter/flutter#161459)2025-01-23 737941+loic-sharma@users.noreply.github.com Show error on macOS if missing Local Network permissions (flutter/flutter#161846)2025-01-23 jmccandless@google.com Autocomplete keyboard navigation (flutter/flutter#159455)If this roll has caused a breakage, revert this CL and stop the rollerusing the controls here:https://autoroll.skia.org/r/flutter-packagesPlease CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a humanis aware of the problem.To file a bug in Packages:https://github.com/flutter/flutter/issues/new/chooseTo report a problem with the AutoRoller itself, please file a bug:https://issues.skia.org/issues/new?component=1389291&template=1850622Documentation for the AutoRoller is here:https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
f: material designflutter/packages/flutter/material repository. frameworkflutter/packages/flutter repository. See also f: labels.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed some problems with Autocomplete keyboard navigation:
Video of scrolling bug
Screencast.from.2024-11-25.16-21-06.webm
<select>tag on web (try it on MDN), which Autocomplete is kind of based on, so I removed it. It now stops at the top/bottom.Fixes#85233