It does feel a bit weird thatremoveRouteBelow is no longer consistent withremoveRoute. Should we change all of these methods to complete their respective futures?

pushAndRemoveUntil, restorablePushAndRemoveUntil, restorablePushNamedAndRemoveUntil and pushAndRemoveUntil could be supported but we need to add an extra logique like a callback to let developper choose to override the value ofdidComplete(result). if the callback is not provided we can fallback to null.

Maybe that can take place into an future pull request because that will also touch popUntil.

PR edited to support removeRouteBelow.

We can also go forward and try to support all method like replace, restorable etc.

Must i support them all inside this PR with the risk to delay massively it or should i create a dedicated PR later ? (New unit test will be needed, lot of changes)

Must I support them all inside this PR with the risk of a massive delay, or should I create a dedicated PR later?

That's a really good question.

I suppose my question would be: is it all right forremoveRoute &removeRouteBelow to both complete their respective futures, but for none of the other similar methods to do this?

If we merge this pull request today and there end up being issues with migrating the similar methods, I think the API would be more inconsistent than it is now.

pushAndRemoveUntil, restorablePushAndRemoveUntil, restorablePushNamedAndRemoveUntil and pushAndRemoveUntil could be supported but we would need to add extra logic, like a callback, to give the developer an option to override the value ofdidComplete(result); if the callback is not provided we can fallback to null.

My opinion as of now is that it'd be best for each removed route to have its future completed, but we can just dodidComplete(null) for now. If we wantpushAndRemoveUntil to support completing with a value, that can be saved for a future PR.

Does that sound okay to you?

That could be a great roadmap : first time didComplete(null) by default, next PR logic to well handle that everywhere.

I tested quickly on my side, I can well update all these functions to support theresult property, and when needed, a dedicated callback for whose related to popUntil and removeUntil. Will do that later in dedicated PR (if you and reviewer agree).

SGTM!