Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

FixDateRangePickerDialog does not userangePickerHeaderBackgroundColor fromDatePickerTheme in M2#147370

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
TahaTesser:dateRangePickerDialog_header_background
Apr 26, 2024
Merged

FixDateRangePickerDialog does not userangePickerHeaderBackgroundColor fromDatePickerTheme in M2#147370
auto-submit[bot] merged 1 commit intoflutter:masterfrom
TahaTesser:dateRangePickerDialog_header_background

Conversation

@TahaTesser
Copy link
Contributor

fixesDatePickerThemeData'srangePickerHeaderBackgroundColor not being applied to DateRangePickerDialog on M2

Code sample

expand to view the code sample
import'package:flutter/material.dart';voidmain()=>runApp(constMyApp());classMyAppextendsStatelessWidget {constMyApp({super.key});@overrideWidgetbuild(BuildContext context) {returnMaterialApp(      debugShowCheckedModeBanner:false,      theme:ThemeData(        useMaterial3:false,        datePickerTheme:constDatePickerThemeData(          rangePickerHeaderBackgroundColor:Colors.red,        ),      ),      home:Scaffold(        body:Center(          child:Builder(builder: (BuildContext context) {returnElevatedButton(              onPressed: () {showDateRangePicker(                  context: context,                  currentDate:DateTime.now(),                  initialDateRange:DateTimeRange(                    start:DateTime.now(),                    end:DateTime.now().add(constDuration(days:7)),                  ),                  firstDate:DateTime(2000),                  lastDate:DateTime(2025),                );              },              child:constText('Show Date Range Picker'),            );          }),        ),      ),    );  }}

When usingrangePickerHeaderBackgroundColor inDatePickerTheme for M2

      theme:ThemeData(        useMaterial3:false,        datePickerTheme:constDatePickerThemeData(          rangePickerHeaderBackgroundColor:Colors.red,        ),      ),
BeforeAfter

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel onDiscord.

@github-actionsgithub-actionsbot added frameworkflutter/packages/flutter repository. See also f: labels. f: material designflutter/packages/flutter/material repository. labelsApr 25, 2024
@TahaTesserTahaTesser marked this pull request as ready for reviewApril 25, 2024 13:40
Copy link
Contributor

@HansMullerHansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@HansMullerHansMuller added the autosubmitMerge PR when tree becomes green via auto submit App labelApr 25, 2024
@auto-submitauto-submitbot merged commit9a2d94e intoflutter:masterApr 26, 2024
@TahaTesserTahaTesser deleted the dateRangePickerDialog_header_background branchApril 26, 2024 06:53
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestApr 26, 2024
auto-submitbot pushed a commit to flutter/packages that referenced this pull requestApr 26, 2024
flutter/flutter@5d3bca4...2e806702024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from d79458007712 to c410180e5bba (1 revision) (flutter/flutter#147407)2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 11a857e1599f to d79458007712 (1 revision) (flutter/flutter#147401)2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from e99fc6ef91ef to 11a857e1599f (4 revisions) (flutter/flutter#147399)2024-04-26 tessertaha@gmail.com Fix `FloatingActionButton` docs for `background` and `foreground` properties (flutter/flutter#147372)2024-04-26 49699333+dependabot[bot]@users.noreply.github.com Bump peter-evans/create-pull-request from 6.0.4 to 6.0.5 (flutter/flutter#147388)2024-04-26 tessertaha@gmail.com Fix `DateRangePickerDialog` does not use `rangePickerHeaderBackgroundColor` from `DatePickerTheme` in M2 (flutter/flutter#147370)2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from a09295fe03c0 to e99fc6ef91ef (4 revisions) (flutter/flutter#147391)2024-04-26 polinach@google.com Clean up leaks in a test. (flutter/flutter#147312)2024-04-26 47866232+chunhtai@users.noreply.github.com add a new PopScope.onPopWithResultInvoke widget to replace PopScope.onPopInvoke (flutter/flutter#147016)2024-04-26 31859944+LongCatIsLooong@users.noreply.github.com zero-sized RenderConstraintsTransformBox respects clipBehavior (flutter/flutter#147349)2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3768ca0c02da to a09295fe03c0 (1 revision) (flutter/flutter#147386)2024-04-25 jonahwilliams@google.com [devicelab] explicitly enable vulkan validation in test. (flutter/flutter#147382)2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 10a3504a9261 to 3768ca0c02da (1 revision) (flutter/flutter#147381)2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 694756b875bf to 10a3504a9261 (3 revisions) (flutter/flutter#147380)2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 19c182f47bde to 694756b875bf (1 revision) (flutter/flutter#147379)2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 163c18e870a9 to 19c182f47bde (1 revision) (flutter/flutter#147378)2024-04-25 47866232+chunhtai@users.noreply.github.com Makes badge to auto size with content (flutter/flutter#146853)2024-04-25 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in `Hero` widget (flutter/flutter#147303)2024-04-25 engine-flutter-autoroll@skia.org Roll Packages fromcf6d280 tofde908d (11 revisions) (flutter/flutter#147375)2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 674890ce7141 to 163c18e870a9 (1 revision) (flutter/flutter#147373)If this roll has caused a breakage, revert this CL and stop the rollerusing the controls here:https://autoroll.skia.org/r/flutter-packagesPlease CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a humanis aware of the problem.To file a bug in Packages:https://github.com/flutter/flutter/issues/new/chooseTo report a problem with the AutoRoller itself, please file a bug:https://issues.skia.org/issues/new?component=1389291&template=1850622Documentation for the AutoRoller is here:https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull requestMay 22, 2024
flutter/flutter@5d3bca4...2e806702024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from d79458007712 to c410180e5bba (1 revision) (flutter/flutter#147407)2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 11a857e1599f to d79458007712 (1 revision) (flutter/flutter#147401)2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from e99fc6ef91ef to 11a857e1599f (4 revisions) (flutter/flutter#147399)2024-04-26 tessertaha@gmail.com Fix `FloatingActionButton` docs for `background` and `foreground` properties (flutter/flutter#147372)2024-04-26 49699333+dependabot[bot]@users.noreply.github.com Bump peter-evans/create-pull-request from 6.0.4 to 6.0.5 (flutter/flutter#147388)2024-04-26 tessertaha@gmail.com Fix `DateRangePickerDialog` does not use `rangePickerHeaderBackgroundColor` from `DatePickerTheme` in M2 (flutter/flutter#147370)2024-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from a09295fe03c0 to e99fc6ef91ef (4 revisions) (flutter/flutter#147391)2024-04-26 polinach@google.com Clean up leaks in a test. (flutter/flutter#147312)2024-04-26 47866232+chunhtai@users.noreply.github.com add a new PopScope.onPopWithResultInvoke widget to replace PopScope.onPopInvoke (flutter/flutter#147016)2024-04-26 31859944+LongCatIsLooong@users.noreply.github.com zero-sized RenderConstraintsTransformBox respects clipBehavior (flutter/flutter#147349)2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3768ca0c02da to a09295fe03c0 (1 revision) (flutter/flutter#147386)2024-04-25 jonahwilliams@google.com [devicelab] explicitly enable vulkan validation in test. (flutter/flutter#147382)2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 10a3504a9261 to 3768ca0c02da (1 revision) (flutter/flutter#147381)2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 694756b875bf to 10a3504a9261 (3 revisions) (flutter/flutter#147380)2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 19c182f47bde to 694756b875bf (1 revision) (flutter/flutter#147379)2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 163c18e870a9 to 19c182f47bde (1 revision) (flutter/flutter#147378)2024-04-25 47866232+chunhtai@users.noreply.github.com Makes badge to auto size with content (flutter/flutter#146853)2024-04-25 32538273+ValentinVignal@users.noreply.github.com Fix memory leaks in `Hero` widget (flutter/flutter#147303)2024-04-25 engine-flutter-autoroll@skia.org Roll Packages fromcf6d280 tofde908d (11 revisions) (flutter/flutter#147375)2024-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 674890ce7141 to 163c18e870a9 (1 revision) (flutter/flutter#147373)If this roll has caused a breakage, revert this CL and stop the rollerusing the controls here:https://autoroll.skia.org/r/flutter-packagesPlease CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a humanis aware of the problem.To file a bug in Packages:https://github.com/flutter/flutter/issues/new/chooseTo report a problem with the AutoRoller itself, please file a bug:https://issues.skia.org/issues/new?component=1389291&template=1850622Documentation for the AutoRoller is here:https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestAug 6, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@HansMullerHansMullerHansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appf: material designflutter/packages/flutter/material repository.frameworkflutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DatePickerThemeData'srangePickerHeaderBackgroundColor not being applied to DateRangePickerDialog on M2

2 participants

@TahaTesser@HansMuller

Comments

[8]ページ先頭
©2009-2026 Movatter.jp