- Notifications
You must be signed in to change notification settings - Fork30k
Disable single character mode in the terminal when exiting flutter_tools#146534
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfromApr 10, 2024
Merged
Conversation
| _now = now ?? DateTime(1), | ||
| _isCliAnimationEnabled = defaultCliAnimationEnabled; | ||
| _isCliAnimationEnabled = defaultCliAnimationEnabled { | ||
| shutdownHooks?.addShutdownHook(() { singleCharMode = false; }); |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm guessing this would affect the case in which we're in the middle offlutter run ... but the user sends a SIGINT signal to the tool. Are there any other cases where we were failing to set singleCharMode back to false?
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yes - this is intended to restore the terminal to its normal state if the tool is killed when single character mode is enabled.
| } | ||
| final io.Stdin stdin = _stdio.stdin as io.Stdin; | ||
| return stdin.lineMode && stdin.echoMode; | ||
| return!stdin.lineMode &&!stdin.echoMode; |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This seems like a huge logic bug, and yet it seems like the only place this was actually called is from tests? Did you observe buggy behavior here, or just observe the code was wrong?
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The getter did not match the setter.set singleCharMode setsechoMode andlineMode tofalse ifvalue is true, but the getter had reversed this.
AFAICT this getter is not used anywhere except the test added in this PR.
christopherfujino approved these changesApr 10, 2024
Contributor
christopherfujino left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestApr 11, 2024
auto-submitbot pushed a commit to flutter/packages that referenced this pull requestApr 11, 2024
flutter/flutter@97cd47a...557fbf52024-04-11 barpac02@gmail.com Update app Android gradle scripts to use flutter.versionName and flutter.versionCode (flutter/flutter#146604)2024-04-11 tessertaha@gmail.com Fix out of sync templates files and add a check (flutter/flutter#145747)2024-04-11 dacoharkes@google.com [tools] Fix `--template=plugin_ffi` formatting (flutter/flutter#146269)2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 40b0f81332cb to d8560d495d9f (1 revision) (flutter/flutter#146622)2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from fef8499fb9bf to 40b0f81332cb (1 revision) (flutter/flutter#146621)2024-04-11 tessertaha@gmail.com Fix `IconButton` theming in the `InputDecorator` (flutter/flutter#146567)2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from e2a45bda45cb to fef8499fb9bf (1 revision) (flutter/flutter#146619)2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from e47dc9a7a24d to e2a45bda45cb (1 revision) (flutter/flutter#146618)2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 069e73eaef34 to e47dc9a7a24d (1 revision) (flutter/flutter#146617)2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 28ed19073fcf to 069e73eaef34 (1 revision) (flutter/flutter#146613)2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4e33a0b47e3d to 28ed19073fcf (1 revision) (flutter/flutter#146611)2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6f8ee9ffd9fa to 4e33a0b47e3d (3 revisions) (flutter/flutter#146609)2024-04-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 91ba23575c82 to 6f8ee9ffd9fa (4 revisions) (flutter/flutter#146607)2024-04-10 jason-simmons@users.noreply.github.com Disable single character mode in the terminal when exiting flutter_tools (flutter/flutter#146534)2024-04-10 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#146606)2024-04-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from beee02b5ba2d to 91ba23575c82 (4 revisions) (flutter/flutter#146605)2024-04-10 34871572+gmackall@users.noreply.github.com Remove additional references to engine v1 android embedding (flutter/flutter#146523)2024-04-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 077b742550ef to beee02b5ba2d (2 revisions) (flutter/flutter#146591)2024-04-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0d5412d4ee4b to 077b742550ef (1 revision) (flutter/flutter#146585)2024-04-10 15619084+vashworth@users.noreply.github.com Convert ProjectMigration and ProjectMigrator to be async (flutter/flutter#146537)2024-04-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from cee489a4e275 to 0d5412d4ee4b (7 revisions) (flutter/flutter#146577)2024-04-10 engine-flutter-autoroll@skia.org Roll Packages from17f55d3 to2c15d86 (2 revisions) (flutter/flutter#146575)If this roll has caused a breakage, revert this CL and stop the rollerusing the controls here:https://autoroll.skia.org/r/flutter-packagesPlease CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a humanis aware of the problem.To file a bug in Packages:https://github.com/flutter/flutter/issues/new/chooseTo report a problem with the AutoRoller itself, please file a bug:https://issues.skia.org/issues/new?component=1389291&template=1850622Documentation for the AutoRoller is here:https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull requestApr 22, 2024
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull requestMay 22, 2024
flutter/flutter@97cd47a...557fbf52024-04-11 barpac02@gmail.com Update app Android gradle scripts to use flutter.versionName and flutter.versionCode (flutter/flutter#146604)2024-04-11 tessertaha@gmail.com Fix out of sync templates files and add a check (flutter/flutter#145747)2024-04-11 dacoharkes@google.com [tools] Fix `--template=plugin_ffi` formatting (flutter/flutter#146269)2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 40b0f81332cb to d8560d495d9f (1 revision) (flutter/flutter#146622)2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from fef8499fb9bf to 40b0f81332cb (1 revision) (flutter/flutter#146621)2024-04-11 tessertaha@gmail.com Fix `IconButton` theming in the `InputDecorator` (flutter/flutter#146567)2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from e2a45bda45cb to fef8499fb9bf (1 revision) (flutter/flutter#146619)2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from e47dc9a7a24d to e2a45bda45cb (1 revision) (flutter/flutter#146618)2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 069e73eaef34 to e47dc9a7a24d (1 revision) (flutter/flutter#146617)2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 28ed19073fcf to 069e73eaef34 (1 revision) (flutter/flutter#146613)2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4e33a0b47e3d to 28ed19073fcf (1 revision) (flutter/flutter#146611)2024-04-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6f8ee9ffd9fa to 4e33a0b47e3d (3 revisions) (flutter/flutter#146609)2024-04-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 91ba23575c82 to 6f8ee9ffd9fa (4 revisions) (flutter/flutter#146607)2024-04-10 jason-simmons@users.noreply.github.com Disable single character mode in the terminal when exiting flutter_tools (flutter/flutter#146534)2024-04-10 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#146606)2024-04-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from beee02b5ba2d to 91ba23575c82 (4 revisions) (flutter/flutter#146605)2024-04-10 34871572+gmackall@users.noreply.github.com Remove additional references to engine v1 android embedding (flutter/flutter#146523)2024-04-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 077b742550ef to beee02b5ba2d (2 revisions) (flutter/flutter#146591)2024-04-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0d5412d4ee4b to 077b742550ef (1 revision) (flutter/flutter#146585)2024-04-10 15619084+vashworth@users.noreply.github.com Convert ProjectMigration and ProjectMigrator to be async (flutter/flutter#146537)2024-04-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from cee489a4e275 to 0d5412d4ee4b (7 revisions) (flutter/flutter#146577)2024-04-10 engine-flutter-autoroll@skia.org Roll Packages from17f55d3 to2c15d86 (2 revisions) (flutter/flutter#146575)If this roll has caused a breakage, revert this CL and stop the rollerusing the controls here:https://autoroll.skia.org/r/flutter-packagesPlease CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a humanis aware of the problem.To file a bug in Packages:https://github.com/flutter/flutter/issues/new/chooseTo report a problem with the AutoRoller itself, please file a bug:https://issues.skia.org/issues/new?component=1389291&template=1850622Documentation for the AutoRoller is here:https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
autosubmitMerge PR when tree becomes green via auto submit App toolAffects the "flutter" command-line tool. See also t: labels.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.