This repository was archived by the owner on Feb 25, 2025. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork6k
[skwasm] FixtoString methods on Paint and ImageFilter/ColorFilter#51766
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfromMar 29, 2024
Merged
Conversation
Thisfixesflutter/flutter#141639Most of this was previously unimplemented. It turns out the reason for thehang described in the github issue was that there was a typo in the name ofthe `getMiterLimit` C function, so if the client actually called that methodthe Wasm module failed to compile, as it couldn't find an import with themisspelled name.
yjbanov approved these changesMar 29, 2024
Contributor
yjbanov left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestMar 29, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestMar 29, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestMar 29, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestMar 29, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestMar 29, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestMar 29, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestMar 29, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestMar 29, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestMar 29, 2024
auto-submitbot pushed a commit to flutter/flutter that referenced this pull requestMar 29, 2024
flutter/engine@68aa9ba...b16c0f12024-03-29 skia-flutter-autoroll@skia.org Roll Skia from 94c0af1297ae to a12e40efacea (3 revisions) (flutter/engine#51776)2024-03-29 skia-flutter-autoroll@skia.org Roll Skia from b2a01ae03cdf to 94c0af1297ae (1 revision) (flutter/engine#51773)2024-03-29 skia-flutter-autoroll@skia.org Roll Skia from 6042ad386bcf to b2a01ae03cdf (4 revisions) (flutter/engine#51772)2024-03-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from uzI3wnbEGlZ_dtO0Z... to 3vgfbp1vjXkdMZ09m... (flutter/engine#51767)2024-03-29 jacksongardner@google.com [skwasm] Fix `toString` methods on Paint and ImageFilter/ColorFilter (flutter/engine#51766)2024-03-29 john@johnmccutchan.com Relandflutter/engine#51391 (flutter/engine#51764)2024-03-29 737941+loic-sharma@users.noreply.github.com Add completion callback to `Shell::AddView` (flutter/engine#51659)2024-03-29 737941+loic-sharma@users.noreply.github.com [Windows] Move keyboard initialization (flutter/engine#51758)2024-03-29 737941+loic-sharma@users.noreply.github.com [Windows] Don't always stop engine on view destruction (flutter/engine#51681)2024-03-28 dkwingsmt@users.noreply.github.com [macOS] Group per-view information in `FlutterCompositor` into a class (flutter/engine#51738)Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from uzI3wnbEGlZ_ to 3vgfbp1vjXkdIf this roll has caused a breakage, revert this CL and stop the rollerusing the controls here:https://autoroll.skia.org/r/flutter-engine-flutter-autorollPlease CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a humanis aware of the problem.To file a bug in Flutter:https://github.com/flutter/flutter/issues/new/chooseTo report a problem with the AutoRoller itself, please file a bug:https://issues.skia.org/issues/new?component=1389291&template=1850622Documentation for the AutoRoller is here:https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
autosubmitMerge PR when tree becomes green via auto submit App platform-webCode specifically for the web engine
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thisfixesflutter/flutter#141639
Most of this was previously unimplemented. It turns out the reason for the hang described in the github issue was that there was a typo in the name of the
getMiterLimitC function, so if the client actually called that method the Wasm module failed to compile, as it couldn't find an import with the misspelled name.