Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
/enginePublic archive

[Impeller] Fail GN when building an enabled Impeller backend is impossible.#40772

Merged
bdero merged 1 commit intoflutter:mainfrom
bdero:bdero/impeller-explicit-backend-fail
Mar 30, 2023
Merged

[Impeller] Fail GN when building an enabled Impeller backend is impossible.#40772
bdero merged 1 commit intoflutter:mainfrom
bdero:bdero/impeller-explicit-backend-fail

Conversation

@bdero
Copy link
Contributor

@bderobdero commentedMar 30, 2023•
edited
Loading

When--enable-impeller-* args writeimpeller_enable_* args, and sodeclare_args inimpeller.gni are ignored and it'll always attempt to build enabled backends even if they will obviously fail.

I ran into some confusion when accidentally flipping on Vulkan for iOS:https://gist.github.com/bdero/fa11a596ece56055d50e5afecfd4d03d

@bderobdero self-assigned thisMar 30, 2023
@bdero
Copy link
ContributorAuthor

bdero commentedMar 30, 2023•
edited
Loading

An alternative would be to just make the names not clash and have theimpeller.gni args logic not enable backends when they won't work.

@chinmaygardechinmaygarde changed the titleFail GN when building an enabled Impeller backend is impossible[Impeller] Fail GN when building an enabled Impeller backend is impossible.Mar 30, 2023
@bderobdero merged commit1be5152 intoflutter:mainMar 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestMar 30, 2023
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this pull requestMar 30, 2023
…re impossible to build (flutter/engine#40772) (#123747)Commit: e3ec1264b0aa0ef7d6f8ebfc003de1a2966b798c
auto-submitbot pushed a commit to flutter/flutter that referenced this pull requestMar 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMar 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestApr 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestApr 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestApr 1, 2023
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull requestApr 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull requestMay 10, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

1 more reviewer

@chinmaygardechinmaygardechinmaygarde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bderobdero

Projects

No open projects
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bdero@chinmaygarde

Comments

[8]ページ先頭
©2009-2026 Movatter.jp