This repository was archived by the owner on Feb 25, 2025. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork6k
[Impeller] Add playground flag to render for a specific amount of time.#40377
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfromMar 18, 2023
Merged
[Impeller] Add playground flag to render for a specific amount of time.#40377auto-submit[bot] merged 1 commit intoflutter:mainfrom
auto-submit[bot] merged 1 commit intoflutter:mainfrom
Conversation
The playgrounds respect the usual GTest flags such as --gtest_filter. Now,specific test harnesses can add their own flags. The playgrounds now respect a--playground_timeout_ms flag that renders a playground for a set amount of time.Setting this to zero will mean that the playgrounds render only a single frame.
ContributorAuthor
chinmaygarde commentedMar 17, 2023
|
ContributorAuthor
chinmaygarde commentedMar 17, 2023
We could also make the playground not be a GN define with this mechanism. |
bdero approved these changesMar 17, 2023
Contributor
bdero left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestMar 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestMar 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestMar 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestMar 18, 2023
zanderso pushed a commit to flutter/flutter that referenced this pull requestMar 18, 2023
*e6334f1 [web] Remove image codecs from Canvaskit Chromium (flutter/engine#40309)*56727d6 Revert "[Impeller] mark decoded images as optimized for GPU access (#40356)" (flutter/engine#40387)*2cd19e3 Wrap the iOS platform message handler in an autorelease pool block (flutter/engine#40373)*bab7853 Update analyzer for api_conform_test (flutter/engine#40386)*87b2e82 Roll Fuchsia Mac SDK from z32cF6YFs6CvZbY3g... to 4ZrEK2uzGdp_Gz3DU... (flutter/engine#40385)*fc57995 Ignore some MTLCompiler failures in impeller unit tests (flutter/engine#40391)*2398c52 Add doc comment to Pipeline (flutter/engine#40388)*f585d4b [macOS] Remove a single accessibility root assumption (flutter/engine#40316)*940cf3c remove temporary flag and make FlutterTest the default font for real (flutter/engine#40352)*a1bf9fd drawTextBlob should not be compatible with opacity inheritance (flutter/engine#40396)*55bf0d8 Use bundled analyzer everywhere (flutter/engine#40398)*8e58041 Roll Skia from 9bfb45d3e065 to 49b902e5fb91 (11 revisions) (flutter/engine#40397)*77c53d2 Default the CanvasKit base URL to local artifacts. (flutter/engine#40293)*625ea53 Roll Skia from 49b902e5fb91 to aa983f5486f0 (7 revisions) (flutter/engine#40404)*867679f [Impeller] Add playground flag to render for a specific amount of time. (flutter/engine#40377)*d741696 [Impeller] Remove unused bounds method from typographer interface (flutter/engine#40406)*941323d Provisional iOS impeller flag flip (flutter/engine#40405)*bb971ab Revert "Default the CanvasKit base URL to local artifacts. (#40293)" (flutter/engine#40415)
zanderso pushed a commit to engine-flutter-autoroll/flutter that referenced this pull requestMar 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The playgrounds respect the usual GTest flags such as --gtest_filter. Now, specific test harnesses can add their own flags. The playgrounds now respect a --playground_timeout_ms flag that renders a playground for a set amount of time. Setting this to zero will mean that the playgrounds render only a single frame.