This repository was archived by the owner on Feb 25, 2025. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork6k
Fix function definitions in SPIR-V transpiler.#28352
Merged
chriscraws merged 4 commits intoflutter:masterfromAug 31, 2021
Merged
Fix function definitions in SPIR-V transpiler.#28352chriscraws merged 4 commits intoflutter:masterfrom
chriscraws merged 4 commits intoflutter:masterfrom
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
zanderso approved these changesAug 30, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull requestAug 31, 2021
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull requestAug 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Function calls were not tested and the definitions of function parameters were output separately, since the transpiler used to output function declarations before implementations.
flutter/flutter#89083
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel onDiscord.