- Notifications
You must be signed in to change notification settings - Fork371
Comments
Fix a null ref in CPU Profile when using offline snapshots with no connection#3596
Merged
DanTup merged 1 commit intoflutter:masterfromJan 27, 2022
Merged
Fix a null ref in CPU Profile when using offline snapshots with no connection#3596DanTup merged 1 commit intoflutter:masterfrom
DanTup merged 1 commit intoflutter:masterfrom
Conversation
kenzieschmoll approved these changesJan 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using an offline snapshot,
serviceManager.vmseems to be null here, so this throws (although it's only shown if there are no CPU samples, the widget is always constructed so this code always executes).Fixes#3595.