Commit1e4def5

committed

mymax: mysterious mypy error with optional callable arg

1 parent3bf9fb0 commit1e4def5Copy full SHA for 1e4def5

File tree

+13

-11

lines changed

+13

-11

lines changed

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -19,13 +19,12 @@ def __lt__(self, other: Any) -> bool:`
`19`	`19`
`20`	`20`	`T=TypeVar('T')`
`21`	`21`	`LessT=TypeVar('LessT',bound=SupportsLessThan)`
`22`		`-KeyFunc=Callable[[T],LessT]`
`23`	`22`
`24`	`23`	`@overload`
`25`	`24`	`defmax(first:LessT,*rest:LessT,key:None= ...)->LessT:`
`26`	`25`	`...`
`27`	`26`	`@overload`
`28`		`-defmax(first:T,*rest:T,key:KeyFunc)->T:`
	`27`	`+defmax(first:T,*rest:T,key:Callable[[T],LessT])->T:`
`29`	`28`	`...`
`30`	`29`	`defmax(first,*rest,key=None):`
`31`	`30`	`candidate=first`

Lines changed: 12 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -3,8 +3,7 @@`
`3`	`3`	`fromtypingimportTypeVar,Iterable,Optional,Callable`
`4`	`4`
`5`	`5`	`importmymax`
`6`		`-frommymaximportLessT,KeyFunc`
`7`		`-`
	`6`	`+frommymaximportLessT`
`8`	`7`	`importpytest`
`9`	`8`
`10`	`9`
`@@ -77,6 +76,13 @@ def test_multi_params(`
`77`	`76`	`assertresult==expected`
`78`	`77`
`79`	`78`
	`79`	`+deftest_two_complex():`
	`80`	`+a=5+4j`
	`81`	`+b=3+5j`
	`82`	`+result=mymax.max(a,b,key=abs)`
	`83`	`+assertresult==a`
	`84`	`+`
	`85`	`+`
`80`	`86`	`@pytest.mark.parametrize(`
`81`	`87`	`'first, rest, key, expected',`
`82`	`88`	`[`
`@@ -89,15 +95,12 @@ def test_multi_params(`
`89`	`95`	`deftest_multi_with_key_params(`
`90`	`96`	`first:LessT,`
`91`	`97`	`rest:Iterable[LessT],`
`92`		`-key:Optional[KeyFunc],`
	`98`	`+key:Optional[Callable[[T],LessT]],`
`93`	`99`	`expected:LessT,`
`94`	`100`	`)->None:`
`95`	`101`	`result=mymax.max(first,*rest,key=key)`
`96`	`102`	`assertresult==expected`
`97`	`103`
`98`		`-`
`99`		`-deftest_two_complex():`
`100`		`-a=5+4j`
`101`		`-b=3+5j`
`102`		`-result=mymax.max(a,b,key=abs)`
`103`		`-assertresult==a`
	`104`	`+# mysterious mypy error:`
	`105`	`+# mymax_test.py:101: error: Argument "key" to "max" has incompatible`
	`106`	`+# type "Optional[Callable[[T], LessT]]"; expected "None"`

Comments

(0)