This repository was archived by the owner on Dec 2, 2021. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork2.2k
Tests should use a separate shelve test database#14
Merged
ramalho merged 1 commit intofluentpython:masterfromerika-dike:setup_tests_to_use_separate_shelve_test_dbJun 19, 2021
Merged
Tests should use a separate shelve test database#14
ramalho merged 1 commit intofluentpython:masterfromerika-dike:setup_tests_to_use_separate_shelve_test_dbJun 19, 2021
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Switch from depreccated yield_fixture to fixture decorator
Thank you for this contribution@erika-dike! |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to run the tests locally, I ran into errors when pickle tried to load the already existing database. I think it would be nice if readers do not have to waste any time with this error.
This PR fixes that by creating a temporary database before any tests in the module run and deleting it afterwards. I also took the liberty of switching from the deprecated
@pytest.yield_fixtureto@pytest.fixture.Thanks for a wonderful book 😃.