- Notifications
You must be signed in to change notification settings - Fork691
Limit CI test targets by OS: run net8.0 on Linux and net48 on Windows only#2173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
cfef7a6 to678d672Comparejzabroski commentedNov 10, 2025
I changed it slightly; honestly, the way this is done is not great, I just haven't had the bandwidth to clean it up. Going to make some progress this month in prep for Microsoft releasing .NET 10 tomorrow. |
spopp23 commentedNov 10, 2025
Yeah, I just noticed. Thank you! I will close this PR then. |
jzabroski commentedNov 10, 2025
We can still go with your approach as a base. |
…son resolves correctly
jzabroski commentedNov 10, 2025
I was struggling to understand why this was still failing, and then I realized that its due to how I set-up permissions to prevent people from submitting PRs that change this file to execute Confused Deputy attacks and do things like potentially steal variables, viz a viz 'pull request targets' security feature of GitHub Actions. Will merge; think we are good here. |
dcf7d35 intofluentmigrator:mainUh oh!
There was an error while loading.Please reload this page.
The Windows job in CI was failing due to running a net48 test target on Linux (see PR#2171).
PR#2162 appears to have introduced an extra test run (net8.0 on Windows) although discussion suggested net48 should be Windows-only.
What I changed
Linux runners now execute tests only for net8.0.
Windows runners now execute tests only for net48.
Why
According to the comments on PR#2162 .NET 8.0 is supposed to run on Linux only; running it on Windows is unnecessary and fails.
Keeps net8.0 coverage on Linux while preserving net48 coverage on Windows.
Impact
Green CI on Windows again.
No loss of coverage—just correct platform targeting.