- Notifications
You must be signed in to change notification settings - Fork691
Add StatementFormat to handle more consistently semicolons#2025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…st of the unit tests
# Conflicts:#src/FluentMigrator.Runner.SqlServer/Generators/SqlServer/SqlServer2005Generator.cs
jzabroski left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Need to see what unit test CI says but only have 2 main comments.
src/FluentMigrator.Runner.Oracle/Generators/Oracle/OracleGenerator.cs OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
PhenX commentedMar 31, 2025
OK, there are actually a few tests that still don't pass on my machine, but I'll fix them. |
jzabroski commentedMar 31, 2025
My thought is we should put together an ADR (Architecture Decision Record) for an I honestly don't know if the semicolons added to all the statements is OK or not, but my definition of OK would be if it doesn't break any consumers and is functionally the same, then it is "OK". Does that make sense? In terms of what the ADR would talk about:
|
PhenX commentedMar 31, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
That makes absolutely sense. I'm not sure about the dollar quoting though. Isn't it about IQuoter? |
… on Oracle), happening during migration_version table creation. Solution was to move it to integration tests like others, so that it also tests on other DBMSes
PhenX commentedApr 8, 2025
@jzabroski All tests pass, what do you think about implementing the ISeparator in this pull request ? |
jzabroski commentedApr 14, 2025
I meant to reply last week but was pretty down with allergies. I will try tonight to push up to my jzabroski/FluentMigrator repo what I have so you can look at it. |
jzabroski commentedApr 18, 2025
I'm getting back to this today. Was pretty low on energy due to seasonal allergies the last two weeks, my apologies. |
PhenX commentedApr 18, 2025
No worries ! Take care |
jzabroski commentedMay 7, 2025
@PhenX Plan to merge this today |
In this PR I made a change to handle more consistently statement separators (semicolon here), I may add a ISeparator like you suggested, only for statements for now maybe.
I also removed code in overriden methods that acted like parent classes.
For now all the tests don't pass but I'm working on it.
Tell me what you think and if that's going in a good direction