Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow nestedAssertionScopes to chain their context#2607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@dennisdoomen
Copy link
Member

@dennisdoomendennisdoomen commentedMar 17, 2024
edited
Loading

Ensured that nested assertion scopes produce a nested context. So the statement

usingvarouterScope=newAssertionScope("outer");usingvarinnerScope=newAssertionScope("inner");

Results in a{context} as used inFailWith that containsouter/inner.

This should help#2597 produce a nicer message.

Also fixed an inconsistency in which one overload of the assertion scope constructor would not actually affectAssertionScope.Current.

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with theCoding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is usedin these tests.
  • If the PR adds a feature or fixes a bug, please updatethe release notes with a functional description that explains what the change means to consumers of this library, which are published on thewebsite.
  • If the PR changes the public API the changes needs to be included by runningAcceptApiChanges.ps1 orAcceptApiChanges.sh.
  • If the PR affectsthe documentation, please include your changes in this pull request so the documentation will appear on thewebsite.
    • Please also run./build.sh --target spellcheck or.\build.ps1 --target spellcheck before pushing and check the good outcome

github-actions[bot] reacted with thumbs up emoji
@github-actions
Copy link

github-actionsbot commentedMar 17, 2024
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️View the detailed Qodana report

Contact Qodana team

Contact us atqodana-support@jetbrains.com

@dennisdoomendennisdoomenforce-pushed thefix/nestedassertionscopes branch 4 times, most recently from491cf8a to5d87fdfCompareMarch 17, 2024 20:04
@dennisdoomendennisdoomen marked this pull request as ready for reviewMarch 17, 2024 20:07
@coveralls
Copy link

coveralls commentedMar 17, 2024
edited
Loading

Pull Request Test Coverage Report forBuild 8349307676

Details

  • 14 of14(100.0%) changed or added relevant lines in1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at97.555%

TotalsCoverage Status
Change from baseBuild 8346925366:0.0%
Covered Lines:11996
Relevant Lines:12180

💛 -Coveralls

Also fixed an inconsistency in which one overload of the assertion scope constructor would not actually affect AssertionScope.Current.
@dennisdoomendennisdoomen merged commite760ba4 intofluentassertions:developMar 20, 2024
@dennisdoomendennisdoomen deleted the fix/nestedassertionscopes branchMarch 20, 2024 15:52
@jnyrupjnyrup changed the titleAllow nested AssertionScopes to chain their contextAllow nestedAssertionScopes to chain their contextMay 30, 2024
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull requestJul 14, 2024
…assertions#2607)Also fixed an inconsistency in which one overload of the assertion scope constructor would not actually affect AssertionScope.Current.
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull requestJul 14, 2024
…assertions#2607)Also fixed an inconsistency in which one overload of the assertion scope constructor would not actually affect AssertionScope.Current.
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull requestJul 14, 2024
…assertions#2607)Also fixed an inconsistency in which one overload of the assertion scope constructor would not actually affect AssertionScope.Current.
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull requestAug 18, 2024
…assertions#2607)Also fixed an inconsistency in which one overload of the assertion scope constructor would not actually affect AssertionScope.Current.
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull requestAug 18, 2024
…assertions#2607)Also fixed an inconsistency in which one overload of the assertion scope constructor would not actually affect AssertionScope.Current.
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull requestAug 24, 2024
…assertions#2607)Also fixed an inconsistency in which one overload of the assertion scope constructor would not actually affect AssertionScope.Current.
jnyrup pushed a commit that referenced this pull requestSep 9, 2024
Also fixed an inconsistency in which one overload of the assertion scope constructor would not actually affect AssertionScope.Current.
This was referencedNov 18, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jnyrupjnyrupjnyrup approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dennisdoomen@coveralls@jnyrup

[8]ページ先頭

©2009-2025 Movatter.jp