- Notifications
You must be signed in to change notification settings - Fork1.3k
[@tanstack/react-query] Copy to react-query v5 to v4#4568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
MemberAuthor
Brianzchen commentedMar 3, 2024
There is a CLI unit test that is consistently failing that I'll fix as part of this PR. It's been failing on initial runs for past PRs but for this one it just keeps failing so might be a good time to fix it for good. So far seems to be because the in github actions CI its unable to find the flow definition to test against failing it's assertions when looking for errors |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copying definitions for v5 into v4 because that's what my team uses being stuck on react 17 atm. Breaking changes don't do much to the types to it's just a straight copy and paste
Other notes: