- Notifications
You must be signed in to change notification settings - Fork1.3k
[cli] Tests now run against changed flow version#4406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| if(_flowBinVersionPromise!==null){ | ||
| return_flowBinVersionPromise; | ||
| } | ||
| return(_flowBinVersionPromise=(asyncfunction(){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This blocks main change is the removal of an anonymous function causing a big diff, main changes are addition of callingselectFlowTestVersions and the while loop that pulls all release versions
| constCLIENT=newOctokit(); | ||
| if(process.env.GH_TOK){ | ||
| CLIENT.authenticate({type:'oauth',token:process.env.GH_TOK}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is very old code that isn't actually correct. Updated with new API and reflected in docs
Closes#4384.
Previously, tests would always run against the latest x number of flow versions (default 15). But this made it rather and difficult and unreliable when trying to maintain definitions against older versions as those would never be tested in CI.
With this change, the flow is a bit different:
v0.125.x-) will take the latest 15 versions up to the lower boundary (0.125.x)v0.125.x-v0.135.x) we will start tests against the upper boundary (0.135.x) and take the latest 15 versions starting from there up to the lower boundary (0.125.x)