- Notifications
You must be signed in to change notification settings - Fork1.3k
feat: create sequelize 5/6 defs#3981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
AndrewSouthpaw commentedJan 1, 2021
Not to my knowledge, short of just hacking the CLI code. |
AndrewSouthpaw commentedJan 1, 2021
@jedwards1211 since this is mostly a copy-pasta job, I'm fine with merging if you've poked it enough to be satisfied. |
jedwards1211 commentedJan 1, 2021
Actually let's wait. I'm changing a bunch of stuff over to exact objects and spreads. |
AndrewSouthpaw commentedJan 21, 2021
Sounds good! Let me know when you're ready. |
Brianzchen commentedAug 7, 2022
@jedwards1211 any news on this? |
dannyjlaurence-exp commentedFeb 6, 2023
We too are in need of these - anything we can do to help@jedwards1211? Even a rough outline of the exact objects or spread changes you were thinking about would point us in the right direction. |
Brianzchen commentedFeb 6, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@dannyjlaurence-exp As far as I can tell these are new definitions which doesn't break anything existing. There's also tests in place to an extent. If you can give us some peace of mind that these defs are useful to you, I think we can merge and improve later. Considering also this PR is 2 years old it may be very outdated against current versions of flow |
Other notes:
I copied over the flow_v0.42.x-v0.103.x folders and applied the same changes to them, but I honestly haven't tested them. (Is there a way to tell run_tests what versions of flow to use?)