- Notifications
You must be signed in to change notification settings - Fork106
Explore swappable API key model functionality#191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
florimondmanca wants to merge1 commit intomasterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codecov-commenter commentedDec 5, 2021
Codecov Report
@@ Coverage Diff @@## master #191 +/- ##==========================================- Coverage 96.55% 95.88% -0.67%========================================== Files 22 22 Lines 522 535 +13 ==========================================+ Hits 504 513 +9- Misses 18 22 +4
Continue to review full report at Codecov.
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This is an illustration of a possible resolution for#180.
APIKeymodel would still get created. I'm not sure there's a sensible way out of this, because allowing dropping the model midways, e.g. viaAPI_KEY_MODEL = None, would add migration questions for existing apps.register()any API key models by default, meaning at least they wouldn't see it in the admin. It's possible we want this to be a separate, isolated PR.This would be a fully backwards-compatible change, as the default behavior would match the existing
APIKey-based behavior — except for the admin dropout, which we'd need to document as a change.cc@virogenesis What do you think about this?