- Notifications
You must be signed in to change notification settings - Fork81
[NFC Magic] Returned possibility to write 7b MFC to Gen1 tags#282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
mishamyte wants to merge2 commits intoflipperdevices:devChoose a base branch
base:dev
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
[NFC Magic] Returned possibility to write 7b MFC to Gen1 tags#282
mishamyte wants to merge2 commits intoflipperdevices:devfrommishamyte:bug/return-possibility-to-write-7b-gen1
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Author
mishamyte commentedMay 2, 2025
Was introduced some time ago inxMasterX/all-the-plugins#164 and tested by users |
Member
hedger commentedMay 2, 2025
@mishamyte thanks for the contribution. Could you also bump app version in the manifest and update the changelog? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Before NFC refactor there was a possibility in NFC Magic app to write Gen1 tags with 7b UID (for example:MF Zero 7b or MF-4.
After refactoring additional condition was added.
That PR extends it, giving possibility to write those tags.
The behavior is the same as on TMD if user tries to fit unfittable.
Verification
Checklist (For Reviewer)