Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

ITSO Parser (UK)#3325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gornekich merged 6 commits intoflipperdevices:devfromgsp8181:dev
Feb 6, 2024
Merged

ITSO Parser (UK)#3325

gornekich merged 6 commits intoflipperdevices:devfromgsp8181:dev
Feb 6, 2024

Conversation

@gsp8181
Copy link
Contributor

@gsp8181gsp8181 commentedDec 28, 2023•
edited by gornekich
Loading

What's new

  • ITSO parser added to NFC app. ITSO is a standard for UK transport cards (aside from Oyster). Used for rail, bus and subway passes across GB. This parser grabs the card number and expiry date. More information is available on the card but locked behind propriety apps and an extensive database of station stops and operators is needed.

Verification

  • Scan an ITSO card and verify that the number matches the number printed on the card. Expiry date will match if printed on the card.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

Standard for UK transport cards outside of Oyster
@gornekich
Copy link
Member

Hello@gsp8181 ! Thanks for PR!
Could you please share example .nfc file to verify your PR? You can send it here or DM me in Discord gornekich

Copy link
Member

@gornekichgornekich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hello@gsp8181
Sorry for late review. I tested you PR, everything works great!
Please, make some changes to make code look better and we will merge PR.

@gornekich
Copy link
Member

gornekich commentedJan 10, 2024•
edited
Loading

By the way, we already have#3294 which introduces furi_hal_rtc_timestamp_to_datetime() function. Let's wait when that PR is merged and rework this PR with this function

@skotopesskotopes marked this pull request as draftJanuary 16, 2024 06:31
@skotopes
Copy link
Contributor

Un-draft when ready

@gornekichgornekich marked this pull request as ready for reviewFebruary 6, 2024 18:33
@hedgerhedger added the New FeatureContains an IMPLEMENTATION of a new feature labelFeb 6, 2024
@gornekichgornekich merged commite180266 intoflipperdevices:devFeb 6, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@hedgerhedgerhedger approved these changes

@gornekichgornekichgornekich approved these changes

@skotopesskotopesAwaiting requested review from skotopes

@DrZlo13DrZlo13Awaiting requested review from DrZlo13DrZlo13 is a code owner

@AstrrraAstrrraAwaiting requested review from Astrrra

@gsurkovgsurkovAwaiting requested review from gsurkovgsurkov is a code owner

Assignees

@gornekichgornekich

Labels

New FeatureContains an IMPLEMENTATION of a new featureNFCNFC-related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gsp8181@gornekich@skotopes@hedger
[8]ページ先頭
©2009-2025 Movatter.jp