- Notifications
You must be signed in to change notification settings - Fork60
fix[adjoint]: update polyslab in simulation bounds check to allow for…#2681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:develop
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
… slabs of zero thickness
| is_2d = np.isclose(extents[self.axis], 0.0) | ||
| polyslab_2d = np.isclose(np.diff(self.slab_bounds), 0.0) | ||
| sim_2d = np.isclose(extents[self.axis], 0.0) | ||
| is_2d = polyslab_2d and sim_2d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this is failing a unit test - actually I think maybe we don't want to add the polyslab_2d check in here for cases like the unit test that's failing where the simulation is 2d but the polyslab isn't. in that case, the polyslab should still be integrated as if it was 2d.
… slabs of zero thickness