- Notifications
You must be signed in to change notification settings - Fork223
Add support for firecracker snapshots#760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
CuriousGeorgiy wants to merge2 commits intofirecracker-microvm:mainChoose a base branch fromCuriousGeorgiy:vhive-integration
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Add support for firecracker snapshots#760
CuriousGeorgiy wants to merge2 commits intofirecracker-microvm:mainfromCuriousGeorgiy:vhive-integration
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
f6aaf67 to6bcb731CompareThe current network namespace parameter nested in the JailerConfigparameter requires specifying the entire jailer configuration, which is notconvenient and doesn't allow using the noop jailer with a networknamespace.To overcome this limitation, add a new NetNS parameter to the CreateVMrequest.See also a similar change infirecracker-microvm/firecracker-go-sdk#155.Signed-off-by: Georgiy Lebedev <lebedev.gk@phystech.edu>
09e74c6 to9a7a2bdCompareIn order to support firecracker snapshot-restore we need to make thefollowing changes:* add a new CreateSnapshot request;* add new parameters for snapshot loading to the CreateVM request(following the firecracker Golang SDK design, snapshot loading isessentially creating a VM with additional snapshot options).When a VM is created by loading a snapshot, it's container snapshot drivesare already mounted, so the drive mount stub creation and mounting isskipped.Also add a NetNS (network namespace) parameter to the CreateVM request,since the current NetNS parameter nested in the JailerConfig parameterrequires specifying the entire jailer configuration, which is notconvenient.Signed-off-by: Georgiy Lebedev <lebedev.gk@phystech.edu>
9a7a2bd to6f66aa6CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description of changes:
In order to support firecracker snapshots we need to make the following
changes:
(following the firecracker Golang SDK design, snapshot loading is
essentially creating a VM with additional snapshot options).
Also add a NetNS (network namespace) parameter to the CreateVM request,
since the current NetNS parameter nested in the JailerConfig parameter
requires specifying the entire jailer configuration, which is not
convenient.
Issue #, if available:#759
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.