- Notifications
You must be signed in to change notification settings - Fork7.4k
[FirebaseAI] Add Grounding with Google search sample#2687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
Uh oh!
There was an error while loading.Please reload this page.
…dl/grounding# Conflicts:#firebase-ai/app/src/main/java/com/google/firebase/quickstart/ai/FirebaseAISamples.kt#firebase-ai/app/src/main/java/com/google/firebase/quickstart/ai/feature/text/ChatViewModel.kt#firebase-ai/app/src/main/java/com/google/firebase/quickstart/ai/ui/navigation/Sample.kt#gradle/libs.versions.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Overall LGTM :)
Just 2 comments before we merge
| @@ -33,7 +33,7 @@ androidx-ui-test-manifest = { group = "androidx.compose.ui", name = "ui-test-man | |||
| androidx-ui-tooling = {group ="androidx.compose.ui",name ="ui-tooling" } | |||
| androidx-ui-tooling-preview = {group ="androidx.compose.ui",name ="ui-tooling-preview" } | |||
| compose-navigation = {group ="androidx.navigation",name ="navigation-compose",version.ref ="composeNavigation"} | |||
| firebase-ai = {module ="com.google.firebase:firebase-ai" } | |||
| firebase-ai = {module ="com.google.firebase:firebase-ai",version ="16.2.0" } | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Adding a comment so that we don't forget to undo this before merging
| // Webkit | ||
| implementation(libs.androidx.webkit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can we move these 2 lines up? (around line 62, next to the other androidx dependencies that useimplementation())
Uh oh!
There was an error while loading.Please reload this page.
UiChatMessageto display responses in UI, containingContentandGroundingMetadataMaterial3.DayNight.NoActionBarto allow WebView to adapt to both dark and light themes.